technical-overview.md:256-257: Should the message to be...

[0pdd]

The puzzle 2-51d07485 from #2 has to be resolved:

ndidplatform.github.io/technical-overview.md

Lines 256 to 257 in e997cff

	@todo #2 Should the message to be signed also include the user’s approval status?
	Otherwise, the signature for CONFIRM is identical to REJECT…

The puzzle was created by Thai Pangsakulyanont on 06-Apr-18.

Estimate: 0 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

[dtinth]

Conversation in Slack:

https://green-lantern-poc.slack.com/archives/C9XKSH29X/p1522967428000127

@dtinth:

In my opinion, the data_request_list along with request_params should also be signed, to allow auditing the request params from the IdP. Scenario: RP asks user for a transaction history in the past 6 months in the request_message but put 20 years into request_params instead.

If request_params is not signed, then the signature for 6 months history request is indistinguishable from a 20 years history request, allowing repudiation from RP side.

@Bankde:

I thought the signature is to prevent having message (ขอ Bank statement) committed into a block ? Since the blockchain itself could handle integrity and non-repudiation.

I agree we should either put request_params into block or include it in the signature.

To prevent misunderstanding, better talk together in next meeting ? Since the document is pretty sensitive, I personally prefer Aj. Bhume to review any change.

@bact

น่าจะรวบรวมทั้งหมดนี้เป็น FAQ 😄

[bhume]

Okay, I'm re-writing this flow on this side a little bit, will update soon. Take into account request_params to be signed, which means IDP must also received all the params, and display it in a human readable format to the user, then sign each authorized request and put back in Blockchain. This change will touch several spot in the flow, will get to it soon. Thanks