feat: supports CSS properties from W3C and MDN

Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

Author: neilime

.dockerignore

@@ -3,6 +3,7 @@ nbproject/
 vendor
 tools/vendor
 **/composer.lock
+**/.cache
 **/tests/.phpunit.result.cache
 **/build/
 # From tools/cache/.gitignore

.gitignore

@@ -2,5 +2,6 @@
 /vendor
 /tools/vendor
 composer.lock
+.cache
 tests/.phpunit.result.cache
 build/

Makefile

@@ -9,7 +9,7 @@ IMAGE="${PROJECT_NAME}:${PHP_VERSION}"
 help:
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
 
-setup: build-php install ## Initialize project
+setup: build-php install test-load-fixtures ## Initialize project
 
 build-php: ## Build PHP image
 	@echo "Build php ${PHP_VERSION}"
@@ -30,6 +30,9 @@ test: ## Execute tests for given PHP version
 test-update: ## Execute tests and update snapshots for given PHP version
 	@$(call run-php,composer test:update-snapshot $(filter-out $@,$(MAKECMDGOALS)))
 
+test-load-fixtures: ## Execute tests and load fixtures for given PHP version
+	@$(call run-php,composer test:load-fixtures $(filter-out $@,$(MAKECMDGOALS)))
+
 lint: ## Execute lint for given PHP version
 	@$(call run-php,composer php-cs-fixer $(filter-out $@,$(MAKECMDGOALS)))
 

README.md

@@ -9,7 +9,8 @@
 [![License](https://poser.pugx.org/neilime/php-css-lint/license)](https://packagist.org/packages/neilime/php-css-lint)
 [![Sponsor](https://img.shields.io/badge/%E2%9D%A4-Sponsor-ff69b4)](https://github.com/sponsors/neilime)
 
-📢 **Php CSS Lint** is a php script that lint css files and strings:
+📢 **Php CSS Lint** is a php script that lint css files and strings.
+It supports [W3C](https://www.w3.org/Style/CSS/) and [MDN](https://developer.mozilla.org/en-US/docs/Web/CSS) CSS specifications.
 
 ```
 ===========================================================

composer.json

@@ -27,9 +27,14 @@
     "ext-json": "*"
   },
   "require-dev": {
+    "guzzlehttp/guzzle": "^7.9",
     "mikey179/vfsstream": "^1.6",
     "pcov/clobber": "^2.0",
-    "phpunit/phpunit": "^9.5.27"
+    "phpunit/phpunit": "^9.5.27",
+    "symfony/cache": "^7.2",
+    "symfony/console": "^7.2",
+    "symfony/css-selector": "^7.2",
+    "symfony/dom-crawler": "^7.2"
   },
   "autoload": {
     "psr-4": {
@@ -38,14 +43,16 @@
   },
   "autoload-dev": {
     "psr-4": {
-      "TestSuite\\": "tests/TestSuite"
+      "Tests\\Fixtures\\": "tests/Fixtures",
+      "Tests\\TestSuite\\": "tests/TestSuite"
     }
   },
   "bin": [
     "scripts/php-css-lint"
   ],
   "scripts": {
     "test": "phpunit --colors --configuration tests/phpunit.xml",
+    "test:load-fixtures": "php scripts/css-referential-scraper && php scripts/css-popular-downloader",
     "test:ci": "@test -d pcov.enabled=1 -d max_execution_time=0 --coverage-text --coverage-clover ./build/logs/clover.xml --coverage-html ./build/coverage/",
     "php-cs-fixer": "@php-cs-fixer:fix --dry-run",
     "php-cs-fixer:fix": "tools/vendor/bin/php-cs-fixer fix --show-progress=dots --diff --config=.php-cs-fixer.dist.php",

scripts/css-popular-downloader

@@ -0,0 +1,11 @@
+#!/usr/bin/env php
+<?php
+
+require __DIR__ . '/../vendor/autoload.php';
+
+use Tests\Fixtures\Downloader\CssFileDownloader;
+
+$downloader = new CssFileDownloader();
+$downloader->downloadLatestFiles(__DIR__ . '/../tests/fixtures');
+
+echo "Done.\n";

scripts/css-referential-generator

@@ -0,0 +1,56 @@
+#!/usr/bin/env php
+<?php
+
+require __DIR__ . '/../vendor/autoload.php';
+
+function saveDataset(string $className, array $referential): void
+{
+    $datasetClass = new ReflectionClass($className);
+    $datasetFile = $datasetClass->getFileName();
+
+    $referentialString = var_export($referential, true);
+    $referentialString = str_replace('array (', '[', $referentialString);
+    $referentialString = str_replace(')', ']', $referentialString);
+
+    $datasetFileContent = file_get_contents($datasetFile);
+    $datasetFileContent = preg_replace(
+        '/public static array \$referential = \[.*?\];/s',
+        'public static array $referential = ' . $referentialString . ';',
+        $datasetFileContent
+    );
+
+    file_put_contents($datasetFile, $datasetFileContent);
+}
+
+$cssPropertiesFile = __DIR__ . '/../tests/fixtures/css-properties.json';
+$cssProperties = json_decode(file_get_contents($cssPropertiesFile), true);
+
+$standardsProperties = [];
+$nonStandardsProperties = [];
+
+foreach ($cssProperties as $propertyName => $property) {
+    $isStandard = $property['standard'] ?? false;
+    if ($isStandard) {
+        $standardsProperties[$propertyName] = true;
+    } else {
+        $nonStandardsProperties[$propertyName] = true;
+    }
+}
+
+// Add missing non-standard properties
+$missingNonStandardsProperties = [
+    '-webkit-overflow-scrolling',
+    '-webkit-margin-end',
+    '-moz-osx-font-smoothing',
+];
+foreach ($missingNonStandardsProperties as $propertyName) {
+    if (isset($standardsProperties[$propertyName]) || isset($nonStandardsProperties[$propertyName])) {
+        throw new Exception("Property $propertyName already exists in either standards or non-standards properties.");
+    }
+    $nonStandardsProperties[$propertyName] = true;
+}
+
+ksort($standardsProperties);
+ksort($nonStandardsProperties);
+saveDataset(CssLint\Referential\StandardPropertiesReferential::class, $standardsProperties);
+saveDataset(CssLint\Referential\NonStandardPropertiesReferential::class, $nonStandardsProperties);

scripts/css-referential-scraper

@@ -0,0 +1,20 @@
+#!/usr/bin/env php
+<?php
+
+require __DIR__ . '/../vendor/autoload.php';
+
+use Tests\Fixtures\Downloader\CssReferentialScraper;
+
+$forceRefresh = in_array('--force-refresh', $argv);
+
+$scraper = new CssReferentialScraper($forceRefresh);
+
+echo "Fetching CSS property list...\n";
+$referentials = $scraper->fetchReferentials();
+
+echo "Fetched " . count($referentials['properties']) . " properties\n";
+$cssPropertiesFile = __DIR__ . '/../tests/fixtures/css-properties.json';
+$scraper->saveToJson($referentials['properties'], $cssPropertiesFile);
+echo "Saved to {$cssPropertiesFile}\n";
+
+echo "Done.\n";

src/CssLint/Linter.php

@@ -335,7 +335,7 @@ protected function lintSelectorChar(string $charValue): ?bool
             // Wildcard and hash
             if (in_array($charValue, ['*', '#'], true)) {
                 $selector = $this->getContextContent();
-                if ($selector === '' || $selector === '0' || preg_match('/[a-zA-Z>,\'"] *$/', $selector)) {
+                if ($selector === '' || $selector === '0' || preg_match('/[a-zA-Z>+,\'"] *$/', $selector)) {
                     $this->addContextContent($charValue);
                     return true;
                 }