Skip to content

Commit 178d593

Browse files
committed
Update memory estimations
1 parent 4c56741 commit 178d593

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

ml/ml-algo/src/test/java/org/neo4j/gds/ml/models/randomforest/RandomForestClassifierTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -237,19 +237,19 @@ void predictOverheadMemoryEstimation(
237237

238238
@ParameterizedTest
239239
@CsvSource(value = {
240-
" 6, 100_000, 10, 10, 1, 1, 0.1, 1.0, 4413594, 5226418",
240+
" 6, 100_000, 10, 10, 1, 1, 0.1, 1.0, 4413602, 5226426",
241241
// Should increase fairly little with more trees if training set big.
242-
" 10, 100_000, 10, 10, 1, 10, 0.1, 1.0, 4414242, 6295802",
242+
" 10, 100_000, 10, 10, 1, 10, 0.1, 1.0, 4414250, 6295810",
243243
// Should be capped by number of training examples, despite high max depth.
244-
" 8_000, 500, 10, 10, 1, 1, 0.1, 1.0, 23154, 182954",
244+
" 8_000, 500, 10, 10, 1, 1, 0.1, 1.0, 23162, 182962",
245245
// Should increase very little when having more classes.
246-
" 10, 100_000, 100, 10, 1, 10, 0.1, 1.0, 4414962, 6296522",
246+
" 10, 100_000, 100, 10, 1, 10, 0.1, 1.0, 4414970, 6296530",
247247
// Should increase very little when using more features for splits.
248-
" 10, 100_000, 100, 10, 1, 10, 0.9, 1.0, 4415034, 6296686",
248+
" 10, 100_000, 100, 10, 1, 10, 0.9, 1.0, 4415042, 6296694",
249249
// Should decrease a lot when sampling fewer training examples per tree.
250-
" 10, 100_000, 100, 10, 1, 10, 0.1, 0.2, 1204962, 2446522",
250+
" 10, 100_000, 100, 10, 1, 10, 0.1, 0.2, 1204970, 2446530",
251251
// Should almost be x4 when concurrency * 4.
252-
" 10, 100_000, 100, 10, 4, 10, 0.1, 1.0, 16457256, 21037256",
252+
" 10, 100_000, 100, 10, 4, 10, 0.1, 1.0, 16457264, 21037264",
253253
})
254254
void trainMemoryEstimation(
255255
int maxDepth,

pipeline/src/test/java/org/neo4j/gds/ml/pipeline/linkPipeline/train/LinkPredictionTrainTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,15 +175,15 @@ static Stream<Arguments> paramsForEstimationsWithParamSpace() {
175175
.build()
176176
.toTunableConfig()
177177
),
178-
MemoryRange.of(59696, 900016)
178+
MemoryRange.of(59704, 900024)
179179
),
180180
Arguments.of(
181181
"Default RF and default LR",
182182
List.of(
183183
LogisticRegressionTrainConfig.DEFAULT.toTunableConfig(),
184184
RandomForestTrainerConfig.DEFAULT.toTunableConfig()
185185
),
186-
MemoryRange.of(66696, 2731864)
186+
MemoryRange.of(66704, 2731872)
187187
),
188188
Arguments.of(
189189
"Default RF and default LR with range",
@@ -194,7 +194,7 @@ static Stream<Arguments> paramsForEstimationsWithParamSpace() {
194194
),
195195
RandomForestTrainerConfig.DEFAULT.toTunableConfig()
196196
),
197-
MemoryRange.of(66696, 2731864)
197+
MemoryRange.of(66704, 2731872)
198198
),
199199
Arguments.of(
200200
"Default RF and default LR with batch size range",

proc/machine-learning/src/test/java/org/neo4j/gds/ml/nodemodels/pipeline/NodeClassificationTrainPipelineExecutorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ public static Stream<Arguments> trainerMethodConfigs() {
273273
),
274274
Arguments.of(
275275
List.of(RandomForestTrainerConfig.DEFAULT.toTunableConfig()),
276-
MemoryRange.of(106578L, 223350L)
276+
MemoryRange.of(106586L, 223358L)
277277
),
278278
Arguments.of(
279279
List.of(LogisticRegressionTrainConfig.DEFAULT.toTunableConfig(), RandomForestTrainerConfig.DEFAULT.toTunableConfig()),

0 commit comments

Comments
 (0)