Skip to content

Commit 402934a

Browse files
committed
fixup after rebase
1 parent 98f28bf commit 402934a

File tree

4 files changed

+38
-655
lines changed

4 files changed

+38
-655
lines changed

algo/src/main/java/org/neo4j/gds/similarity/filteredknn/FilteredKnn.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@
2525
import org.neo4j.gds.similarity.knn.Knn;
2626
import org.neo4j.gds.similarity.knn.KnnContext;
2727

28-
<<<<<<< HEAD
29-
=======
30-
import java.util.List;
31-
3228
/**
3329
* Filtered KNN is the same as ordinary KNN, _but_ we allow users to regulate final output in two ways.
3430
*
@@ -74,10 +70,10 @@ public FilteredKnnResult compute() {
7470
Knn.Result result = delegate.compute();
7571

7672
return ImmutableFilteredKnnResult.of(
77-
targetNodeFiltering,
7873
result.ranIterations(),
7974
result.didConverge(),
8075
result.nodePairsConsidered(),
76+
targetNodeFiltering,
8177
sourceNodeFilter
8278
);
8379
}

algo/src/main/java/org/neo4j/gds/similarity/filteredknn/FilteredKnnResult.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,26 @@
2222
import org.neo4j.gds.annotation.ValueClass;
2323
import org.neo4j.gds.similarity.SimilarityResult;
2424

25-
import java.util.List;
2625
import java.util.stream.Stream;
2726

2827
@ValueClass
2928
public abstract class FilteredKnnResult {
30-
abstract TargetNodeFiltering neighbourConsumers();
31-
3229
public abstract int ranIterations();
3330

3431
public abstract boolean didConverge();
3532

3633
public abstract long nodePairsConsidered();
3734

38-
public abstract List<Long> sourceNodes();
39-
4035
public Stream<SimilarityResult> similarityResultStream() {
4136
TargetNodeFiltering neighbourConsumers = neighbourConsumers();
42-
List<Long> sourceNodes = sourceNodes();
37+
NodeFilter sourceNodeFilter = sourceNodeFilter();
4338

44-
return neighbourConsumers.asSimilarityResultStream(sourceNodes::contains);
39+
return neighbourConsumers.asSimilarityResultStream(sourceNodeFilter);
4540
}
41+
42+
// ***
43+
// Below is for internal use only
44+
// ***
45+
abstract TargetNodeFiltering neighbourConsumers();
46+
abstract NodeFilter sourceNodeFilter();
4647
}

algo/src/test/java/org/neo4j/gds/similarity/filteredknn/FilteredKnnResultTest.java

Lines changed: 0 additions & 109 deletions
This file was deleted.

0 commit comments

Comments
 (0)