Skip to content

Commit 7c9b150

Browse files
Add assertions to param resolve filter test
1 parent a6d3715 commit 7c9b150

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

proc/catalog/src/test/java/org/neo4j/gds/catalog/GraphProjectSubgraphProcTest.java

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import org.junit.jupiter.api.AfterEach;
2323
import org.junit.jupiter.api.BeforeEach;
2424
import org.junit.jupiter.api.Test;
25+
import org.junit.jupiter.params.ParameterizedTest;
26+
import org.junit.jupiter.params.provider.CsvSource;
2527
import org.neo4j.gds.BaseProcTest;
2628
import org.neo4j.gds.GdsCypher;
2729
import org.neo4j.gds.beta.filter.expression.SemanticErrors;
@@ -33,10 +35,12 @@
3335
import java.util.List;
3436
import java.util.Map;
3537

38+
import static org.assertj.core.api.Assertions.assertThat;
3639
import static org.assertj.core.api.Assertions.assertThatThrownBy;
3740
import static org.hamcrest.Matchers.greaterThan;
3841
import static org.neo4j.gds.TestSupport.assertGraphEquals;
3942
import static org.neo4j.gds.TestSupport.fromGdl;
43+
import static org.neo4j.gds.utils.StringFormatting.formatWithLocale;
4044

4145
class GraphProjectSubgraphProcTest extends BaseProcTest {
4246

@@ -165,10 +169,20 @@ void throwsOnSemanticRelationshipError() {
165169
.hasMessageContaining("Unknown relationship type `BAR`.");
166170
}
167171

168-
@Test
169-
void shouldResolveParameters() {
170-
var subGraphQuery = "CALL gds.beta.graph.project.subgraph('subgraph', 'graph', 'true', 'r:REL AND r.weight > $weight', { parameterMap: { weight: $weight } })";
172+
@ParameterizedTest
173+
@CsvSource({
174+
"=, 1",
175+
">, 0"
176+
})
177+
void shouldResolveParameters(String operator, int expectedRelationships) {
178+
var subGraphQuery = formatWithLocale(
179+
"CALL gds.beta.graph.project.subgraph('subgraph', 'graph', 'true', 'r:REL AND r.weight %s $weight', { parameterMap: { weight: $weight } })",
180+
operator
181+
);
171182

172183
runQuery(subGraphQuery, Map.of("weight", 42));
184+
185+
var graphStore = GraphStoreCatalog.get("", db.databaseId(), "subgraph").graphStore();
186+
assertThat(graphStore.relationshipCount()).isEqualTo(expectedRelationships);
173187
}
174188
}

0 commit comments

Comments
 (0)