Register new rel properties when added

Author: soerenreichardt

cypher/api/storage-engine-adapter/src/main/java/org/neo4j/gds/compat/TokenManager.java

@@ -61,11 +61,7 @@ public void nodePropertyRemoved(String propertyKey) {
 
     @Override
     public void nodePropertyAdded(String propertyKey) {
-        try {
-            tokenHolders.propertyKeyTokens().getOrCreateId(propertyKey);
-        } catch (KernelException e) {
-            throw new RuntimeException(e);
-        }
+        getOrCreatePropertyToken(propertyKey);
     }
 
     @Override
@@ -86,6 +82,19 @@ public void relationshipTypeAdded(String relationshipType) {
         }
     }
 
+    @Override
+    public void relationshipPropertyAdded(String relationshipProperty) {
+        getOrCreatePropertyToken(relationshipProperty);
+    }
+
+    private void getOrCreatePropertyToken(String propertyKey) {
+        try {
+            tokenHolders.propertyKeyTokens().getOrCreateId(propertyKey);
+        } catch (KernelException e) {
+            throw new RuntimeException(e);
+        }
+    }
+
     public TokenHolders tokenHolders() {
         return this.tokenHolders;
     }

cypher/api/storage-engine-adapter/src/main/java/org/neo4j/gds/storageengine/InMemoryRelationshipCursor.java

@@ -161,7 +161,7 @@ private void newRelationshipIdContextAdded(RelationshipIds.RelationshipIdContext
                 .map(AdjacencyProperties::rawPropertyCursor)
                 .toArray(PropertyCursor[]::new)
         );
-        var newSize = this.propertyCursorCache.size() + relationshipIdContext.adjacencyProperties().length;
+        var newSize = this.propertyCursorCache.stream().mapToInt(cursor -> cursor.length).max().orElse(0);
         this.propertyValuesCache = new DoubleArrayList(new double[newSize]);
     }
 

cypher/cypher-core/src/main/java/org/neo4j/gds/core/cypher/CypherGraphStore.java

@@ -93,6 +93,9 @@ public void addRelationshipType(
         Relationships relationships
     ) {
         super.addRelationshipType(relationshipType, relationshipPropertyKey, relationshipPropertyType, relationships);
+        relationshipPropertyKey.ifPresent(
+            propertyKey -> stateVisitors.forEach(stateVisitor -> stateVisitor.relationshipPropertyAdded(propertyKey))
+        );
         stateVisitors.forEach(stateVisitor -> stateVisitor.relationshipTypeAdded(relationshipType.name()));
     }
 
@@ -109,6 +112,8 @@ public interface StateVisitor {
 
         void relationshipTypeAdded(String relationshipType);
 
+        void relationshipPropertyAdded(String relationshipProperty);
+
         class Adapter implements StateVisitor {
             @Override
             public void nodePropertyRemoved(String propertyKey) {
@@ -129,6 +134,11 @@ public void nodeLabelAdded(String nodeLabel) {
             public void relationshipTypeAdded(String relationshipType) {
 
             }
+
+            @Override
+            public void relationshipPropertyAdded(String relationshipProperty) {
+
+            }
         }
     }
 }