Merge pull request #270 from technige/1.7-non-string-keys

[1.7.1] Raise TypeError for non-string dictionary keys

Author: technige

neo4j/types/__init__.py

@@ -125,6 +125,8 @@ def dehydrate_(obj):
             elif isinstance(obj, (list, map_type)):
                 return list(map(dehydrate_, obj))
             elif isinstance(obj, dict):
+                if any(not isinstance(key, string) for key in obj.keys()):
+                    raise TypeError("Non-string dictionary keys are not supported")
                 return {key: dehydrate_(value) for key, value in obj.items()}
             else:
                 raise TypeError(obj)

test/integration/test_types.py

@@ -103,6 +103,11 @@ def test_map(self):
             result = session.run("RETURN {one: 'eins', two: 'zwei', three: 'drei'}")
             self.assertEqual(result.single().value(), {"one": "eins", "two": "zwei", "three": "drei"})
 
+    def test_non_string_map_keys(self):
+        with self.driver.session() as session:
+            with self.assertRaises(TypeError):
+                _ = session.run("RETURN $x", x={1: 'eins', 2: 'zwei', 3: 'drei'})
+
 
 class GraphTypeOutputTestCase(DirectIntegrationTestCase):