Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds manual workflow dispatch, fetches the latest App Store Connect build to compute/increment build numbers (with override support), and adds a job that comments merge commits with TestFlight version/build info and platform badges. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant Runner as CI Runner
participant ASC as App Store Connect API
participant Repo as GitHub Repo (Comments)
GH->>Runner: trigger job (push or workflow_dispatch)
Runner->>Runner: determine ref/version, enable uploads
Runner->>ASC: GET latest uploaded build for pre-release version
ASC-->>Runner: 200 + latest build OR non-200 (abort)
alt latest build available
Runner->>Runner: compute build-number (override? use override : increment latest)
else no latest build
Runner->>Runner: compute build-number = '1' or override
end
Runner->>Repo: if push merge commit -> post comment with version/build and badges
Repo-->>Runner: comment posted
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
evgeniyChepelev
changed the title
Contributor
|
/testflight |
|
TestFlight builds uploaded |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/testflight.yml (1)
3-28:⚠️ Potential issue | 🟠 Major
workflow_dispatchis handled ingate.ifandprebut not declared inon:— dead branch.Line 25 (
github.event_name == 'workflow_dispatch') and line 56 (treatingworkflow_dispatchlikepushin theprescript) will never fire becauseworkflow_dispatchis not listed underon:(lines 3-10). The PR description advertises manual triggering, so either the trigger declaration is missing or the conditionals are dead code.🛠 Proposed fix — add the trigger declaration
on: push: branches: [main] pull_request: branches: [main] types: [opened, edited] issue_comment: types: [created] + workflow_dispatch:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/testflight.yml around lines 3 - 28, The workflow currently evaluates github.event_name == 'workflow_dispatch' in the gate job (and the pre script) but never declares workflow_dispatch under the on: triggers, so those branches are dead; update the top-level triggers by adding workflow_dispatch to the on: section (so manual triggers are allowed) or remove the workflow_dispatch checks from the gate and pre logic—specifically modify the on: block that declares push, pull_request, and issue_comment to include workflow_dispatch so the gate job and the pre script's workflow_dispatch checks can actually fire.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/testflight.yml:
- Around line 161-193: Set a shell trap to always remove /tmp/AuthKey.p8 on exit
so the key is cleaned up even when the script exits early (e.g., after the
HTTP_STATUS check); specifically, add a line like trap 'rm -f /tmp/AuthKey.p8'
EXIT near the start of this run block (before creating JWT and calling curl),
then you can remove the final explicit rm -f /tmp/AuthKey.p8 at the end—this
ensures the temporary key is deleted regardless of whether HTTP_STATUS, JWT, or
curl causes an exit.
- Around line 183-227: The workflow can produce "null" for LATEST_BUILD and
parseInt can yield NaN or truncate dotted CFBundleVersion strings; update the
earlier jq assignment for LATEST_BUILD (symbol LATEST_BUILD / ASC_LATEST_BUILD)
to map null to "none" (so jq emits "none" not "null"), and in the finalize
step's script validate latestBuild before using parseInt: check that latestBuild
matches an integer regexp (e.g. /^\d+$/) or that parsed = parseInt(latestBuild,
10) is a finite number, otherwise treat it as absent; then compute buildNumber
using overrideBuild fallback, validated parsed latestBuild + 1, or '1' as a safe
default (refer to variables overrideBuild, latestBuild, runNumber, and
buildNumber in the finalize script).
- Line 166: The workflow step that runs the inline Python JWT generator (the
JWT=$(python3 -c "import ... cryptography.hazmat.primitives ...") command) uses
the cryptography package which is not available by default on ubuntu-latest;
before that command either add a step to run pip install cryptography (and any
build deps) or move the Python logic into a separate script and ensure that
script's step installs cryptography first; make sure the installation step runs
prior to the JWT generation step and references the same KEY_ID/ISSUER_ID
environment usage.
---
Outside diff comments:
In @.github/workflows/testflight.yml:
- Around line 3-28: The workflow currently evaluates github.event_name ==
'workflow_dispatch' in the gate job (and the pre script) but never declares
workflow_dispatch under the on: triggers, so those branches are dead; update the
top-level triggers by adding workflow_dispatch to the on: section (so manual
triggers are allowed) or remove the workflow_dispatch checks from the gate and
pre logic—specifically modify the on: block that declares push, pull_request,
and issue_comment to include workflow_dispatch so the gate job and the pre
script's workflow_dispatch checks can actually fire.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bf05d7bd-b3c5-439b-95c3-77f8068ba5a3
📒 Files selected for processing (1)
.github/workflows/testflight.yml
pappz
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
• Query App Store Connect API before each build to get the latest uploaded build number for the current version
• Set new build number to latest + 1 automatically (starts from 1 if no builds exist yet)
• On merge to main, post a comment on the merge commit with version, build number, and iOS/tvOS build status
• Fixed CodeQL code injection warning — step outputs are passed via env: instead of being interpolated directly into • JavaScript
Summary by CodeRabbit