Skip to content

Commit 3c31c12

Browse files
committed
Merge remote-tracking branch 'origin/release/6.4.2' into NAE-2290
# Conflicts: # projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts
2 parents 3b1f375 + 42949df commit 3c31c12

File tree

8 files changed

+17
-9
lines changed

8 files changed

+17
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ Full Changelog: [https://github.com/netgrif/components/commits/v6.4.2](https://g
99

1010
## [6.4.2](https://github.com/netgrif/components/releases/tag/v6.4.2) (2025-05-16)
1111

12+
### Fixed
13+
- [NAE-2231] Unable to change behavior of taskRef on finish event without error message
14+
- [NAE-2268] Fix resolving of referenced taskId on frontend
15+
1216
### Added
1317
- [NAE-2100] Case view export button as NAE feature
1418

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@netgrif/components-project",
3-
"version": "6.4.2-rc.1",
3+
"version": "6.4.2-rc.5",
44
"description": "Netgrif Application Engine Frontend project. Project includes angular libraries as base for NAE applications.",
55
"homepage": "https://components.netgrif.com",
66
"license": "SEE LICENSE IN LICENSE",

projects/netgrif-components-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@netgrif/components-core",
3-
"version": "6.4.2-rc.1",
3+
"version": "6.4.2-rc.5",
44
"description": "Netgrif Application engine frontend core Angular library",
55
"homepage": "https://components.netgrif.com",
66
"license": "SEE LICENSE IN LICENSE",

projects/netgrif-components-core/src/lib/event/model/event-outcomes/task-outcomes/finish-task-event-outcome.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ import {TaskEventOutcome} from './task-event-outcome';
22

33
// eslint-disable-next-line @typescript-eslint/no-empty-interface
44
export interface FinishTaskEventOutcome extends TaskEventOutcome {
5-
5+
isTaskStillExecutable?: boolean;
66
}

projects/netgrif-components-core/src/lib/resources/interface/task.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,6 @@ export interface Task {
7070
delegateTitle?: string;
7171
immediateData?: Array<ImmediateData>;
7272
assignedUserPolicy?: AssignedUserPolicy;
73+
74+
isStillExecutable?: boolean;
7375
}

projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,11 +206,12 @@ export abstract class TaskContentService implements OnDestroy {
206206
/**
207207
* Clears the assignee, start date and finish date from the managed Task.
208208
*/
209-
public updateStateData(eventOutcome: TaskEventOutcome): void {
209+
public updateStateData(eventOutcome: TaskEventOutcome, isStillExecutable: boolean = true): void {
210210
if (this._task) {
211211
this._task.user = eventOutcome.task.user;
212212
this._task.startDate = eventOutcome.task.startDate;
213213
this._task.finishDate = eventOutcome.task.finishDate;
214+
this._task.isStillExecutable = isStillExecutable;
214215
}
215216
}
216217

@@ -235,7 +236,7 @@ export abstract class TaskContentService implements OnDestroy {
235236
}
236237

237238
protected updateField(chFields: ChangedFields, field: DataField<any>, frontendActions: Change, referenced: boolean = false): void {
238-
if (this._fieldConverterService.resolveType(field) === FieldTypeResource.TASK_REF) {
239+
if (this._fieldConverterService.resolveType(field) === FieldTypeResource.TASK_REF && (!!this._task?.isStillExecutable || this._task?.isStillExecutable === undefined)) {
239240
this._taskDataReloadRequest$.next(frontendActions ? frontendActions : undefined);
240241
return;
241242
}
@@ -312,7 +313,7 @@ export abstract class TaskContentService implements OnDestroy {
312313
protected findTaskRefId(taskId: string, fields: { [fieldId: string]: DataField<any>}): DataField<any> {
313314
let taskRefId = Object.values(fields).find(f => f instanceof TaskRefField && f.value.includes(taskId));
314315
if (!taskRefId) {
315-
const referencedTaskIds = Object.values(fields).filter(f => f instanceof TaskRefField).map(tr => tr.value);
316+
const referencedTaskIds = Array.prototype.concat.apply([], Object.values(fields).filter(f => f instanceof TaskRefField).map(tr => tr.value));
316317
for (const id of referencedTaskIds) {
317318
taskRefId = this.findTaskRefId(taskId, this.taskFieldsIndex[id].fields);
318319
if (!!taskRefId) {

projects/netgrif-components-core/src/lib/task/services/finish-task.service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ export class FinishTaskService extends TaskHandlingService {
133133
}
134134

135135
if (outcomeResource.success) {
136-
this._taskContentService.updateStateData(outcomeResource.outcome as FinishTaskEventOutcome);
136+
const outcome = outcomeResource.outcome as FinishTaskEventOutcome
137+
this._taskContentService.updateStateData(outcome, outcome.isTaskStillExecutable);
137138
const changedFieldsMap: ChangedFieldsMap = this._eventService
138139
.parseChangedFieldsFromOutcomeTree(outcomeResource.outcome);
139140
if (!!changedFieldsMap) {

projects/netgrif-components/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@netgrif/components",
3-
"version": "6.4.2-rc.1",
3+
"version": "6.4.2-rc.5",
44
"description": "Netgrif Application Engine frontend Angular components",
55
"homepage": "https://components.netgrif.com",
66
"license": "SEE LICENSE IN LICENSE",
@@ -29,7 +29,7 @@
2929
"nae frontend"
3030
],
3131
"peerDependencies": {
32-
"@netgrif/components-core": "6.4.2-rc.1",
32+
"@netgrif/components-core": "6.4.2-rc.5",
3333
"@angular-material-components/datetime-picker": "~7.0.1",
3434
"@angular-material-components/moment-adapter": "~7.0.0",
3535
"@angular/animations": "~13.3.1",

0 commit comments

Comments
 (0)