[Schedule] Tabbed schedule view jumps back to current day after selecting another day in the future

[astevens93]

Describe the bug
Tabbed schedule view jumps back to current day after selecting another day in the future.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.hcrfm.co.uk/on-air/schedule/
2. Click on any day in the future from today
3. See the behaviour of the tab jumping back to current day

Expected behavior
Previous versions behaved normally, user selects day they wish to view, it stays on that day until the user refreshes the page or clicks on another day.

Additional context
Happening in Version 2.5.13 (Free) with Version 2.6.9 (Pro) installed.

[tonyzeoli]

@astevens93 I've assigned this to @majick777 and he'll look at it. Thanks for the report.

[majick777]

@astevens93 Confirmed the bug on your site, but this wasn't happening on the demo site... I changed the code a bit to try to avoid it triggering a tab click twice. Test out the fix via development branch to see if that worked for you and let me know.

At the same time found that schedule week switching wasn't switching to the currently selected day, but reverting to the start of week on change... so I fixed that in also (for Pro.)

[astevens93]

Hi @majick777 thanks for this, though upon installing it doesn't seem to load the schedule, I have to click on the day to do that (it just loads the date picker).

As this is a live site, I've had to roll back to the stable version v2.6.9 where this doesn't seem to be a problem with

[majick777]

@astevens93 The problem could be with the new AJAX schedule loading, added to help bypass page caching.

To confirm this you could try updating to 2.5.13 and then disable the schedule ajax loading on the settings page (Pages -> Schedule Page -> AJAX Load?) and test it again. I still can't reproduce the issue elsewhere yet but this could help narrow it down.

[tonyzeoli]

@astevens93 did you see @majick777 last message about testing with the AJAX Load disabled?

[astevens93]

@majick777 @tonyzeoli My sincere apologies for the delay in responding. To confirm, disabling AJAX Loading, does indeed resolve the problem, yes.