From baad10bd511124a66457d86fd146dcf0c6dcb36a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 12:43:12 +0000 Subject: [PATCH 1/4] Initial plan From 6263d5f41054e1ab14d7c050aba77f835abd6852 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 12:45:55 +0000 Subject: [PATCH 2/4] Fix variable type: revert N to size_t, keep loop var as ptrdiff_t Co-authored-by: anderskaestner <11174364+anderskaestner@users.noreply.github.com> --- frameworks/ngi/nGIFramework/src/nGIProcessor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp b/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp index 40706ac..19dfd48 100644 --- a/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp +++ b/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp @@ -278,7 +278,7 @@ kipl::base::TImage ,2> DpcProcessor::ComputeHarmonicImage(kipl::b void DpcProcessor::ComputeResultImages() { // Compute transmission image - const ptrdiff_t N=static_cast(openbeamDC.Size()); + const size_t N=openbeamDC.Size(); complex *pOpenBeamDC = openbeamDC.GetDataPtr(); complex *pSampleDC = sampleDC.GetDataPtr(); From 363a904f9c73f4cb1fa79d94a8dd8958de817150 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 12:47:27 +0000 Subject: [PATCH 3/4] Add explicit cast in loop condition to avoid signed/unsigned comparison Co-authored-by: anderskaestner <11174364+anderskaestner@users.noreply.github.com> --- frameworks/ngi/nGIFramework/src/nGIProcessor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp b/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp index 19dfd48..98ebfa9 100644 --- a/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp +++ b/frameworks/ngi/nGIFramework/src/nGIProcessor.cpp @@ -293,7 +293,7 @@ void DpcProcessor::ComputeResultImages() float *pPhaseContrast=phasecontrast.GetDataPtr(); float *pDarkField=darkfield.GetDataPtr(); #pragma omp parallel for - for (ptrdiff_t i=0; i(N); i++) { pTransmision[i]=abs(pSampleDC[i])/abs(pOpenBeamDC[i]); if (mConfig.process.bUseAmplLimits) { From e97a0fc234ba09f0223259ce21b42f92b9906578 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 4 Dec 2025 12:48:25 +0000 Subject: [PATCH 4/4] Final update after addressing all feedback Co-authored-by: anderskaestner <11174364+anderskaestner@users.noreply.github.com> --- _codeql_detected_source_root | 1 + 1 file changed, 1 insertion(+) create mode 120000 _codeql_detected_source_root diff --git a/_codeql_detected_source_root b/_codeql_detected_source_root new file mode 120000 index 0000000..945c9b4 --- /dev/null +++ b/_codeql_detected_source_root @@ -0,0 +1 @@ +. \ No newline at end of file