Failing with error:nil calls success callback rather than error callback

[Voxar]

Example below calls the completion callback but not the error callback. Is this by design?

[[[SPTask failedTask:nil] addCallback:^(id value) {
    NSLog(@"Called");
}] addErrorCallback:^(NSError *error) {
    NSLog(@"Not called");
}];

[nevyn]

Err it does‽ That certainly sounds like a really bad bug! Did you figure out why..?

[dflems]

Not sure if anyone cares about this 1.5 year old issue anymore... but it's because failWithError: is expecting a non-nil value. In addCallback: the callback fires right away if the task is completed, and doesn't have an error set. Since error was nil it thinks you've completed without an error and it fires the callback.

It's technically against the API contract to provide a nil value as an error, but a quick fix would be to create a generic error object in the event that failWithError:nil is called. If you do that, the error callback will fire as-expected.

@nevyn: I'm not sure how much you use this library nowadays. We've made a lot of changes and cleanups on our internal fork and could kick those back upstream if you'd like.

[nevyn]

@dflems I use it in production every day, still! I just suck at github notifications. I would love to incorporate your changes!

Do you like the library in general? :D

[nevyn]

@dflems I'm still interested in those downstream changes, if you're willing :) I'm still using SPTask daily!