Sending from disabled user is possible

[oleua]

Testing the CLI command I've discovered that I can publish announcements on behalf of a disabled user and the announcements appear in the thread.

In my opinion this is not fine.

[nickvergessen]

Then again from CLI, the admin could also do:

occ user:enable foobar
occ announcement:announce
occ user:disable foobar

So while it does not make a lot of sense, preventing it just adds complexity

[oleua]

Then again from CLI, the admin could also do:

occ user:enable foobar
occ announcement:announce
occ user:disable foobar
So while it does not make a lot of sense, preventing it just adds complexity

You haven't got. I CAN send announces from already disabled users. That is wrong, imho.

[nickvergessen]

I understood that, but changing/preventing that does not help with anything as admins have a workaround to still post as such a user

[oleua]

I understood that, but changing/preventing that does not help with anything as admins have a workaround to still post as such a user

I think that the script should check the status of a user, if it is disabled to not allow do any action. This will prevent from unintended actions independently whether a user is an admin