Unable to share with create permissions in shared folder which is in a group folder

[KoltesDigital]

Describe the task

Hi. We apparently found a bug.

Reproduction:

1. Create users Alice and Bob. You act as Alice. She's admin.
2. Create a user group UG and add Bob to that group. Alice is not in that group.
3. Create a group folder GF. Give it permissions Write for user group UG and all permissions (Write, Share, Delete) for admin group.
4. Create a folder ToDo inside GF.
5. Share folder ToDo with user group UG.
6. Impersonate Bob.
7. Open folder ToDo.
8. Notice that you cannot create any file. The + New button is greyed. Tooltip says you don't have permission to upload or create files here.

It would work if folder ToDo were created in a user space and shared from there.

The bug may also appear when sharing directly to Bob, but I haven't tried that case.

When sharing the folder, I take for granted that Create permission is given, because in Admin settings > Sharing > Default permissions, everything is checked. When I choose Custom permissions, everything is checked, and when I save that and later refresh the browser, the share is shown again as "Can read".

Can you reproduce the bug? Thanks :)

NC version is Nextcloud Hub 9 (30.0.14).

Affected components

No response

To do

• Fix

[provokateurin]

4. Create a folder ToDo inside GF.
5. Share folder ToDo with user group UG.

You are doing these steps as Alice? How did you add Alice to the GF and gave permissions?

[KoltesDigital]

As Alice. She's admin and does not belong to the user group.

Regarding permissions, I've tested with "Allow editing" and "Custom permissions" with all five perms checked, but in the latter case, after F5 it is shown as "Allow editing". I took for granted that they are equivalent. In Admin > Sharing > Default share permissions, all four perms are checked. But if it's not equivalent, that would explain why Bob can't create inside the shared folder, but then the root cause becomes custom permissions are not saved properly.

[provokateurin]

How did you add Alice to the GF and gave permissions?

What about this? I mean the permissions you gave Alice over the GF and not the share.

[KoltesDigital]

Ah, ok understood. GF has permissions Write for UG, and all three perms (Write, Share, Delete) for Admin group in which is Alice. No advanced permissions.

Well, if Write does not imply Create, then my bug is "by design"... and becomes a feature request :)

[provokateurin]

For advanced permissions there are separate write and create permissions, but for team folder level permissions write always implies create:

groupfolders/src/settings/FolderGroups.tsx

Lines 57 to 58 in 88d126d

	onChange={setPermissions.bind(null, OC.PERMISSION_UPDATE | OC.PERMISSION_CREATE, groupId)}
	checked={hasPermissions(permissions, (OC.PERMISSION_UPDATE | OC.PERMISSION_CREATE))}/>