Skip to content

"This email might be a phishing attempt" - not always correct #11165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckruetze opened this issue May 16, 2025 · 4 comments
Open

"This email might be a phishing attempt" - not always correct #11165

ckruetze opened this issue May 16, 2025 · 4 comments
Assignees

Comments

@ckruetze
Copy link

Steps to reproduce

  1. Get an external mail that has a link with the following format in it:
    href: http://www.example-domain.de/ link text: example-domain.de

Expected behavior

This should not trigger a warning at all. the http:// part should be ignored and also a www. should be ignored as it is very common to have that.
Additionally in the above example the e-mails are coming in from someuser@example-domain.de The external user is in the internal contacts list and is a frequent person used for e-mails both incoming and outgoing There should be additional checks that if the domain is used frequently or even in contacts links should not be marked as potential spam as that confuses the users.

Actual behavior

We get the warning "This email might be a phishing attempt "

Mail app version

?

Nextcloud version

31.0.1 RC2

Mailserver or service

?

Operating system

Linux

PHP engine version

None

Nextcloud memory caching

No response

Web server

None

Database

None

Additional info

none

@kesselb
Copy link
Contributor

kesselb commented May 16, 2025

Thanks for reaching out 👍

This should not trigger a warning at all. the http:// part should be ignored and also a www. should be ignored as it is very common to have that.

We remove the protocol part, but "www" affects the meaning. I'll check if we can ignore "www" by default. Remember, spammers use this too.

additional checks that if the domain is used frequently or even in contacts links should not be marked as potential spam as that confuses the users.

We have trusted senders and internal addresses. Did you add the sender as trusted sender?

@kesselb kesselb self-assigned this May 16, 2025
@ckruetze
Copy link
Author

OK, this might be a really silly question, but how would I add a sender to be a trusted sender? And how do I check if a sender is a trusted sender?

@ckruetze
Copy link
Author

We remove the protocol part, but "www" affects the meaning. I'll check if we can ignore "www" by default. Remember, spammers use this too.

How would a spammer do that? I can understand it if it is one of those domains that allowes third parties to add subdomains like IamNotaSpammer.somedomain.com but www ? If you give a third party access to your www domain something else is wrong.

@kesselb
Copy link
Contributor

kesselb commented May 16, 2025

Sorry, that was unclear. A phishing warning is triggered when the link and link text differ. Spammers use this technique to deceive people. I think it's fine to drop "www" by default, but senders should improve their emails to avoid using the same odd semantics as spammers.

Trusted Senders: In Nextcloud Mail, HTML emails with images are not loaded by default. You can add recipients or domains to always load images, which is called "trusted senders."

I'll log a feature request to include trusted senders and internal addresses in the phishing detection. I'll also keep this report open to tweak the link-text comparison a bit.

Thanks again for bringing it to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants