U2F "Adding device" hang

[robballan]

Steps to reproduce

1. add a device
2. hang with "adding device"

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

Server configuration

Operating system:
FreeBSD 12.2

Web server:
apache 24

Database:
mysql

PHP version:
8.0

Version: (see admin page)
21.0.2

Updated from an older version or fresh install:
fresh

List of activated apps:

Enabled:

• accessibility: 1.7.0
• activity: 2.14.3
• bruteforcesettings: 2.1.0
• cloud_federation_api: 1.4.0
• comments: 1.11.0
• contactsinteraction: 1.2.0
• dashboard: 7.1.0
• dav: 1.17.1
• federatedfilesharing: 1.11.0
• federation: 1.11.0
• files: 1.16.0
• files_pdfviewer: 2.1.0
• files_rightclick: 1.0.0
• files_sharing: 1.13.1
• files_trashbin: 1.11.0
• files_versions: 1.14.0
• files_videoplayer: 1.10.0
• firstrunwizard: 2.10.0
• logreader: 2.6.0
• lookup_server_connector: 1.9.0
• nextcloud_announcements: 1.10.0
• notifications: 2.9.0
• oauth2: 1.9.0
• password_policy: 1.11.0
• photos: 1.3.0
• privacy: 1.5.0
• provisioning_api: 1.11.0
• recommendations: 1.0.0
• serverinfo: 1.11.0
• settings: 1.3.0
• sharebymail: 1.11.0
• support: 1.4.0
• survey_client: 1.9.0
• systemtags: 1.11.0
• text: 3.2.0
• theming: 1.12.0
• twofactor_backupcodes: 1.10.0
• twofactor_u2f: 6.1.0
• updatenotification: 1.11.0
• user_status: 1.1.1
• viewer: 1.5.0
• weather_status: 1.1.0
• workflowengine: 2.3.0
  Disabled:
• admin_audit
• encryption
• files_external
• user_ldap
  The content of config/config.php:

{
"system": {
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"localhost",
"binary.biltmore",
"192.168.150.170",
"ashbury.helical.com"
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "21.0.2.1",
"overwrite.cli.url": "http://localhost",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbport": "",
"dbtableprefix": "oc_",
"mysql.utf8mb4": true,
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"installed": true,
"overwriteprotocol": "https",
"simpleSignUpLink.shown": false,
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_smtpmode": "sendmail",
"mail_sendmailmode": "smtp",
"mail_domain": "REMOVED SENSITIVE VALUE",
"mail_smtpauthtype": "LOGIN",
"mail_smtphost": "REMOVED SENSITIVE VALUE",
"mail_smtpauth": 1,
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE",
"mail_smtpsecure": "ssl",
"mail_smtpport": "587",
"twofactor_enforced": "false",
"twofactor_enforced_groups": [],
"twofactor_enforced_excluded_groups": []
},
"apps": {
"accessibility": {
"enabled": "yes",
"installed_version": "1.7.0",
"types": ""
},
"activity": {
"enabled": "yes",
"installed_version": "2.14.3",
"types": "filesystem"
},
"backgroundjob": {
"lastjob": "154"
},
"bruteforcesettings": {
"enabled": "yes",
"installed_version": "2.1.0",
"types": ""
},
"cloud_federation_api": {
"enabled": "yes",
"installed_version": "1.4.0",
"types": "filesystem"
},
"comments": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "logging"
},
"contactsinteraction": {
"enabled": "yes",
"installed_version": "1.2.0",
"types": "dav"
},
"core": {
"installed.bundles": "["CoreBundle"]",
"installedat": "1623070318.2491",
"lastcron": "1623537832",
"lastupdateResult": "[]",
"lastupdatedat": "1623537681",
"public_files": "files_sharing/public.php",
"public_webdav": "dav/appinfo/v1/publicwebdav.php",
"theming.variables": "32ef7dc01a3ffbcbbaf8fb9483f9bd03",
"vendor": "nextcloud"
},
"dashboard": {
"enabled": "yes",
"installed_version": "7.1.0",
"types": ""
},
"dav": {
"enabled": "yes",
"installed_version": "1.17.1",
"types": "filesystem"
},
"federatedfilesharing": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": ""
},
"federation": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "authentication"
},
"files": {
"enabled": "yes",
"installed_version": "1.16.0",
"types": "filesystem"
},
"files_pdfviewer": {
"enabled": "yes",
"installed_version": "2.1.0",
"types": ""
},
"files_rightclick": {
"enabled": "yes",
"installed_version": "1.0.0",
"types": ""
},
"files_sharing": {
"enabled": "yes",
"installed_version": "1.13.1",
"types": "filesystem"
},
"files_trashbin": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "filesystem,dav"
},
"files_versions": {
"enabled": "yes",
"installed_version": "1.14.0",
"types": "filesystem,dav"
},
"files_videoplayer": {
"enabled": "yes",
"installed_version": "1.10.0",
"types": ""
},
"firstrunwizard": {
"enabled": "yes",
"installed_version": "2.10.0",
"types": "logging"
},
"logreader": {
"enabled": "yes",
"installed_version": "2.6.0",
"types": ""
},
"lookup_server_connector": {
"enabled": "yes",
"installed_version": "1.9.0",
"types": "authentication"
},
"nextcloud_announcements": {
"enabled": "yes",
"installed_version": "1.10.0",
"pub_date": "Thu, 24 Oct 2019 00:00:00 +0200",
"types": "logging"
},
"notifications": {
"enabled": "yes",
"installed_version": "2.9.0",
"types": "logging"
},
"oauth2": {
"enabled": "yes",
"installed_version": "1.9.0",
"types": "authentication"
},
"password_policy": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "authentication"
},
"photos": {
"enabled": "yes",
"installed_version": "1.3.0",
"types": ""
},
"privacy": {
"enabled": "yes",
"installed_version": "1.5.0",
"readableLocation": "us",
"types": ""
},
"provisioning_api": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "prevent_group_restriction"
},
"recommendations": {
"enabled": "yes",
"installed_version": "1.0.0",
"types": ""
},
"serverinfo": {
"cached_count_filecache": "76211",
"cached_count_storages": "3",
"enabled": "yes",
"installed_version": "1.11.0",
"types": ""
},
"settings": {
"enabled": "yes",
"installed_version": "1.3.0",
"types": ""
},
"sharebymail": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "filesystem"
},
"support": {
"enabled": "yes",
"installed_version": "1.4.0",
"types": "session"
},
"survey_client": {
"enabled": "yes",
"installed_version": "1.9.0",
"types": ""
},
"systemtags": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "logging"
},
"text": {
"enabled": "yes",
"installed_version": "3.2.0",
"types": "dav"
},
"theming": {
"enabled": "yes",
"installed_version": "1.12.0",
"types": "logging"
},
"twofactor_backupcodes": {
"enabled": "yes",
"installed_version": "1.10.0",
"types": ""
},
"twofactor_u2f": {
"enabled": "yes",
"installed_version": "6.1.0",
"types": ""
},
"twofactor_webauthn": {
"enabled": "no",
"installed_version": "0.2.10",
"types": ""
},
"updatenotification": {
"enabled": "yes",
"installed_version": "1.11.0",
"types": "",
"update_check_errors": "0"
},
"user_status": {
"enabled": "yes",
"installed_version": "1.1.1",
"types": ""
},
"viewer": {
"enabled": "yes",
"installed_version": "1.5.0",
"types": ""
},
"weather_status": {
"enabled": "yes",
"installed_version": "1.1.0",
"types": ""
},
"workflowengine": {
"enabled": "yes",
"installed_version": "2.3.0",
"types": "filesystem"
}
}
}

Client configuration

Browser:
Safari

Operating system:
Mac OS X 11.4

Logs

Web server error log

Insert your webserver log here

Server log (data/nextcloud.log)

{"reqId":"PEjCnGCv7lS7XvRlu1Sf","level":3,"time":"2021-06-12T22:51:00+00:00","remoteAddr":"192.168.150.10","user":"robb","app":"index","method":"POST","url":"/nextcloud/index.php/apps/twofactor_u2f/settings/finishregister","message":{"Exception":"Exception","Message":"OCA\TwoFactorU2F\Controller\SettingsController::finishRegister(): Argument #1 ($registrationData) must be of type string, null given, called in /usr/local/www/apache24/data/nextcloud/lib/private/AppFramework/Http/Dispatcher.php on line 218","Code":0,"Trace":[{"file":"/usr/local/www/apache24/data/nextcloud/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\AppFramework\Http\Dispatcher","type":"->"},{"file":"/usr/local/www/apache24/data/nextcloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\AppFramework\App","type":"::"},{"file":"/usr/local/www/apache24/data/nextcloud/lib/base.php","line":993,"function":"match","class":"OC\Route\Router","type":"->"},{"file":"/usr/local/www/apache24/data/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::"}],"File":"/usr/local/www/apache24/data/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","Line":159,"Previous":{"Exception":"TypeError","Message":"OCA\TwoFactorU2F\Controller\SettingsController::finishRegister(): Argument #1 ($registrationData) must be of type string, null given, called in /usr/local/www/apache24/data/nextcloud/lib/private/AppFramework/Http/Dispatcher.php on line 218","Code":0,"Trace":[{"file":"/usr/local/www/apache24/data/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":218,"function":"finishRegister","class":"OCA\TwoFactorU2F\Controller\SettingsController","type":"->"},{"file":"/usr/local/www/apache24/data/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":127,"function":"executeController","class":"OC\AppFramework\Http\Dispatcher","type":"->"},{"file":"/usr/local/www/apache24/data/nextcloud/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\AppFramework\Http\Dispatcher","type":"->"},{"file":"/usr/local/www/apache24/data/nextcloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\AppFramework\App","type":"::"},{"file":"/usr/local/www/apache24/data/nextcloud/lib/base.php","line":993,"function":"match","class":"OC\Route\Router","type":"->"},{"file":"/usr/local/www/apache24/data/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::"}],"File":"/usr/local/www/apache24/data/nextcloud/apps/twofactor_u2f/lib/Controller/SettingsController.php","Line":65},"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.1 Safari/605.1.15","version":"21.0.2.1"}

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log

Here's the Nextcloud log entry:

"Exception: OCA\TwoFactorU2F\Controller\SettingsController::finishRegister(): Argument #1 ($registrationData) must be of type string, null given"

[ChristophWurst]

See #690

[TheOneWithTheBraid]

In my case (unsure whether exactly related), this happened when I tried to add the same U2F device several times. In infinitely hanged without an error message.

[jakubgs]

I'm seeing the same issue, endless spinning and the error:

OCA\TwoFactorU2F\Controller\SettingsController::finishRegister():
Argument #1 ($registrationData) must be of type string, null given,
called in /var/www/html/lib/private/AppFramework/Http/Dispatcher.php
on line 217 in file /var/www/html/custom_apps/twofactor_u2f/lib/Controller/SettingsController.php line 65

And I already have overwriteprotocol: https set, so that's not it.

 > php occ config:list | jq .system.overwriteprotocol
"https"

[jakubgs]

I can see the request to /index.php/apps/twofactor_u2f/settings/finishregister being made:

And the payload is there:

[jakubgs]

We can see saveRegistrationData is called from the AddDeviceDialog:

twofactor_u2f/src/components/AddDeviceDialog.vue

Lines 178 to 191 in 5fe47c0

	saveRegistrationData () {
	const data = this.registrationData
	data.name = this.name
	logger.debug('saving registration data', {data})
	return finishRegistration(data)
	.then(device => this.$store.commit('addDevice', device))
	.then(logAndPass('new device added to store'))
	.catch(err => {
	logger.error('Error persisting registration', err)
	throw new Error(t('twofactor_u2f', 'Server error while trying to complete U2F device registration'))
	})
	},

Which created a data object with the name attribute set to what the user provides, which then is sent via:

twofactor_u2f/src/services/RegistrationService.js

Lines 32 to 37 in 7edb7f7

	export function finishRegistration (data) {
	const url = generateUrl('/apps/twofactor_u2f/settings/finishregister')
	return Axios.post(url, data)
	.then(resp => resp.data)
	}

To the /apps/twofactor_u2f/settings/finishregister endpoint. Which we can see happened above, as expected.

So the issue probably isn't on the frontend, meaning Vue/JS side.

[jakubgs]

This is the full error btw: https://gist.github.com/jakubgs/951909e3253baf46cc54e5a9521b255d

[jakubgs]

These three issues seem related:

• Exception: Argument 1 passed to OC\Core\Controller\LoginController::tryLogin() must be of the type string, null given server#23063
• Logout and no function of the app tokens if 2FA is not completely executed server#29371
• Unable to use webauthn to log in (since Nextcloud 23?) server#30549

They all include the must be of type string, null given error caused somewhere in the stack trace by lib/private/AppFramework/Http/Dispatcher.php, which seems to indicate the payload is lost somewhere along the way..

[aikitori]

I can't add a new WebAuthn device. Is this related or should i open a new issue?

Browser Log (Firefox):

starting webauthn registration AddDevice.vue:158
[DEBUG] settings: confirmed password 
Object { app: "settings", uid: "user" }
ConsoleLogger.js:29:16
XHRPOSThttps://cloud.example.com/settings/api/personal/webauthn/registration
[HTTP/2 500 Internal Server Error 141ms]

[ERROR] settings: Error persisting webauthn registration 
Object { app: "settings", uid: "user", error: Error }
ConsoleLogger.js:41:16
Error: Server-Fehler beim Versuch die WebAuthn-Geräte-Registrierung abzuschließen
    e AddDevice.vue:195
    u runtime.js:63
    _invoke runtime.js:294
    v runtime.js:119
    x vue-settings-personal-webauthn.js:223
    s vue-settings-personal-webauthn.js:223
    promise callback*x vue-settings-personal-webauthn.js:223
    a vue-settings-personal-webauthn.js:223
    saveRegistrationData vue-settings-personal-webauthn.js:223
    saveRegistrationData vue-settings-personal-webauthn.js:223
    saveRegistrationData vue-settings-personal-webauthn.js:223
    promise callback*submit AddDevice.vue:179
    VueJS 28
    start AddDevice.vue:116
    promise callback*start AddDevice.vue:116
    VueJS 2
AddDevice.vue:183

[jakubgs]

I've added dome debugging prints to the code to check the values, and when the payload for POST request is:

The $arguments variable looks like this right before call to call_user_func_array():

[NULL, NULL, "yubikey"]

Where yubikey is the $name passed to finishRegister():

	public function finishRegister(string $registrationData, string $clientData, string $name = null): JSONResponse {
		return new JSONResponse($this->manager->finishRegistration($this->userSession->getUser(), $registrationData, $clientData, $name));
	}

So we're clearly missing $registrationData and $clientData.

[jakubgs]

When I put a debug line here:

			$this->logger->info("WTF param: $param -> '$value' ($type)");

I can see that the arguments are all of type string but the first two are empty strings:

WTF param: registrationData -> '' (string)
WTF param: clientData -> '' (string)
WTF param: name -> 'yubikey' (string)

But then the first two empty strings somehow get turned into NULLs.

[jakubgs]

Specifically, I printed contents of $arguments before and after this line:
https://github.com/nextcloud/server/blob/v23.0.3/lib/private/AppFramework/Http/Dispatcher.php#L214

And it appears that the empty string in $value turns into NULL the moment this assignment in the loop takes place:

			$arguments[] = $value;

Which as far as I can tell should not be happening:
https://user-images.githubusercontent.com/2212681/159962326-04aa86cd-79ba-4c5d-9864-c1f621f4dedd.png

But I lack the context to know if these should even be empty strings in the first place.

[jakubgs]

@ChristophWurst sorry for pinging you directly but I'd appreciate some insight here.

What are the expected values for $registrationData and $clientData? I assume it's not NULL, but is empty string valid?
My guess would be that no, but I lack the context to know what should be in those variables.

Are those variables supposed to be present in the JSON that is POSTed to the finishregister endpint?
If so then the issue must be on the client side since those are not visible when looking up the request in browser dev console.