Skip to content

Nextflow strict syntax#264

Merged
d4straub merged 18 commits intonf-core:devfrom
d4straub:nextflow-strict-syntax-25.10.3
Jan 28, 2026
Merged

Nextflow strict syntax#264
d4straub merged 18 commits intonf-core:devfrom
d4straub:nextflow-strict-syntax-25.10.3

Conversation

@d4straub
Copy link
Collaborator

@d4straub d4straub commented Jan 23, 2026

Prepare for Nextflow strict syntax:

  • fixed all syntax errors
  • fixed all syntax warnings in non-nf-core files (some warnings remain in nf-core suworkflows & modules)
  • updated several nf-core modules & workflows to avoid errors and minimize warnings

Fixed that was before broken:

NXF_VER=25.10.3 nextflow lint . -exclude ".git,.nf-test,nf-test.config"
NXF_VER=25.12.0-edge NXF_SYNTAX_PARSER=v2 nextflow run . --help

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@d4straub
Copy link
Collaborator Author

Short intermediate evaluation of CI tests

  • 1, 2, 3: assembly files and multiqc files differ in md5 sums
  • 4: multiqc file and fastp json md5sum changed
  • 7: additional QUAST files, assembly & multiqc file md5 sums changed
  • 8: kraken2 tool version mismatch
  • 5,6,9: passing

@d4straub
Copy link
Collaborator Author

@nf-core-bot fix linting

@d4straub d4straub marked this pull request as ready for review January 26, 2026 10:12
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion but otherwise LGTM 🚀

@d4straub d4straub requested a review from JoseEspinosa January 28, 2026 08:14
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🚀

@d4straub
Copy link
Collaborator Author

Thanks for the review!

@d4straub d4straub merged commit 691dd6d into nf-core:dev Jan 28, 2026
25 checks passed
@d4straub d4straub deleted the nextflow-strict-syntax-25.10.3 branch January 28, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants