Merge improvements (pitch bend, <s>`parseSong()`</s> song parsing, ...) from my private repo

[page200]

There are various improvements in a copy of MIDIFile.js in https://github.com/surikov/webaudiofont/blame/master/examples/MIDIFile.js such as support for pitch bends (slides).

It might be good to merge those improvements into this repo, and replace MIDIFile.js in that repo by a link to this repo, as discussed at #33 (comment)

Edit 2025-03-01: Don't merge the current version of webaudiofont. Merge my private version, see #34 (comment) below.

[mk-pmb]

Unfortunately they seem to use a stricter license (GNU GPL v3) than we do (MIT), so we cannot take code from their repo. We'd have to track down the relevant patch author(s) and request explicit permission from them.

Most of the code lines that have the word "slide" seem to come from this commit by user @surikov but I cannot find a PR for that. Also the commit title "test" looks like the patch might not be a single feature, so we'd need to figure out whether we need other patches as well to support slides.

If your patch from surikov/webaudiofont#95 works without slides, feel free to submit it as PR here under MIT license. (Assuming you do have all required copyrights, of course.)

[page200]

@surikov's patches introduce pitch bend etc., and my patch surikov/webaudiofont#95 adds support for MIDI files with custom pitch-bend range, so that the pitch bend is correct for them.

What form of permission is needed, as comments on GitHub? You have my permission, and I think @surikov also suggests here that @nfroidure's repos should be modified accordingly (and that @surikov's patches to MIDIFile.js aren't the focus of his repo anyway, but are merely a small example).

[mk-pmb]

What form of permission is needed, as comments on GitHub?

Obligatory disclaimer: I'm not a lawyer, and the following is just how I as a layman understand (US) copyright and (European) authorship protection.

We need an MIT license grant. A comment stating the grant would work in theory, but we'd have to keep that around somehow. The easier way is to submit a PR for a branch that is

• based on our master branch and
• whose new commits do not modify any license or authorship statements in existing files.
  • (and do not introduce any new terms that contradict the current license.)

The 2nd condition acts as implied license grant under the existing license. It's only effective if you're legally capable of granting the license, but this is most usually the case for your own creations.

[mk-pmb]

I checked surikov/webaudiofont#95 and it looks like the patch there isn't directly compatible, even if I adjust the file paths. For example, it tries to modify a function addSlide but that code seems to not exist on our master branch. My quick attempt to trace where addSlide comes from, failed. I might try again later.

Edit: If with

surikov's patches introduce pitch bend etc.,

you mean he is the author of the patches for those features, we'd have to ask him to please PR his changes into our repo. However, they may require even more patches from other authors, can't currently check that.

[page200]

My patch fixes the pitch-bend range. @nfroidure's repos don't have pitch bend yet (as far as I know / in the form we're discussing). @surikov's repo does.

Here's the blame history for addSlide: https://github.com/surikov/webaudiofont/blame/8d3bbebcb1b3fa5642b931bf1eff9e7740795c51/examples/MIDIFile.js#L1009-L1025

The contributors (@surikov and me) are listed on the left side of the code and on the top right.

The code was added in subsequent commits after "forking" the original MIDIFile.js.

[mk-pmb]

Thanks! So it seems the other code all comes from the "test" commit. Back then, the repo seems to have been under MIT license still, so we might be in luck. I've started negotiations.

Once we have proper permissions on that code, we'll have to figure out stuff like what this magic number means:

if (track.notes[i].duration == 0.0000001

and what conparison operator to use instead, probably <= or ===.

Edit: Also there is a suspicious change from binary | to boolean || near the /127 division.

[mk-pmb]

The issue where I asked how to credit him was closed without comment, so I guess he doesn't care. My approach would be to use the "From:" header of the "test" commit as a patch file as the author attribution. Would you other maintainers agree?

[page200]

Yes, that sounds like an appropriate author attribution. And feel free to attribute me for the pitch-bend range functionality, if that makes things easier. I welcome a license that benefits the project and its widespread use. Thanks!

[mk-pmb]

And feel free to attribute me for the pitch-bend range functionality,

Are you refering to parts of the "test" commit? Are you the real author of part of that? If so, can you PR those parts first?

Edit: I see now that you probably meant the git-blame you linked above:

Here's the blame history for addSlide: […]

I'll take that into account.

[page200]

I meant surikov/webaudiofont#95.

I'll take that into account.

Whatever benefits a widespread use of the project.

Thanks!

[samuelbradshaw]

Hi! I'm also interested in seeing these changes merged in. @mk-pmb, were you planning to open a pull request?

It looks like surikov/webaudiofont switched to GPL on January 16, 2020. Previous to that, it was under an MIT license.

[page200]

I have considerably improved that code in a private codebase. One of the improvements is that it now works also when the several messages for setting the pitch-bend range are interspersed with unrelated messages, which is allowed by the MIDI specification and is the case in some MIDI files. That actually made the code simpler and more consistent with the original midifile code. There are also other improvements.

I can try to clean up the code (remove experimental features) earlier than I had planned if someone wants it (and is willing to then help merge it?).

That seems better than spending time on merging the old version. Not only because the old version is superseded, but also because removing that old code will be tedious. I'm renaming the issue accordingly.

[samuelbradshaw]

That's great to hear! I found a solution for my immediate need, so no rush.