-
Notifications
You must be signed in to change notification settings - Fork 373
Add uri to log when 'error getting stats' occured for nginx #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @AlexKorsakov! Welcome to the project! 🎉 Thanks for opening this pull request! |
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
ciarams87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once the lint issue is resolved, thanks!
Finished. Check again, please, @ciarams87 . |
Add uri to error message which occurs when exporter couldn't get success status code from one of the addresses for scrape.
GetApiEndpoint()created because apiEndpoint is unexported.urito logerrobject instead oferr.Error()to save stacktrace. Or is there any cause not to change it?nginx_plus.goyet, cause it requires to changeplusclientbut I don't have any license to run and test it after changes. I can make it without testing, only run lint and build.