Added chrome required settings for WebTransport

[WindowsNT]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @WindowsNT, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the necessary settings to enable WebTransport support within the nghttp3 library. It defines new configuration parameters for WebTransport and WebTransport Datagrams, implements the mechanisms to both send and receive these settings during the HTTP/3 handshake, and updates the build ignore list. The overall impact is to lay the groundwork for integrating WebTransport capabilities, allowing applications to negotiate and utilize this protocol over HTTP/3.

Highlights

• WebTransport Settings Definition: New uint64_t fields, enable_web_transport and enable_webtransport_datagrams, have been added to the nghttp3_settings structure in lib/includes/nghttp3/nghttp3.h to support WebTransport functionality.
• WebTransport Setting IDs: Unique identifiers, NGHTTP3_SETTINGS_ENABLE_WEBTRANSPORT and NGHTTP3_SETTINGS_ENABLE_WEBTRANSPORT_DATAGRAM, have been defined in lib/nghttp3_frame.h for the new WebTransport settings.
• Incoming WebTransport Settings Handling: The nghttp3_conn_on_settings_entry_received function in lib/nghttp3_conn.c has been updated to correctly parse and store incoming WebTransport settings.
• Outgoing WebTransport Settings Transmission: Logic has been added to nghttp3_stream_write_settings in lib/nghttp3_stream.c to include the new WebTransport settings in outgoing settings frames when they are enabled.
• Git Ignore Updates: The .gitignore file has been updated to exclude out64/, out32/, and inst.bat, likely to prevent build artifacts and temporary files from being committed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for WebTransport settings as required by Chrome. The changes are generally good, but I have a few suggestions to improve correctness, consistency, and maintainability.

1. In nghttp3.h, the new boolean flags should use uint8_t for consistency with other flags in the nghttp3_settings struct.
2. In nghttp3_conn.c, validation is missing for the new WebTransport settings. The specification requires the value to be 1, and any other value should result in a connection error.
3. In nghttp3_stream.c, there's some code duplication and inconsistent indentation when adding the new settings, which could be improved for better maintainability and readability.

I've provided specific code suggestions for these points.