From f6dfc4f2040385496ba7fc81a54add21487cf117 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 25 Sep 2025 04:44:32 +0000 Subject: [PATCH 1/3] Update Oracle.ManagedDataAccess to v23 --- src/NHibernate.Test/NHibernate.Test.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/NHibernate.Test/NHibernate.Test.csproj b/src/NHibernate.Test/NHibernate.Test.csproj index 847687acb9..ab4ca913e8 100644 --- a/src/NHibernate.Test/NHibernate.Test.csproj +++ b/src/NHibernate.Test/NHibernate.Test.csproj @@ -77,7 +77,7 @@ - + @@ -86,7 +86,7 @@ compile - + From 5cdb916efe244c9568cb16764194d6844bf47fca Mon Sep 17 00:00:00 2001 From: Alex Zaytsev Date: Thu, 25 Sep 2025 15:00:33 +1000 Subject: [PATCH 2/3] Fix current timestamp function --- src/NHibernate/Dialect/Oracle9iDialect.cs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/NHibernate/Dialect/Oracle9iDialect.cs b/src/NHibernate/Dialect/Oracle9iDialect.cs index b36b1a34b3..347fa0f9ad 100644 --- a/src/NHibernate/Dialect/Oracle9iDialect.cs +++ b/src/NHibernate/Dialect/Oracle9iDialect.cs @@ -7,10 +7,8 @@ namespace NHibernate.Dialect { public class Oracle9iDialect : Oracle8iDialect { - public override string CurrentTimestampSelectString - { - get { return "select systimestamp from dual"; } - } + public override string CurrentTimestampSelectString => + $"select {CurrentTimestampSQLFunctionName} from dual"; public override string CurrentTimestampSQLFunctionName { From acf06dd222468b7228bcd6464638fb30b0deaea9 Mon Sep 17 00:00:00 2001 From: Alex Zaytsev Date: Thu, 25 Sep 2025 16:12:03 +1000 Subject: [PATCH 3/3] Fix --- src/NHibernate/Dialect/Oracle9iDialect.cs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/NHibernate/Dialect/Oracle9iDialect.cs b/src/NHibernate/Dialect/Oracle9iDialect.cs index 347fa0f9ad..8611c20477 100644 --- a/src/NHibernate/Dialect/Oracle9iDialect.cs +++ b/src/NHibernate/Dialect/Oracle9iDialect.cs @@ -10,14 +10,7 @@ public class Oracle9iDialect : Oracle8iDialect public override string CurrentTimestampSelectString => $"select {CurrentTimestampSQLFunctionName} from dual"; - public override string CurrentTimestampSQLFunctionName - { - get - { - // the standard SQL function name is current_timestamp... - return "current_timestamp"; - } - } + public override string CurrentTimestampSQLFunctionName => "localtimestamp"; // Current_timestamp is a timestamp with time zone, so it can always be converted back to UTC. /// @@ -44,6 +37,9 @@ protected override void RegisterFunctions() { base.RegisterFunctions(); + RegisterFunction( + "current_timestamp", + new NoArgSQLFunction("localtimestamp", NHibernateUtil.LocalDateTime, false)); RegisterFunction( "current_utctimestamp", new SQLFunctionTemplate(NHibernateUtil.UtcDateTime, "SYS_EXTRACT_UTC(current_timestamp)"));