From 9746dc51b5acd9d64c14c02007c9b1605553c3b0 Mon Sep 17 00:00:00 2001 From: rajsite <1588923+rajsite@users.noreply.github.com> Date: Fri, 5 Dec 2025 18:07:56 -0600 Subject: [PATCH 1/2] Remove prettier inline disables and update docs --- .vscode/extensions.json | 1 - .vscode/settings.json | 2 +- CONTRIBUTING.md | 2 +- packages/eslint-config-nimble/components.js | 4 ++-- packages/nimble-components/CONTRIBUTING.md | 2 -- .../src/anchor-tree-item/tests/anchor-tree-item.spec.ts | 1 - packages/nimble-components/src/banner/specs/README.md | 1 - packages/nimble-components/src/chip/template.ts | 1 - .../nimble-components/src/combobox/tests/combobox.spec.ts | 4 ---- .../src/mapping/icon/tests/mapping-icon.spec.ts | 1 - packages/nimble-components/src/patterns/dropdown/styles.ts | 1 - .../users/tests/rich-text-mention-users.spec.ts | 1 - .../editor/tests/rich-text-editor-mention.spec.ts | 1 - .../src/rich-text/editor/tests/rich-text-editor.spec.ts | 1 - .../mention-listbox/tests/mention-listbox.spec.ts | 1 - .../src/rich-text/models/tests/markdown-parser.spec.ts | 1 - .../src/rich-text/viewer/tests/rich-text-viewer.spec.ts | 1 - packages/nimble-components/src/select/tests/select.spec.ts | 2 -- .../table-column/anchor/tests/table-column-anchor.spec.ts | 1 - .../date-text/tests/table-column-date-text.spec.ts | 2 -- .../duration-text/tests/table-column-duration-text.spec.ts | 1 - .../mapping/tests/table-column-mapping.spec.ts | 2 -- .../src/table-column/menu-button/cell-view/templates.ts | 1 - .../menu-button/tests/table-column-menu-button.spec.ts | 1 - .../src/table-column/mixins/custom-sort-order.ts | 1 - .../src/table-column/mixins/fractional-width-column.ts | 1 - .../src/table-column/mixins/groupable-column.ts | 1 - .../src/table-column/mixins/placeholder.ts | 1 - .../src/table-column/mixins/sortable-column.ts | 1 - .../number-text/tests/table-column-number-text.spec.ts | 1 - .../src/table-column/text/tests/table-column-text.spec.ts | 1 - .../src/table/components/cell/tests/table-cell.spec.ts | 1 - .../components/group-row/tests/table-group-row.spec.ts | 1 - .../src/table/components/row/tests/table-row.spec.ts | 2 -- .../src/table/models/tests/table-validator.spec.ts | 4 ---- .../src/table/tests/table-action-menu.spec.ts | 1 - .../src/table/tests/table-column-sizing.spec.ts | 2 -- .../src/table/tests/table-delegated-events.spec.ts | 1 - .../src/table/tests/table-grouping.spec.ts | 2 -- .../src/table/tests/table-keyboard-navigation.spec.ts | 5 ----- .../nimble-components/src/table/tests/table-labels.spec.ts | 1 - .../src/table/tests/table-pageobject.spec.ts | 1 - .../src/table/tests/table-selection.spec.ts | 1 - .../src/table/tests/table-sorting.spec.ts | 1 - packages/nimble-components/src/table/tests/table.spec.ts | 2 -- packages/nimble-components/src/text-field/styles.ts | 1 - .../nimble-components/src/tree-view/tests/tree.spec.ts | 1 - packages/spright-components/src/chat/specs/README.md | 2 -- packages/storybook/src/docs/component-status.stories.ts | 1 - packages/storybook/src/docs/nimble-intro.mdx | 2 -- .../nimble/anchor-button/anchor-button-matrix.stories.ts | 1 - .../src/nimble/anchor-button/anchor-button.stories.ts | 1 - .../src/nimble/anchor-tabs/anchor-tabs-matrix.stories.ts | 1 - .../src/nimble/anchor-tabs/anchor-tabs.stories.ts | 2 -- .../storybook/src/nimble/anchor/anchor-matrix.stories.ts | 2 -- packages/storybook/src/nimble/anchor/anchor.stories.ts | 1 - .../src/nimble/anchored-region/anchored-region.stories.ts | 1 - .../storybook/src/nimble/banner/banner-matrix.stories.ts | 1 - packages/storybook/src/nimble/banner/banner.stories.ts | 1 - .../storybook/src/nimble/breadcrumb/breadcrumb.stories.ts | 1 - .../storybook/src/nimble/button/button-matrix.stories.ts | 1 - packages/storybook/src/nimble/button/button.stories.ts | 1 - .../src/nimble/card-button/card-button-matrix.stories.ts | 1 - .../src/nimble/card-button/card-button.stories.ts | 1 - packages/storybook/src/nimble/chip/chip-matrix.stories.ts | 1 - packages/storybook/src/nimble/chip/chip.stories.ts | 1 - .../src/nimble/combobox/combobox-matrix.stories.ts | 1 - .../src/nimble/combobox/combobox-opened-in-div.stories.ts | 1 - .../src/nimble/combobox/combobox-opened-matrix.stories.ts | 1 - packages/storybook/src/nimble/combobox/combobox.stories.ts | 1 - packages/storybook/src/nimble/drawer/drawer.stories.ts | 2 -- packages/storybook/src/nimble/icon-base/icons.stories.ts | 1 - .../src/nimble/menu-button/menu-button-matrix.stories.ts | 1 - .../menu-button/menu-button-opened-matrix.stories.ts | 1 - .../src/nimble/menu-button/menu-button.stories.ts | 1 - packages/storybook/src/nimble/menu/menu-matrix.stories.ts | 1 - packages/storybook/src/nimble/menu/menu.stories.ts | 5 ----- .../src/nimble/patterns/anchor/anchor-patterns.stories.ts | 1 - .../patterns/required-visible/required-visible.stories.ts | 1 - .../rich-text/editor/rich-text-editor-matrix.stories.ts | 4 ---- .../nimble/rich-text/editor/rich-text-editor.stories.ts | 1 - .../rich-text/viewer/rich-text-viewer-matrix.stories.ts | 1 - .../nimble/rich-text/viewer/rich-text-viewer.stories.ts | 1 - .../storybook/src/nimble/select/select-matrix.stories.ts | 1 - .../src/nimble/select/select-opened-in-div.stories.ts | 1 - .../src/nimble/select/select-opened-matrix.stories.ts | 1 - packages/storybook/src/nimble/select/select.stories.ts | 1 - .../storybook/src/nimble/spinner/spinner-matrix.stories.ts | 1 - packages/storybook/src/nimble/spinner/spinner.stories.ts | 1 - .../storybook/src/nimble/switch/switch-matrix.stories.ts | 2 -- packages/storybook/src/nimble/switch/switch.stories.ts | 1 - .../anchor/table-column-anchor-matrix.stories.ts | 1 - .../table-column/anchor/table-column-anchor.stories.ts | 2 -- .../src/nimble/table-column/base/table-column.stories.ts | 7 ------- .../date-text/table-column-date-text-matrix.stories.ts | 1 - .../date-text/table-column-date-text.stories.ts | 2 -- .../table-column-duration-text-matrix.stories.ts | 1 - .../duration-text/table-column-duration-text.stories.ts | 2 -- .../mapping/table-column-mapping-matrix.stories.ts | 1 - .../table-column/mapping/table-column-mapping.stories.ts | 1 - .../menu-button/table-column-menu-button-matrix.stories.ts | 1 - .../table-column-menu-button-opened-matrix.stories.ts | 1 - .../menu-button/table-column-menu-button.stories.ts | 2 -- .../number-text/table-column-number-text-matrix.stories.ts | 1 - .../number-text/table-column-number-text.stories.ts | 2 -- .../table-column/text/table-column-text-matrix.stories.ts | 1 - .../nimble/table-column/text/table-column-text.stories.ts | 2 -- .../table/table-action-menu-opened-matrix.stories.ts | 1 - .../nimble/table/table-fit-rows-height-matrix.stories.ts | 1 - .../storybook/src/nimble/table/table-matrix.stories.ts | 1 - packages/storybook/src/nimble/table/table.stories.ts | 2 -- packages/storybook/src/nimble/tabs/tabs-matrix.stories.ts | 1 - packages/storybook/src/nimble/tabs/tabs.stories.ts | 4 ---- .../src/nimble/text-field/text-field-matrix.stories.ts | 2 -- .../storybook/src/nimble/text-field/text-field.stories.ts | 1 - .../storybook/src/nimble/theme-provider/color.stories.ts | 1 - .../src/nimble/theme-provider/size-ramp.stories.ts | 1 - packages/storybook/src/nimble/theme-provider/template.ts | 1 - .../nimble/toggle-button/toggle-button-matrix.stories.ts | 1 - .../src/nimble/toggle-button/toggle-button.stories.ts | 1 - .../storybook/src/nimble/toolbar/toolbar-matrix.stories.ts | 1 - packages/storybook/src/nimble/toolbar/toolbar.stories.ts | 1 - .../src/nimble/tree-view/tree-view-matrix.stories.ts | 1 - .../storybook/src/nimble/tree-view/tree-view.stories.ts | 3 --- .../chat/conversation/chat-conversation-matrix.stories.ts | 2 -- .../spright/chat/conversation/chat-conversation.stories.ts | 1 - .../src/spright/chat/input/chat-input-matrix.stories.ts | 2 -- .../src/spright/chat/message/chat-message.stories.ts | 4 ---- packages/storybook/src/utilities/matrix.ts | 2 -- 129 files changed, 4 insertions(+), 186 deletions(-) diff --git a/.vscode/extensions.json b/.vscode/extensions.json index 9c0045200c..26a40e522c 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -5,7 +5,6 @@ "dbaeumer.vscode-eslint", "redhat.vscode-yaml", "editorconfig.editorconfig", - "rvest.vs-code-prettier-eslint", "unifiedjs.vscode-mdx", "ms-dotnettools.csharp", "ms-dotnettools.blazorwasm-companion" diff --git a/.vscode/settings.json b/.vscode/settings.json index 8b67d4f680..d1c3d1a007 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -6,6 +6,6 @@ "mode": "auto" } ], - "editor.defaultFormatter": "rvest.vs-code-prettier-eslint", + "editor.defaultFormatter": "dbaeumer.vscode-eslint", "omnisharp.useModernNet": true } diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d1b3c9a347..648502025c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -160,7 +160,7 @@ This repository uses automated linting and automated lint formatting. Use `npm r To enable linting and formatting during development, install the recommended VS Code extensions. The list of recommended VS Code extensions can be found in `.vscode/extensions.json`. -The default formatter for the workspace should be already configured by `.vscode/settings.json`. To configure it manually go to `File >> Preferences >> Settings >> Workspace >> Text Editor >> Default Formatter` and select `Prettier ESLint`. The `Prettier ESLint` option assumes that the recommended VS Code extensions are installed. +The default formatter for the workspace should be already configured by `.vscode/settings.json`. To configure it manually go to `File >> Preferences >> Settings >> Workspace >> Text Editor >> Default Formatter` and select `ESLint`. The `ESLint` option assumes that the recommended VS Code extensions are installed. You may wish to have the formatter run every time you save a file. This would help ensure you don't forget to run the formatter and end up with a failing PR build. If you want this behavior, turn it on in your user settings: `File >> Preferences >> Settings >> User >> Text Editor >> Format On Save`. We leave this option unset in the workspace settings so that it does not override the user setting. diff --git a/packages/eslint-config-nimble/components.js b/packages/eslint-config-nimble/components.js index 439895f868..1912edfd63 100644 --- a/packages/eslint-config-nimble/components.js +++ b/packages/eslint-config-nimble/components.js @@ -73,7 +73,7 @@ export const componentsNimbleConfig = defineConfig([ { files: ['**/styles.ts'], rules: { - // Prettier and eslint conflict in how they format CSS in styles files and we prefer prettier's output + // eslint handle does not handle indent well in style files '@stylistic/indent': 'off', }, }, @@ -86,7 +86,7 @@ export const componentsNimbleConfig = defineConfig([ 'error', { selector: "LogicalExpression[operator='??']" }, ], - // Neither prettier or eslint handle indent well in template files + // eslint handle does not handle indent well in template files '@stylistic/indent': 'off', }, }, diff --git a/packages/nimble-components/CONTRIBUTING.md b/packages/nimble-components/CONTRIBUTING.md index 96ab6db102..9dfd1d1268 100644 --- a/packages/nimble-components/CONTRIBUTING.md +++ b/packages/nimble-components/CONTRIBUTING.md @@ -236,7 +236,6 @@ With an attribute defined there are several ways to react to updates. To minimiz 2. Respond to attribute values using a behavior: - ```ts import { css } from '@ni/fast-element'; css` @@ -386,7 +385,6 @@ export class MyComponent { Then in the template, bind the focusable elements' `tabindex` to the host component's property: - ```html html` { async function setup(source: Model): Promise> { return await fixture( - // prettier-ignore html` <${treeViewTag} ${ref('treeView')}> <${treeItemTag} ${ref('root1')}>Root1 diff --git a/packages/nimble-components/src/banner/specs/README.md b/packages/nimble-components/src/banner/specs/README.md index 949f0145f3..8587caf775 100644 --- a/packages/nimble-components/src/banner/specs/README.md +++ b/packages/nimble-components/src/banner/specs/README.md @@ -89,7 +89,6 @@ We only formally support spans of text in the `title` and default slots, but we ### Anatomy - ```html
${when(x => x.severity === 'error', html` diff --git a/packages/nimble-components/src/chip/template.ts b/packages/nimble-components/src/chip/template.ts index 4bb1683a04..27605b9535 100644 --- a/packages/nimble-components/src/chip/template.ts +++ b/packages/nimble-components/src/chip/template.ts @@ -10,7 +10,6 @@ import { buttonTag } from '../button'; import { iconTimesTag } from '../icons/times'; import { ButtonAppearance } from '../button/types'; -// prettier-ignore export const template: FoundationElementTemplate< ViewTemplate, ChipOptions diff --git a/packages/nimble-components/src/combobox/tests/combobox.spec.ts b/packages/nimble-components/src/combobox/tests/combobox.spec.ts index e51c153ecd..e7be29f892 100644 --- a/packages/nimble-components/src/combobox/tests/combobox.spec.ts +++ b/packages/nimble-components/src/combobox/tests/combobox.spec.ts @@ -18,7 +18,6 @@ describe('Combobox', () => { describe('with common setup', () => { async function setup(): Promise> { - // prettier-ignore const viewTemplate = html` <${comboboxTag}> <${listOptionTag}>One @@ -492,7 +491,6 @@ describe('Combobox', () => { describe('with template attributes', () => { async function setup(): Promise> { - // prettier-ignore const viewTemplate = html` <${comboboxTag} open @@ -531,7 +529,6 @@ describe('Combobox', () => { describe('with many options', () => { async function setupWithManyOptions(): Promise> { - // prettier-ignore const viewTemplate = html` <${comboboxTag} autocomplete="inline" @@ -585,7 +582,6 @@ describe('Combobox', () => { describe('within a div', () => { async function setupInDiv(): Promise> { - // prettier-ignore const viewTemplate = html`
<<${comboboxTag}>> diff --git a/packages/nimble-components/src/mapping/icon/tests/mapping-icon.spec.ts b/packages/nimble-components/src/mapping/icon/tests/mapping-icon.spec.ts index a51a563352..0f85c73f0b 100644 --- a/packages/nimble-components/src/mapping/icon/tests/mapping-icon.spec.ts +++ b/packages/nimble-components/src/mapping/icon/tests/mapping-icon.spec.ts @@ -16,7 +16,6 @@ describe('Icon Mapping', () => { let connect: () => Promise; let disconnect: () => Promise; - // prettier-ignore async function setup(): Promise> { return await fixture(html` <${mappingIconTag} diff --git a/packages/nimble-components/src/patterns/dropdown/styles.ts b/packages/nimble-components/src/patterns/dropdown/styles.ts index 65fe892686..a52e258863 100644 --- a/packages/nimble-components/src/patterns/dropdown/styles.ts +++ b/packages/nimble-components/src/patterns/dropdown/styles.ts @@ -31,7 +31,6 @@ import { themeBehavior } from '../../utilities/style/theme'; import { DropdownAppearance } from './types'; import { userSelectNone } from '../../utilities/style/user-select'; -// prettier-ignore export const styles = css` ${display('inline-flex')} diff --git a/packages/nimble-components/src/rich-text-mention/users/tests/rich-text-mention-users.spec.ts b/packages/nimble-components/src/rich-text-mention/users/tests/rich-text-mention-users.spec.ts index 8070065553..be6c95f41d 100644 --- a/packages/nimble-components/src/rich-text-mention/users/tests/rich-text-mention-users.spec.ts +++ b/packages/nimble-components/src/rich-text-mention/users/tests/rich-text-mention-users.spec.ts @@ -54,7 +54,6 @@ describe('RichTextMentionUsers', () => { let connect: () => Promise; let disconnect: () => Promise; - // prettier-ignore async function setup(options: { mappings: BasicUserMentionMapping[], pattern: string diff --git a/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts b/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts index c7e28c2845..2d79686a7b 100644 --- a/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts +++ b/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts @@ -29,7 +29,6 @@ async function setup(): Promise> { async function setupMentionConfig(): Promise> { return await fixture( - // prettier-ignore html`<${richTextEditorTag}> <${richTextMentionUsersTag} pattern="^user:(.*)"> <${mappingUserTag} key="user:1" display-name="John Doe"> diff --git a/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts b/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts index 3787377be9..80dea8ead2 100644 --- a/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts +++ b/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts @@ -18,7 +18,6 @@ async function setup(): Promise> { async function setupWithFooter(): Promise> { return await fixture( - // prettier-ignore html`<${richTextEditorTag}> <${buttonTag} slot="footer-actions" id="cancel">Cancel <${buttonTag} slot="footer-actions" id="ok">OK diff --git a/packages/nimble-components/src/rich-text/mention-listbox/tests/mention-listbox.spec.ts b/packages/nimble-components/src/rich-text/mention-listbox/tests/mention-listbox.spec.ts index 7efa044d6e..d60e26a0bb 100644 --- a/packages/nimble-components/src/rich-text/mention-listbox/tests/mention-listbox.spec.ts +++ b/packages/nimble-components/src/rich-text/mention-listbox/tests/mention-listbox.spec.ts @@ -24,7 +24,6 @@ describe('RichTextMentionListbox', () => { async function setup500Options( source: Model ): Promise> { - // prettier-ignore return await fixture( html`
diff --git a/packages/nimble-components/src/rich-text/models/tests/markdown-parser.spec.ts b/packages/nimble-components/src/rich-text/models/tests/markdown-parser.spec.ts index 5c5c5fa720..660115fd1b 100644 --- a/packages/nimble-components/src/rich-text/models/tests/markdown-parser.spec.ts +++ b/packages/nimble-components/src/rich-text/models/tests/markdown-parser.spec.ts @@ -953,7 +953,6 @@ describe('Markdown parser', () => { let connect: () => Promise; let disconnect: () => Promise; - // prettier-ignore async function setup( mappings: BasicUserMentionMapping[], pattern = '' diff --git a/packages/nimble-components/src/rich-text/viewer/tests/rich-text-viewer.spec.ts b/packages/nimble-components/src/rich-text/viewer/tests/rich-text-viewer.spec.ts index c6f7cf3330..a1e5542c7c 100644 --- a/packages/nimble-components/src/rich-text/viewer/tests/rich-text-viewer.spec.ts +++ b/packages/nimble-components/src/rich-text/viewer/tests/rich-text-viewer.spec.ts @@ -21,7 +21,6 @@ async function setup(): Promise> { async function setupMentionConfig(): Promise> { return await fixture( - // prettier-ignore html`<${richTextViewerTag}> <${richTextMentionUsersTag} pattern="^user:(.*)"> <${mappingUserTag} key="user:1" display-name="John Doe"> diff --git a/packages/nimble-components/src/select/tests/select.spec.ts b/packages/nimble-components/src/select/tests/select.spec.ts index 32a28c2173..d807bcda37 100644 --- a/packages/nimble-components/src/select/tests/select.spec.ts +++ b/packages/nimble-components/src/select/tests/select.spec.ts @@ -902,7 +902,6 @@ describe('Select', () => { describe('with 500 options', () => { async function setup500Options(): Promise> { - // prettier-ignore const viewTemplate = html` <${selectTag}> ${repeat(() => [...Array(500).keys()], html` @@ -953,7 +952,6 @@ describe('Select', () => { describe('within a div', () => { async function setupInDiv(): Promise> { - // prettier-ignore const viewTemplate = html`
<${selectTag}> diff --git a/packages/nimble-components/src/table-column/anchor/tests/table-column-anchor.spec.ts b/packages/nimble-components/src/table-column/anchor/tests/table-column-anchor.spec.ts index 0014e3e350..49894f5ceb 100644 --- a/packages/nimble-components/src/table-column/anchor/tests/table-column-anchor.spec.ts +++ b/packages/nimble-components/src/table-column/anchor/tests/table-column-anchor.spec.ts @@ -26,7 +26,6 @@ class ElementReferences { public column!: TableColumnAnchor; } -// prettier-ignore async function setup(source: ElementReferences): Promise>> { return await fixture>( html`<${tableTag} style="width: 700px" ${ref('table')}> diff --git a/packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts b/packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts index 3b303873e3..2229edd3ca 100644 --- a/packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts +++ b/packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts @@ -29,7 +29,6 @@ describe('TableColumnDateText', () => { let pageObject: TableColumnDateTextPageObject; let column: TableColumnDateText; - // prettier-ignore async function setup(source: ElementReferences): Promise>> { return await fixture>( html`<${themeProviderTag} lang="en-US"> @@ -660,7 +659,6 @@ describe('TableColumnDateText', () => { }); describe('with static config', () => { - // prettier-ignore async function setupWithConfig(source: ElementReferences): Promise>> { return await fixture>( html`<${tableTag} ${ref('table')} style="width: 700px"> diff --git a/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts b/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts index d3d2ed0fe5..a57c03171d 100644 --- a/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts +++ b/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts @@ -28,7 +28,6 @@ describe('TableColumnDurationText', () => { let pageObject: TableColumnDurationTextPageObject; let column: TableColumnDurationText; - // prettier-ignore async function setup(source: ElementReferences): Promise>> { return await fixture>( html`<${themeProviderTag} lang="en-US"> diff --git a/packages/nimble-components/src/table-column/mapping/tests/table-column-mapping.spec.ts b/packages/nimble-components/src/table-column/mapping/tests/table-column-mapping.spec.ts index a00137a056..4a2fa959b5 100644 --- a/packages/nimble-components/src/table-column/mapping/tests/table-column-mapping.spec.ts +++ b/packages/nimble-components/src/table-column/mapping/tests/table-column-mapping.spec.ts @@ -57,7 +57,6 @@ describe('TableColumnMapping', () => { let columnPageObject: TableColumnMappingPageObject; let model: Model; - // prettier-ignore async function setup(options: { keyType: MappingKeyType, iconMappings?: TestIconMapping[], @@ -441,7 +440,6 @@ describe('TableColumnMapping', () => { ).toBeTrue(); }); - // prettier-ignore async function setupInvalidMappings(): Promise>> { return await fixture>( html`<${tableTag} style="width: 700px"> diff --git a/packages/nimble-components/src/table-column/menu-button/cell-view/templates.ts b/packages/nimble-components/src/table-column/menu-button/cell-view/templates.ts index 46a066be1e..2b9634c9e5 100644 --- a/packages/nimble-components/src/table-column/menu-button/cell-view/templates.ts +++ b/packages/nimble-components/src/table-column/menu-button/cell-view/templates.ts @@ -8,7 +8,6 @@ import { import { iconArrowExpanderDownTag } from '../../../icons/arrow-expander-down'; import { cellViewMenuSlotName } from '../types'; -// prettier-ignore export const template = html` ${when(x => x.showMenuButton, html` <${menuButtonTag} diff --git a/packages/nimble-components/src/table-column/menu-button/tests/table-column-menu-button.spec.ts b/packages/nimble-components/src/table-column/menu-button/tests/table-column-menu-button.spec.ts index e05ea41583..3d15624c83 100644 --- a/packages/nimble-components/src/table-column/menu-button/tests/table-column-menu-button.spec.ts +++ b/packages/nimble-components/src/table-column/menu-button/tests/table-column-menu-button.spec.ts @@ -47,7 +47,6 @@ describe('TableColumnMenuButton', () => { let pageObject: TableColumnMenuButtonPageObject; let column: TableColumnMenuButton; - // prettier-ignore async function setup(source: ElementReferences): Promise>> { return await fixture>( html`<${tableTag} ${ref('table')} style="width: 700px"> diff --git a/packages/nimble-components/src/table-column/mixins/custom-sort-order.ts b/packages/nimble-components/src/table-column/mixins/custom-sort-order.ts index 07b012da45..8a2045f42c 100644 --- a/packages/nimble-components/src/table-column/mixins/custom-sort-order.ts +++ b/packages/nimble-components/src/table-column/mixins/custom-sort-order.ts @@ -7,7 +7,6 @@ import type { ColumnValidator } from '../base/models/column-validator'; type CustomSortOrderTableColumn< TColumnValidator extends ColumnValidator<['invalidCustomSortWithGrouping']> > = Pick, 'columnInternals'>; -// prettier-ignore // eslint-disable-next-line @typescript-eslint/no-explicit-any type CustomSortOrderTableColumnConstructor> = abstract new (...args: any[]) => CustomSortOrderTableColumn; diff --git a/packages/nimble-components/src/table-column/mixins/fractional-width-column.ts b/packages/nimble-components/src/table-column/mixins/fractional-width-column.ts index 630b24f5ae..b5e5a83043 100644 --- a/packages/nimble-components/src/table-column/mixins/fractional-width-column.ts +++ b/packages/nimble-components/src/table-column/mixins/fractional-width-column.ts @@ -4,7 +4,6 @@ import { defaultMinPixelWidth, defaultFractionalWidth } from '../base/types'; // Pick just the relevant properties the mixin depends on (typescript complains if the mixin declares private / protected base exports) type SizedTableColumn = Pick; -// prettier-ignore // eslint-disable-next-line @typescript-eslint/no-explicit-any type SizedTableColumnConstructor = abstract new (...args: any[]) => SizedTableColumn; diff --git a/packages/nimble-components/src/table-column/mixins/groupable-column.ts b/packages/nimble-components/src/table-column/mixins/groupable-column.ts index 58cf2b2223..ceb2009f5f 100644 --- a/packages/nimble-components/src/table-column/mixins/groupable-column.ts +++ b/packages/nimble-components/src/table-column/mixins/groupable-column.ts @@ -3,7 +3,6 @@ import type { TableColumn } from '../base'; // Pick just the relevant properties the mixin depends on (typescript complains if the mixin declares private / protected base exports) type GroupableTableColumn = Pick; -// prettier-ignore // eslint-disable-next-line @typescript-eslint/no-explicit-any type GroupableTableColumnConstructor = abstract new (...args: any[]) => GroupableTableColumn; diff --git a/packages/nimble-components/src/table-column/mixins/placeholder.ts b/packages/nimble-components/src/table-column/mixins/placeholder.ts index 87eb20ca11..c8542e62d0 100644 --- a/packages/nimble-components/src/table-column/mixins/placeholder.ts +++ b/packages/nimble-components/src/table-column/mixins/placeholder.ts @@ -4,7 +4,6 @@ import type { TableColumn } from '../base'; // Pick just the relevant properties the mixin depends on (typescript complains if the mixin declares private / protected base exports) // Because the 'placeholder' mixin doesn't depend on any properties of the TableColumn, there are no properties to pick. type TableColumnWithPlaceholder = Pick; -// prettier-ignore // eslint-disable-next-line @typescript-eslint/no-explicit-any type TableColumnWithPlaceholderConstructor = abstract new (...args: any[]) => TableColumnWithPlaceholder; diff --git a/packages/nimble-components/src/table-column/mixins/sortable-column.ts b/packages/nimble-components/src/table-column/mixins/sortable-column.ts index aa55f3043b..87905962b8 100644 --- a/packages/nimble-components/src/table-column/mixins/sortable-column.ts +++ b/packages/nimble-components/src/table-column/mixins/sortable-column.ts @@ -4,7 +4,6 @@ import { TableColumnSortDirection } from '../../table/types'; // Pick just the relevant properties the mixin depends on (typescript complains if the mixin declares private / protected base exports) type SortableTableColumn = Pick; -// prettier-ignore // eslint-disable-next-line @typescript-eslint/no-explicit-any type SortableTableColumnConstructor = abstract new (...args: any[]) => SortableTableColumn; diff --git a/packages/nimble-components/src/table-column/number-text/tests/table-column-number-text.spec.ts b/packages/nimble-components/src/table-column/number-text/tests/table-column-number-text.spec.ts index d8c07bee36..bd9878c4c2 100644 --- a/packages/nimble-components/src/table-column/number-text/tests/table-column-number-text.spec.ts +++ b/packages/nimble-components/src/table-column/number-text/tests/table-column-number-text.spec.ts @@ -22,7 +22,6 @@ class ElementReferences { public column2!: TableColumnNumberText; } -// prettier-ignore async function setup(source: ElementReferences): Promise>> { return await fixture>( html`<${themeProviderTag} lang="en-US"> diff --git a/packages/nimble-components/src/table-column/text/tests/table-column-text.spec.ts b/packages/nimble-components/src/table-column/text/tests/table-column-text.spec.ts index e25ef2a9a1..353486e606 100644 --- a/packages/nimble-components/src/table-column/text/tests/table-column-text.spec.ts +++ b/packages/nimble-components/src/table-column/text/tests/table-column-text.spec.ts @@ -19,7 +19,6 @@ class ElementReferences { public column!: TableColumnText; } -// prettier-ignore async function setup(source: ElementReferences): Promise>> { return await fixture>( html`<${themeProviderTag} lang="en-US"> diff --git a/packages/nimble-components/src/table/components/cell/tests/table-cell.spec.ts b/packages/nimble-components/src/table/components/cell/tests/table-cell.spec.ts index 0ba9e4556d..c2daec2d6b 100644 --- a/packages/nimble-components/src/table/components/cell/tests/table-cell.spec.ts +++ b/packages/nimble-components/src/table/components/cell/tests/table-cell.spec.ts @@ -26,7 +26,6 @@ const columnCellViewName = uniqueElementName(); }) class TestTableColumnCellView extends TableCellView {} -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableCellTag}> diff --git a/packages/nimble-components/src/table/components/group-row/tests/table-group-row.spec.ts b/packages/nimble-components/src/table/components/group-row/tests/table-group-row.spec.ts index b13d6c5981..e8c11174bc 100644 --- a/packages/nimble-components/src/table/components/group-row/tests/table-group-row.spec.ts +++ b/packages/nimble-components/src/table/components/group-row/tests/table-group-row.spec.ts @@ -12,7 +12,6 @@ type TableRowSelectionToggleEventHandler = ( evt: CustomEvent ) => void; -// prettier-ignore async function setup(): Promise> { return await fixture( html`<${tableGroupRowTag}> diff --git a/packages/nimble-components/src/table/components/row/tests/table-row.spec.ts b/packages/nimble-components/src/table/components/row/tests/table-row.spec.ts index 53dcbf16ee..775ce042e7 100644 --- a/packages/nimble-components/src/table/components/row/tests/table-row.spec.ts +++ b/packages/nimble-components/src/table/components/row/tests/table-row.spec.ts @@ -37,7 +37,6 @@ type TableRowSelectionToggleEventHandler = ( describe('TableRow', () => { describe('standalone', () => { - // prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableRowTag}> @@ -358,7 +357,6 @@ describe('TableRow', () => { public secondColumn!: TableColumnDateText; } - // prettier-ignore async function setupTable(source: ColumnReferences): Promise>> { return await fixture>( html`<${tableTag}> diff --git a/packages/nimble-components/src/table/models/tests/table-validator.spec.ts b/packages/nimble-components/src/table/models/tests/table-validator.spec.ts index 9e027ca2ef..a65456e885 100644 --- a/packages/nimble-components/src/table/models/tests/table-validator.spec.ts +++ b/packages/nimble-components/src/table/models/tests/table-validator.spec.ts @@ -244,10 +244,8 @@ describe('TableValidator', () => { it('ID field name can be an empty string', () => { const data = [ - // prettier-ignore // eslint-disable-next-line @typescript-eslint/naming-convention { stringField: 'value-1', numberField: 10, '': 'empty-1' }, - // prettier-ignore // eslint-disable-next-line @typescript-eslint/naming-convention { stringField: 'value-2', numberField: 11, '': 'empty-2' } ]; @@ -261,10 +259,8 @@ describe('TableValidator', () => { it('validation occurs when ID field name is an empty string', () => { const data = [ - // prettier-ignore // eslint-disable-next-line @typescript-eslint/naming-convention { stringField: 'value-1', numberField: 10, '': 'empty-1' }, - // prettier-ignore // eslint-disable-next-line @typescript-eslint/naming-convention { stringField: 'value-2', numberField: 11, '': 'empty-1' } ]; diff --git a/packages/nimble-components/src/table/tests/table-action-menu.spec.ts b/packages/nimble-components/src/table/tests/table-action-menu.spec.ts index 49bd3f2495..58c6bafeff 100644 --- a/packages/nimble-components/src/table/tests/table-action-menu.spec.ts +++ b/packages/nimble-components/src/table/tests/table-action-menu.spec.ts @@ -45,7 +45,6 @@ const simpleTableData = [ } ] as const; -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag}> diff --git a/packages/nimble-components/src/table/tests/table-column-sizing.spec.ts b/packages/nimble-components/src/table/tests/table-column-sizing.spec.ts index 3fcf1fc080..98839458b8 100644 --- a/packages/nimble-components/src/table/tests/table-column-sizing.spec.ts +++ b/packages/nimble-components/src/table/tests/table-column-sizing.spec.ts @@ -53,7 +53,6 @@ const largeTableData = Array.from(Array(500), (_, i) => { }; }); -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag}> @@ -65,7 +64,6 @@ async function setup(): Promise>> { ); } -// prettier-ignore async function setupInteractiveTests(): Promise>> { return await fixture>( html`<${tableTag}> diff --git a/packages/nimble-components/src/table/tests/table-delegated-events.spec.ts b/packages/nimble-components/src/table/tests/table-delegated-events.spec.ts index f3da4035f1..f492d88f92 100644 --- a/packages/nimble-components/src/table/tests/table-delegated-events.spec.ts +++ b/packages/nimble-components/src/table/tests/table-delegated-events.spec.ts @@ -34,7 +34,6 @@ class TestTableColumn extends TableColumn { } } -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag}> diff --git a/packages/nimble-components/src/table/tests/table-grouping.spec.ts b/packages/nimble-components/src/table/tests/table-grouping.spec.ts index 3a61511c06..1f01252001 100644 --- a/packages/nimble-components/src/table/tests/table-grouping.spec.ts +++ b/packages/nimble-components/src/table/tests/table-grouping.spec.ts @@ -24,7 +24,6 @@ interface HierarchicalTableRecord extends TableRecord { stringData3?: string | null; } -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag} id-field-name="id"> @@ -34,7 +33,6 @@ async function setup(): Promise>> { ); } -// prettier-ignore async function setupWithHierarchy(): Promise>> { return await fixture>( html`<${tableTag} id-field-name="id" parent-id-field-name="parentId"> diff --git a/packages/nimble-components/src/table/tests/table-keyboard-navigation.spec.ts b/packages/nimble-components/src/table/tests/table-keyboard-navigation.spec.ts index 54b6884e91..09afed65ab 100644 --- a/packages/nimble-components/src/table/tests/table-keyboard-navigation.spec.ts +++ b/packages/nimble-components/src/table/tests/table-keyboard-navigation.spec.ts @@ -202,7 +202,6 @@ describe('Table keyboard navigation', () => { describe('with non-interactive columns', () => { const nonInteractiveColumnName = uniqueElementName(); - // prettier-ignore @customElement({ name: nonInteractiveColumnName }) @@ -218,7 +217,6 @@ describe('Table keyboard navigation', () => { } } - // prettier-ignore async function setupNonInteractiveTable(): Promise>> { return await fixture>( html`<${tableTag} id-field-name="id"> @@ -1233,7 +1231,6 @@ describe('Table keyboard navigation', () => { const interactiveCellViewName = uniqueElementName(); const interactiveColumnName = uniqueElementName(); - // prettier-ignore @customElement({ name: interactiveCellViewName, template: html`Test` @@ -1246,7 +1243,6 @@ describe('Table keyboard navigation', () => { return [this.spanElement]; } } - // prettier-ignore @customElement({ name: interactiveColumnName }) @@ -1263,7 +1259,6 @@ describe('Table keyboard navigation', () => { } } - // prettier-ignore async function setupInteractiveTable(): Promise>> { return await fixture>( html`<${tableTag} id-field-name="id"> diff --git a/packages/nimble-components/src/table/tests/table-labels.spec.ts b/packages/nimble-components/src/table/tests/table-labels.spec.ts index 1e848cc4bd..d60d55f4b1 100644 --- a/packages/nimble-components/src/table/tests/table-labels.spec.ts +++ b/packages/nimble-components/src/table/tests/table-labels.spec.ts @@ -37,7 +37,6 @@ const simpleTableData = [ } ] as const; -// prettier-ignore async function setup(): Promise> { return await fixture( html` diff --git a/packages/nimble-components/src/table/tests/table-pageobject.spec.ts b/packages/nimble-components/src/table/tests/table-pageobject.spec.ts index 2c2ff103f9..77507c9003 100644 --- a/packages/nimble-components/src/table/tests/table-pageobject.spec.ts +++ b/packages/nimble-components/src/table/tests/table-pageobject.spec.ts @@ -27,7 +27,6 @@ const simpleTableData = [ } ] as const; -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag}> diff --git a/packages/nimble-components/src/table/tests/table-selection.spec.ts b/packages/nimble-components/src/table/tests/table-selection.spec.ts index 302f3771f9..70525c537a 100644 --- a/packages/nimble-components/src/table/tests/table-selection.spec.ts +++ b/packages/nimble-components/src/table/tests/table-selection.spec.ts @@ -210,7 +210,6 @@ const hierarchicalData = [ } ] as const; -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag}> diff --git a/packages/nimble-components/src/table/tests/table-sorting.spec.ts b/packages/nimble-components/src/table/tests/table-sorting.spec.ts index 25243c8613..9a8efdc0a7 100644 --- a/packages/nimble-components/src/table/tests/table-sorting.spec.ts +++ b/packages/nimble-components/src/table/tests/table-sorting.spec.ts @@ -29,7 +29,6 @@ type TableColumnConfigurationChangeEventHandler = ( evt: CustomEvent ) => void; -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag} id-field-name="id"> diff --git a/packages/nimble-components/src/table/tests/table.spec.ts b/packages/nimble-components/src/table/tests/table.spec.ts index 2ee14b78b8..c67c7e900a 100644 --- a/packages/nimble-components/src/table/tests/table.spec.ts +++ b/packages/nimble-components/src/table/tests/table.spec.ts @@ -76,7 +76,6 @@ function createLargeData(dataLength: number): SimpleTableRecord[] { const largeTableData = createLargeData(500); -// prettier-ignore async function setup(): Promise>> { return await fixture>( html`<${tableTag} style="width: 700px"> @@ -2544,7 +2543,6 @@ describe('Table', () => { let disconnect: () => Promise; let column1: TableColumnValidationTest; - // prettier-ignore async function setupWithTestColumns(): Promise>> { return await fixture>( html`<${tableTag}> diff --git a/packages/nimble-components/src/text-field/styles.ts b/packages/nimble-components/src/text-field/styles.ts index e7b831faf6..e758addcb6 100644 --- a/packages/nimble-components/src/text-field/styles.ts +++ b/packages/nimble-components/src/text-field/styles.ts @@ -24,7 +24,6 @@ import { styles as errorStyles } from '../patterns/error/styles'; import { styles as requiredVisibleStyles } from '../patterns/required-visible/styles'; import { userSelectNone } from '../utilities/style/user-select'; -// prettier-ignore export const styles = css` ${display('inline-block')} ${errorStyles} diff --git a/packages/nimble-components/src/tree-view/tests/tree.spec.ts b/packages/nimble-components/src/tree-view/tests/tree.spec.ts index 09b5d9764c..70980376a0 100644 --- a/packages/nimble-components/src/tree-view/tests/tree.spec.ts +++ b/packages/nimble-components/src/tree-view/tests/tree.spec.ts @@ -26,7 +26,6 @@ class Model { async function setup(source: Model): Promise> { return await fixture( - // prettier-ignore html` <${treeViewTag} ${ref('treeView')}> <${treeItemTag} ${ref('root1')}>Root1 diff --git a/packages/spright-components/src/chat/specs/README.md b/packages/spright-components/src/chat/specs/README.md index 3941eac77f..9303708d8b 100644 --- a/packages/spright-components/src/chat/specs/README.md +++ b/packages/spright-components/src/chat/specs/README.md @@ -145,7 +145,6 @@ richText.markdown = 'Welcome **Homer**, how can I help?'; #### Prompt buttons message example - ```html @@ -154,7 +153,6 @@ richText.markdown = 'Welcome **Homer**, how can I help?'; ``` - #### Input example diff --git a/packages/storybook/src/docs/component-status.stories.ts b/packages/storybook/src/docs/component-status.stories.ts index 17eabb79d8..83a86afbaa 100644 --- a/packages/storybook/src/docs/component-status.stories.ts +++ b/packages/storybook/src/docs/component-status.stories.ts @@ -630,7 +630,6 @@ const metadata: Meta = { parameters: { ...fastParameters() }, - // prettier-ignore render: createUserSelectedThemeStory(html`