Skip to content

Naming of methods #2

@aaademosu

Description

@aaademosu

I find the naming for the method symbol not to be appropriate, i hope you do not find that rude. It doesn't communicate what the method actually does. I would suggest that it be renamed to something from this:

NseFinance.symbol('OANDO')

to this

NseFinance.get_company_info('OANDO')

I have already gone ahead to make that change on my fork locally. If you agree, i can send a pull request for it to be merged into master.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions