Skip to content

Commit d9a3a04

Browse files
author
nicolaiparlog
committed
Renamed 'ListenerHandles.create' to 'ListenerHandles.createAttached' to better get across that the listener is added to the observable.
1 parent 24a1fee commit d9a3a04

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/demo/java/org/codefx/libfx/listener/handle/ListenerHandleDemo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ private void createCommonListenerHandle() {
4747
ChangeListener<String> listener = (obs, oldValue, newValue) -> { /* do nothing for this demo */};
4848

4949
// create the handle; this one is initially attached, i.e. the listener is added to the property
50-
ListenerHandle handle = ListenerHandles.create(property, listener);
50+
ListenerHandle handle = ListenerHandles.createAttached(property, listener);
5151
// the handle can be used to easily detach and reattach the listener
5252
handle.detach();
5353
handle.attach();

src/main/java/org/codefx/libfx/listener/handle/ListenerHandles.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static <O, L> ListenerHandleBuilder<O, L> createFor(O observable, L liste
5555
* the {@link InvalidationListener} which will be added to the {@code observable}
5656
* @return a {@link ListenerHandle} for the specified arguments; the listener is initially attached
5757
*/
58-
public static ListenerHandle create(Observable observable, InvalidationListener invalidationListener) {
58+
public static ListenerHandle createAttached(Observable observable, InvalidationListener invalidationListener) {
5959
ListenerHandle handle = createDetached(observable, invalidationListener);
6060
handle.attach();
6161
return handle;
@@ -91,7 +91,7 @@ public static ListenerHandle createDetached(Observable observable, InvalidationL
9191
* the {@link ChangeListener} which will be added to the {@code observableValue}
9292
* @return a {@link ListenerHandle} for the specified arguments; the listener is initially attached
9393
*/
94-
public static <T> ListenerHandle create(
94+
public static <T> ListenerHandle createAttached(
9595
ObservableValue<T> observableValue, ChangeListener<? super T> changeListener) {
9696

9797
ListenerHandle handle = createDetached(observableValue, changeListener);
@@ -133,7 +133,7 @@ public static <T> ListenerHandle createDetached(
133133
* the {@link ArrayChangeListener} which will be added to the {@code observableArray}
134134
* @return a {@link ListenerHandle} for the specified arguments; the listener is initially attached
135135
*/
136-
public static <T extends ObservableArray<T>> ListenerHandle create(
136+
public static <T extends ObservableArray<T>> ListenerHandle createAttached(
137137
ObservableArray<T> observableArray, ArrayChangeListener<T> changeListener) {
138138

139139
ListenerHandle handle = createDetached(observableArray, changeListener);
@@ -175,7 +175,7 @@ public static <T extends ObservableArray<T>> ListenerHandle createDetached(
175175
* the {@link ListChangeListener} which will be added to the {@code observableList}
176176
* @return a {@link ListenerHandle} for the specified arguments; the listener is initially attached
177177
*/
178-
public static <E> ListenerHandle create(
178+
public static <E> ListenerHandle createAttached(
179179
ObservableList<E> observableList, ListChangeListener<? super E> changeListener) {
180180

181181
ListenerHandle handle = createDetached(observableList, changeListener);
@@ -217,7 +217,7 @@ public static <E> ListenerHandle createDetached(
217217
* the {@link SetChangeListener} which will be added to the {@code observableSet}
218218
* @return a {@link ListenerHandle} for the specified arguments; the listener is initially attached
219219
*/
220-
public static <E> ListenerHandle create(
220+
public static <E> ListenerHandle createAttached(
221221
ObservableSet<E> observableSet, SetChangeListener<? super E> changeListener) {
222222

223223
ListenerHandle handle = createDetached(observableSet, changeListener);
@@ -261,7 +261,7 @@ public static <E> ListenerHandle createDetached(
261261
* the {@link MapChangeListener} which will be added to the {@code observableMap}
262262
* @return a {@link ListenerHandle} for the specified arguments; the listener is initially attached
263263
*/
264-
public static <K, V> ListenerHandle create(
264+
public static <K, V> ListenerHandle createAttached(
265265
ObservableMap<K, V> observableMap, MapChangeListener<? super K, ? super V> changeListener) {
266266

267267
ListenerHandle handle = createDetached(observableMap, changeListener);

0 commit comments

Comments
 (0)