Skip to content

use all neighbors for gossip #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yilunzhang merged 1 commit into from
Jan 5, 2026
Merged

use all neighbors for gossip #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lnode/neighbor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ import (
"bytes"
"errors"
"fmt"
pbnode "github.com/nknorg/nnet/protobuf/node"
"math"
"math/rand"
"net"
"net/url"
"sync"
"time"

pbnode "github.com/nknorg/nnet/protobuf/node"

"github.com/nknorg/nkn/v2/chain"
"github.com/nknorg/nkn/v2/config"
"github.com/nknorg/nkn/v2/crypto"
Expand Down Expand Up @@ -305,7 +306,9 @@ func (localNode *LocalNode) getSampledNeighbors(rn *randomNeighbors, chordNeighb
}

func (localNode *LocalNode) GetGossipNeighbors(filter func(*node.RemoteNode) bool) []*node.RemoteNode {
return localNode.getSampledNeighbors(localNode.gossipNeighbors, config.GossipSampleChordNeighbor, config.GossipMinChordNeighbor, filter)
// we use all neighbors for gossip to minimize the chance of block proposal not propagating to all nodes when the majority of the network is falling behind
return localNode.GetNeighbors(filter)
// return localNode.getSampledNeighbors(localNode.gossipNeighbors, config.GossipSampleChordNeighbor, config.GossipMinChordNeighbor, filter)
}

func (localNode *LocalNode) GetVotingNeighbors(filter func(*node.RemoteNode) bool) []*node.RemoteNode {
Expand Down