-
Notifications
You must be signed in to change notification settings - Fork 6
Description
standards-checklist/app/src/schema.json
Lines 45 to 48 in c22a4be
"type": "object", "properties": { "1": { "type": "boolean",
Do we need one more level of depth for the items, to include the boolean and an optional comment?
β #30 (comment)
Exactly, it would look something like this:
"2": { "type": "object", "title": "Documentation is up to date with version of software", "properties": { "value": { "type": "boolean", "default": false } "comment": { "type": "string", "default": "" } } },To avoid repetition this could be
$def-ined once and then used for every item.
β #30 (comment)
am I understanding correctly that the schema now supports comments, but the UI does not? Would it be a lot to add that to the UI, or should we kick the can on this and do it in a follow-up PR? I'm happy to kick the can
β #30 (comment)
This PR does not add user comment support for items in any way. It just reimplements the currently public version with jsonschema + jsonforms and minor additions.
Of course this is easy to add, but I assume opening separate PRs for this and Jon's other points would make them easier for you all to review.
β #30 (comment)
[#18] is adding comment support to the UI, [#33] is adding comment support to the schema
β #30 (comment)