0.9.2. (#21)

Author: b4rtaz

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.9.2
+
+This version fixes a bug in the `ValueEditorFactoryResolver` class. Now, when an editor is not found, the resolver throws an error.
+
 ## 0.9.1
 
 This version exports the `variableNameValidator` function in the `sequential-workflow-editor-model` package.

demos/webpack-app/package.json

@@ -18,8 +18,8 @@
 		"sequential-workflow-model": "^0.2.0",
 		"sequential-workflow-designer": "^0.16.0",
 		"sequential-workflow-machine": "^0.4.0",
-		"sequential-workflow-editor-model": "^0.9.1",
-		"sequential-workflow-editor": "^0.9.1"
+		"sequential-workflow-editor-model": "^0.9.2",
+		"sequential-workflow-editor": "^0.9.2"
 	},
 	"devDependencies": {
 		"ts-loader": "^9.4.2",

editor/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "sequential-workflow-editor",
-	"version": "0.9.1",
+	"version": "0.9.2",
 	"type": "module",
 	"main": "./lib/esm/index.js",
 	"types": "./lib/index.d.ts",
@@ -46,11 +46,11 @@
 		"prettier:fix": "prettier --write ./src ./css"
 	},
 	"dependencies": {
-		"sequential-workflow-editor-model": "^0.9.1",
+		"sequential-workflow-editor-model": "^0.9.2",
 		"sequential-workflow-model": "^0.2.0"
 	},
 	"peerDependencies": {
-		"sequential-workflow-editor-model": "^0.9.1",
+		"sequential-workflow-editor-model": "^0.9.2",
 		"sequential-workflow-model": "^0.2.0"
 	},
 	"devDependencies": {

editor/src/value-editors/value-editor-factory-resolver.spec.ts

@@ -0,0 +1,38 @@
+import { ValueEditorFactoryResolver } from './value-editor-factory-resolver';
+
+describe('ValueEditorFactoryResolver', () => {
+	describe('default', () => {
+		const resolver = ValueEditorFactoryResolver.create();
+
+		describe('resolve()', () => {
+			it('resolves string', () => {
+				const factory = resolver.resolve('string', undefined);
+				expect(factory).toBeDefined();
+			});
+
+			it('throws error when editor is not found', () => {
+				expect(() => resolver.resolve('some_unknown_mode_id', undefined)).toThrowError(
+					'Editor id some_unknown_mode_id is not supported'
+				);
+			});
+		});
+
+		describe('isHidden()', () => {
+			it('string is not hidden', () => {
+				const is = resolver.isHidden('string', undefined);
+				expect(is).toBe(false);
+			});
+
+			it('"branches" editor is hidden', () => {
+				const is = resolver.isHidden('branches', undefined);
+				expect(is).toBe(true);
+			});
+
+			it('throws error when editor is not found', () => {
+				expect(() => resolver.isHidden('some_unknown_mode_id', undefined)).toThrowError(
+					'Editor id some_unknown_mode_id is not supported'
+				);
+			});
+		});
+	});
+});

editor/src/value-editors/value-editor-factory-resolver.ts

@@ -64,6 +64,14 @@ export class ValueEditorFactoryResolver {
 	}
 
 	public isHidden(valueModelId: string, editorId: string | undefined): boolean {
-		return !this.map[editorId ?? valueModelId];
+		const id = editorId ?? valueModelId;
+		const editor = this.map[editorId ?? valueModelId];
+		if (editor === null) {
+			return true;
+		}
+		if (editor !== undefined) {
+			return false;
+		}
+		throw new Error(`Editor id ${id} is not supported`);
 	}
 }

model/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "sequential-workflow-editor-model",
-	"version": "0.9.1",
+	"version": "0.9.2",
 	"homepage": "https://nocode-js.com/",
 	"author": {
 		"name": "NoCode JS",

scripts/publish.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+
+cd "$(dirname "${BASH_SOURCE[0]}")"
+
+cd ../model
+yarn build
+npm publish
+
+cd ../editor
+yarn build
+npm publish