strava.client(access_token) broken in v4?

[pro-sumer]

This code was working fine with v3:

import strava from 'strava-v3'
...
strava.client(access_token)
strava.config({
  client_id: ...,
  client_secret: ...,
  redirect_uri: ...
})
...
await strava.athlete.listActivities({ 1, per_page: 50 })

However, with v4 I get a 401 from Strava and I noticed that the library sends Bearer undefined...

This seems to work:

import strava from 'strava-v3'
...
strava.config({
  access_token: access_token
  client_id: ...,
  client_secret: ...,
  redirect_uri: ...
})
...
await strava.athlete.listActivities({ 1, per_page: 50 })

I didn't read anything about this in the release notes.

What am I doing wrong? Or what did I miss?

[wesleyschlenker]

@pro-sumer In f853c41, we started using the new keyword to ensure proper instantiation of multiple clients. The behavior of bare strava.client(token) as a way to “activate” the singleton changed when client was made to behave like a real constructor. This is the intended pattern to keep the token on the instance you get back:

const client = new strava.client(access_token)
await client.athlete.listActivities({ page: 1, per_page: 50 })

The path you used sets the token globally and is also covered in the README.

strava.config({ access_token, client_id, client_secret, redirect_uri })
await strava.athlete.listActivities({ page: 1, per_page: 50 })