-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
node-api: support SharedArrayBuffer in napi_create_dataview #60473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
node-api: support SharedArrayBuffer in napi_create_dataview #60473
Conversation
|
Review requested:
|
f2b1f83 to
68ea53e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60473 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 704 704
Lines 207826 207864 +38
Branches 40035 40052 +17
=======================================
+ Hits 184059 184094 +35
- Misses 15802 15806 +4
+ Partials 7965 7964 -1
🚀 New features to boost your workflow:
|
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
|
I do not think we add macro definitions for changes in behavior (eg. no I see three paths to introduce this to
Thoughts? Or any other ideas? |
The previous implementation does not support calling
napi_create_dataviewwith aSharedArrayBuffer, as the check forvalue->IsArrayBuffer()returnsfalse, causing the Node-API call to return annapi_invalid_arg.