Skip to content

Conversation

@avivkeller
Copy link
Member

Follow-up #8175. This is the last hurdle for me to add this to doc-kit

Copilot AI review requested due to automatic review settings December 6, 2025 16:12
@avivkeller avivkeller requested a review from a team as a code owner December 6, 2025 16:12
@vercel
Copy link

vercel bot commented Dec 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Dec 6, 2025 4:28pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.27%. Comparing base (9dd8a43) to head (bab86e7).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8398      +/-   ##
==========================================
- Coverage   76.41%   75.27%   -1.14%     
==========================================
  Files         118      107      -11     
  Lines        9928     9155     -773     
  Branches      334      313      -21     
==========================================
- Hits         7586     6891     -695     
+ Misses       2340     2262      -78     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.52 MB
New Total Size 3.52 MB
Delta -300.00 B (-0.01%)

Changes

➕ Added Assets (3)
Name Size
.next/static/chunks/9986e72628d70cf6.js 412.11 KB
.next/static/chunks/7a0b515b4833ad2a.js 204.65 KB
.next/static/chunks/3ebfc68712acc06c.js 412.11 KB
➖ Removed Assets (3)
Name Size
.next/static/chunks/6c837cbd5c378f5e.js 412.26 KB
.next/static/chunks/6d000e562b3dbf83.js 204.65 KB
.next/static/chunks/5ee4ffa1e78c2c3b.js 412.26 KB

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a reusable SearchHit UI component in the ui-components package and refactors the existing site-specific SearchItem to use it. The SearchHit component abstracts search result item rendering, making it available for use across different projects including doc-kit.

Key Changes

  • New SearchHit component in ui-components with customizable link rendering via as prop
  • Refactored SearchItem to wrap SearchHit with site-specific logic
  • Consolidated CSS by moving shared styles from site-specific files to ui-components
  • Updated DocumentLink to use shared CSS from ui-components

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/ui-components/src/Common/Search/Results/Hit/index.tsx New SearchHit component with flexible link rendering and mode-based accessibility
packages/ui-components/src/Common/Search/Results/Hit/index.module.css CSS for SearchHit with consolidated styles from previously site-specific files
packages/ui-components/package.json Patch version bump to 1.4.1
apps/site/components/Common/Searchbox/index.tsx Updated import to use default export of SearchItem
apps/site/components/Common/Searchbox/SearchItem/index.tsx Refactored to wrap SearchHit component with site-specific document transformation
apps/site/components/Common/Searchbox/DocumentLink/index.tsx Updated to use shared CSS from ui-components and simplified rendering
apps/site/components/Common/Searchbox/DocumentLink/index.module.css Removed file as styles moved to ui-components

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants