Skip to content

return response when receiving 401 instead of network error #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Jan 25, 2026
+4 −8
Merged

return response when receiving 401 instead of network error #4769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/web/fetch/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1677,9 +1677,9 @@ async function httpNetworkOrCacheFetch (
// requestCurrentURL(request).password = TODO

// In browsers, the user will be prompted to enter a username/password before the request
// is re-sent. To prevent an infinite 401 loop, return a network error for now.
// is re-sent. To prevent an infinite 401 loop, return the response for now.
// https://github.com/nodejs/undici/pull/4756
return makeNetworkError()
return response
}

// 4. Set response to the result of running HTTP-network-or-cache fetch given
Expand Down
8 changes: 2 additions & 6 deletions test/fetch/401-statuscode-no-infinite-loop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,14 @@ const assert = require('node:assert')
const { closeServerAsPromise } = require('../utils/node-http')

test('Receiving a 401 status code should not cause infinite retry loop', async (t) => {
let requestCount = 0

const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
requestCount++
console.log({ requestCount })
res.statusCode = 401
res.setHeader('WWW-Authenticate', 'Basic realm="test"')
res.end('Unauthorized')
}).listen(0)

t.after(closeServerAsPromise(server))
await once(server, 'listening')

await assert.rejects(() => fetch(`http://localhost:${server.address().port}`))
const response = await fetch(`http://localhost:${server.address().port}`)
assert.strictEqual(response.status, 401)
})
Loading