From 22ea798a72556426361bfe1ecd97339608e11896 Mon Sep 17 00:00:00 2001 From: phewphewb Date: Sat, 31 Jan 2026 15:29:53 -0500 Subject: [PATCH 1/6] fix: fail if no build uploaded --- .github/workflows/build.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 690907ffae1e..80b03e19dc72 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -45,4 +45,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: firmware-${{ matrix.keyboard == 'zsa/moonlander/reva' && 'reva' || 'revb' }} - path: .build/*.bin + path: | + zsa_moonlander_*_klayi.bin + zsa_moonlander_*_klayi.hex + if-no-files-found: error From c3473e9d48118a58942b70ff1ec213ca0473a7a7 Mon Sep 17 00:00:00 2001 From: phewphewb Date: Sat, 31 Jan 2026 15:30:04 -0500 Subject: [PATCH 2/6] chore: debug info --- .github/workflows/build.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 80b03e19dc72..ad6711178ea6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,6 +40,14 @@ jobs: run: | qmk compile -kb ${{ matrix.keyboard }} -km ${{ matrix.keymap }} -e SKIP_GIT=1 + - name: List build output + if: matrix.keymap == 'klayi' + run: | + echo "Root directory:" + ls -la *.bin *.hex 2>/dev/null || echo " No files in root" + echo ".build directory:" + ls -la .build/*.bin .build/*.hex 2>/dev/null || echo " No files in .build" + - name: Upload firmware if: matrix.keymap == 'klayi' uses: actions/upload-artifact@v4 From 128c4dddba34aa0c9738b12c9ca283f114337249 Mon Sep 17 00:00:00 2001 From: phewphewb Date: Sat, 31 Jan 2026 15:39:59 -0500 Subject: [PATCH 3/6] chore: remove debug step; fix file path --- .github/workflows/build.yml | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ad6711178ea6..f0993b148e8f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,10 +16,6 @@ jobs: fail-fast: false matrix: include: - - keyboard: zsa/moonlander/reva - keymap: oryx - - keyboard: zsa/moonlander/revb - keymap: oryx - keyboard: zsa/moonlander/reva keymap: klayi - keyboard: zsa/moonlander/revb @@ -40,20 +36,12 @@ jobs: run: | qmk compile -kb ${{ matrix.keyboard }} -km ${{ matrix.keymap }} -e SKIP_GIT=1 - - name: List build output - if: matrix.keymap == 'klayi' - run: | - echo "Root directory:" - ls -la *.bin *.hex 2>/dev/null || echo " No files in root" - echo ".build directory:" - ls -la .build/*.bin .build/*.hex 2>/dev/null || echo " No files in .build" - - name: Upload firmware if: matrix.keymap == 'klayi' uses: actions/upload-artifact@v4 with: name: firmware-${{ matrix.keyboard == 'zsa/moonlander/reva' && 'reva' || 'revb' }} path: | - zsa_moonlander_*_klayi.bin - zsa_moonlander_*_klayi.hex + .build/zsa_moonlander_*_klayi.bin + .build/zsa_moonlander_*_klayi.hex if-no-files-found: error From 919d6d83513ec9cd1e64665c32d3494cf1f3fed8 Mon Sep 17 00:00:00 2001 From: phewphewb Date: Sat, 31 Jan 2026 15:42:06 -0500 Subject: [PATCH 4/6] fix: firmware name --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f0993b148e8f..b7eb4d966672 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,7 +40,7 @@ jobs: if: matrix.keymap == 'klayi' uses: actions/upload-artifact@v4 with: - name: firmware-${{ matrix.keyboard == 'zsa/moonlander/reva' && 'reva' || 'revb' }} + name: firmware-klayi-${{ matrix.keyboard == 'zsa/moonlander/reva' && 'reva' || 'revb' }} path: | .build/zsa_moonlander_*_klayi.bin .build/zsa_moonlander_*_klayi.hex From 97c7c76d0d9362dc8a7fcb190144fa89a1a321d4 Mon Sep 17 00:00:00 2001 From: phewphewb Date: Sat, 31 Jan 2026 15:52:04 -0500 Subject: [PATCH 5/6] fix: try hardcoded name --- .github/workflows/build.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b7eb4d966672..7dcc6160c35a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -18,8 +18,10 @@ jobs: include: - keyboard: zsa/moonlander/reva keymap: klayi + firmware: zsa_moonlander_reva_klayi - keyboard: zsa/moonlander/revb keymap: klayi + firmware: zsa_moonlander_revb_klayi steps: - name: Checkout QMK Firmware @@ -37,11 +39,10 @@ jobs: qmk compile -kb ${{ matrix.keyboard }} -km ${{ matrix.keymap }} -e SKIP_GIT=1 - name: Upload firmware - if: matrix.keymap == 'klayi' uses: actions/upload-artifact@v4 with: - name: firmware-klayi-${{ matrix.keyboard == 'zsa/moonlander/reva' && 'reva' || 'revb' }} + name: ${{ matrix.firmware }} path: | - .build/zsa_moonlander_*_klayi.bin - .build/zsa_moonlander_*_klayi.hex + .build/${{ matrix.firmware }}.bin + .build/${{ matrix.firmware }}.hex if-no-files-found: error From c8b6f43010475d21845dbb34bf11e062f05f95e4 Mon Sep 17 00:00:00 2001 From: phewphewb Date: Sat, 31 Jan 2026 15:52:26 -0500 Subject: [PATCH 6/6] chore: update pattern --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5c1597edccfa..fbdef6b6d4a2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,7 +34,7 @@ jobs: uses: actions/download-artifact@v4 with: path: release - pattern: firmware-* + pattern: zsa_moonlander_*_klayi merge-multiple: true run-id: ${{ github.event.workflow_run.id }} github-token: ${{ secrets.GITHUB_TOKEN }}