Merge pull request #6 from non-existing-organization/fix/remove-vars

fix vars & names

Author: simple-me

USAGE.md

@@ -25,7 +25,6 @@ No requirements.
 | region | n/a | `string` | `"us-east-1"` | no |
 | schedule\_expression | Cloudwatch rule rate expression for how frequent you want the lambda function to run | `string` | n/a | yes |
 | source\_code\_hash | hash of the current zip file, changes in the function code will produce an update of the lambda function | `string` | n/a | yes |
-| source\_file | The path in your filesystem where your script is located | `string` | n/a | yes |
 | table\_name | Name of the DynamoDB table | `string` | n/a | yes |
 
 ## Outputs

main.tf

@@ -61,7 +61,7 @@ resource "aws_iam_role_policy_attachment" "dynamodb_full" {
 
 resource "aws_iam_policy" "dynamodb-policy" {
   name        = var.dynamodb_policy_name
-  description = "Sg checker dynamodb policy"
+  description = "Dynamodb policy"
   policy = jsonencode({
     Version = "2012-10-17"
     Statement = [
@@ -78,7 +78,7 @@ resource "aws_iam_policy" "dynamodb-policy" {
           "dynamodb:ConditionCheckItem"
         ]
         Effect   = "Allow"
-        Resource = "arn:aws:dynamodb:${var.region}:${data.aws_caller_identity.current.account_id}:table/${aws_dynamodb_table.sg_dynamo_table.name}"
+        Resource = "arn:aws:dynamodb:${var.region}:${data.aws_caller_identity.current.account_id}:table/${aws_dynamodb_table.dynamodb_table.name}"
       },
     ]
   })
@@ -93,7 +93,7 @@ resource "aws_lambda_permission" "allow_cloudwatch_to_call_lambda" {
 }
 
 #DynamoDB table definition
-resource "aws_dynamodb_table" "sg_dynamo_table" {
+resource "aws_dynamodb_table" "dynamodb_table" {
   name           = local.table_name
   billing_mode   = "PROVISIONED"
   read_capacity  = "30"
@@ -111,11 +111,11 @@ resource "aws_dynamodb_table" "sg_dynamo_table" {
 #Cloudwatch rule definition
 resource "aws_cloudwatch_event_rule" "event_rule" {
   name                = var.cloudwatch_event_rule_name
-  description         = "Rule that triggers the sg checker lambda"
+  description         = "Rule that triggers lambda function"
   schedule_expression = local.schedule_expression
 }
 
-resource "aws_cloudwatch_event_target" "sg_checker_target" {
+resource "aws_cloudwatch_event_target" "cloudwatch_event_target" {
   depends_on = [
     aws_cloudwatch_event_rule.event_rule
   ]

variables.tf

@@ -3,11 +3,6 @@ variable "region" {
   default = "us-east-1"
 }
 
-variable "source_file" {
-  type        = string
-  description = "The path in your filesystem where your script is located"
-}
-
 variable "output_path" {
   type        = string
   description = "The path and name of the resulting zip file"
@@ -19,13 +14,13 @@ variable "function_name" {
 }
 
 variable "lambda_runtime" {
-  type = string
+  type        = string
   description = "Lambda runtime i.e <python3.8>"
-  default = "python3.8"
+  default     = "python3.8"
 }
 
 variable "source_code_hash" {
-  type = string
+  type        = string
   description = "hash of the current zip file, changes in the function code will produce an update of the lambda function"
 }