Skip to content
This repository was archived by the owner on Jun 19, 2023. It is now read-only.
This repository was archived by the owner on Jun 19, 2023. It is now read-only.

PingPongMonitor alive even after closing connection #90

@drauch

Description

@drauch

In SlackConnection.Close the _pingPongMonitor is not stopped. Therefore the Timer in the ping-pong monitor keeps a reference and holds the connection alive (no GC) + it tries to ping-pong every 5 s although I closed the corresponding SlackConnection.

I suggest adding a method StopMonitor to IPingPongMonitor which disables the timer:

        public void StopMonitor()
        {
            _timer?.Dispose();
            _timer = null;
        }

Any objections?

Best regards,
D.R.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions