Skip to content

Pausing of playback when going into the native iOS camera app #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DSandfeld opened this issue Nov 1, 2019 · 2 comments
Open

Pausing of playback when going into the native iOS camera app #132

DSandfeld opened this issue Nov 1, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@DSandfeld
Copy link

In iOS12 the playback stops when the user opens the camera app.

This happens due to AudioSession receiving a notification thatrouteAudioChanged acts on, the reason being .unknown which will change the state of the player to paused.

This is unintended behaviour. An interruption should only happen if the camera goes to video mode. We have tested this a fair bit and the issue is not present in iOS13. We have run tests with leaving out the check for .unknown, in line 205 of PlayingState.swift. Everything still works fine without that check, as InterruptionAudioService will act as intended with proper handling of going to the video mode.

I hope that you will have time soon to attend this minor correction. If wanted I could prepare a pull-request with this change :-)

@raphrel
Copy link
Member

raphrel commented Nov 1, 2019

Hi,

thanks for this. Any pull request is welcome !
I may check this in the few days anyway..

@raphrel raphrel added the bug Something isn't working label Nov 1, 2019
@raphrel raphrel self-assigned this Nov 1, 2019
@raphrel
Copy link
Member

raphrel commented May 21, 2020

I don't have anymore iOS 12 device, so I can't check anything about this.
If you have time to check and prepare a PR, should be nice.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants