Skip to content

Commit d84b634

Browse files
225: Fix the benchmarks datasets URL format r=Kerollmops a=Kerollmops We were using an URL of the form _git://github.com/orga/repo.git_ which is wrong and GitHub broke it recently. I just changed it to make it valid by using the https://github.com/orga/repo.git format. This PR also changes the version of `retain_mut` to _=0.1.7_ to avoid CI-breaking warnings. If you want to understand the reason why I am doing that you can read more in RoaringBitmap#224. Co-authored-by: Kerollmops <clement@meilisearch.com>
2 parents 0035230 + b56f78e commit d84b634

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
/target
22
/Cargo.lock
3+
/proptest-regressions

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ license = "MIT OR Apache-2.0"
1818
[dependencies]
1919
bytemuck = "1.7.3"
2020
byteorder = "1.4.3"
21-
retain_mut = "0.1.6"
21+
retain_mut = "=0.1.7"
2222

2323
[features]
2424
simd = []

benchmarks/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ roaring = { path = ".." }
1111

1212
[dev-dependencies]
1313
once_cell = "1.9"
14-
git2 = { version = "0.13", default-features = false, features = ["vendored-openssl"] }
14+
git2 = { version = "0.13", default-features = false, features = ["https", "vendored-openssl"] }
1515
zip = { version = "0.5", default-features = false, features = ["deflate"] }
1616
indicatif = "0.16"
1717
criterion = { version = "0.3", features = ["html_reports"] }

benchmarks/benches/datasets.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ fn init_datasets() -> Result<PathBuf, Box<dyn std::error::Error>> {
9999
if !Path::new(&repo_path).exists() {
100100
git2::build::RepoBuilder::new()
101101
.fetch_options(fetch_opts)
102-
.clone("git://github.com/RoaringBitmap/real-roaring-datasets.git", &repo_path)?;
102+
.clone("https://github.com/RoaringBitmap/real-roaring-datasets.git", &repo_path)?;
103103
} else {
104104
let repo = git2::Repository::open(&repo_path)?;
105105
repo.find_remote("origin")?.fetch(&["master"], Some(&mut fetch_opts), None)?;

0 commit comments

Comments
 (0)