re: #159 each() deprecation

[jchimene]

I'm seeing a deprecation warning at line 3100 in XMLRPC. See #159.

Deprecated: The each() function is deprecated.

	// DEPRECATED
	function serializeval($o)
	{
		// add check? slower, but helps to avoid recursion in serializing broken xmlrpcvals...
		//if (is_object($o) && (get_class($o) == 'xmlrpcval' || is_subclass_of($o, 'xmlrpcval')))
		//{
			$ar=$o->me;
			reset($ar);
			list($typ, $val) = each($ar);
			return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
		//}
	}

[jchimene]

Looks like I grabbed an old version.

[jchimene]

I think this version of xmlrpc.inc can only be installed correctly if the required libraries are also installed. If you want to keep this, I'll start bundling those libraries called out in composer.json.

[jchimene]

I've implemented Composer in my plugin. I'll start shipping vendor.
I'm going to drop the WordPress plugin in favor of a dependency on infusionsoft-sdk. xmlrpc.inc diverges too much between the versions. If you leave forceutf8 out of the plugin, there's still one too many versions of xmlrpc.inc for my comfort.

[joeynovak]

Hey! We made it a goal to not require a library, or any dependencies, but, I'm still interested in seeing what you have :)

…

On Mon, Nov 9, 2020 at 7:49 AM jchimene ***@***.***> wrote: I've implemented Composer in my plugin. I'll start shipping vendor. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFLPK4EP6EHGAMOFT5VHPDSPAFPRANCNFSM4TN4O2HA> .

-- C) 503-719-2169 Like Novak Solutions on Facebook <http://www.facebook.com/plugins/like.php?href=http://www.facebook.com/pages/Novak-Solutions-LLC/282048461853879> "Opportunity is missed by most people because it is dressed in overalls and looks like work." --Thomas Edison

[jchimene]

The composer.json for the sdk calls out neitanod/forceutf8
which is now in xmlrpc.inc

I'm trying to get the PS4 mapping correct for my stuff. Once I have that, I'll add infusionsoft-sdk & post that composer.json

[joeynovak]

Oh yeah, that's right, I JUST added that. I thought you were talking about php extensions not dependencies.

…

On Tue, Nov 10, 2020 at 12:51 PM jchimene ***@***.***> wrote: The composer.json for the sdk calls out neitanod/forceutf8 which is now in xmlrpc.inc I'm trying to get the PS4 mapping correct for my stuff. Once I have that, I'll add infusionsoft-sdk & post that composer.json — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFLPK422NIK7MCZYTKRADTSPGRVPANCNFSM4TN4O2HA> .

-- C) 503-719-2169 Like Novak Solutions on Facebook <http://www.facebook.com/plugins/like.php?href=http://www.facebook.com/pages/Novak-Solutions-LLC/282048461853879> "Opportunity is missed by most people because it is dressed in overalls and looks like work." --Thomas Edison

[jchimene]

Here's composer.json

Updated to not include composer.* in the plugin folder.

There's more to the conversion. If it's worth it, I'll supply the rewrites of load() and activation, deactivation.
The feed add-on will co-exist with the infusionsoft-sdk plugin, since that plugin may be serving more than one client.

It seems to be working in that the regression tests pass.

[jchimene]

PHP v8 is imminent.
From the upgrade notes

Removed each(). foreach or ArrayIterator should be used instead.

I'm pretty sure this will break most XMLRPC versions floating around with the SDK

[jchimene]

Any comments? The WordPress plugin is broken in PHP V8 because of XMLRPC.INC

[joeynovak]

Just busy with a bunch of other stuff, and we won't be moving to php v8 for quite a while so it hasn't made it on my priority list. Joey

…

On Sat, Dec 12, 2020 at 11:36 AM jchimene ***@***.***> wrote: Any comments? The WordPress plugin is broken in PHP V8 because of XMLRPC.INC — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFLPK6HXSFBTEOIEBQR4DDSUPA3ZANCNFSM4TN4O2HA> .

-- C) 503-719-2169 Like Novak Solutions on Facebook <http://www.facebook.com/plugins/like.php?href=http://www.facebook.com/pages/Novak-Solutions-LLC/282048461853879> "Opportunity is missed by most people because it is dressed in overalls and looks like work." --Thomas Edison

[jchimene]

The feed add-on will co-exist with the infusionsoft-sdk plugin, since that plugin may be serving more than one client.

Nope. It turns out that my regression test was not robust.
It's not possible to replace the relevant XMLRPC class definitions If XMLRPC.INC loads via the Infusionsoft SDK plugin before the feed add-on.
There's no effective run-time fix, as the XMLRPC library is require'd when the SDK plugin loads. This means the old XMLRPC library will be used at run-time instead of the newer SDK.
At this point, I think the best solution is to disable the SDK plugin at feed add-on activation, and attempt to reactivate it at feed add-on deactivation. The other choice would be updating the SDK plugin, creating other issues.

[joeynovak]

Interesting... Ok, I'll put it on my radar, if you were to create a pull request to our sdk with the fixes it would get fixed much sooner (possibly years sooner). Joey

…

On Tue, Dec 15, 2020 at 9:59 AM jchimene ***@***.***> wrote: The feed add-on will co-exist with the infusionsoft-sdk plugin, since that plugin may be serving more than one client. Nope. It turns out that my regression test was not robust. It's not possible to replace the relevant XMLRPC class definitions If XMLRPC.INC loads via the Infusionsoft SDK plugin before the feed add-on. There's no effective run-time fix, as the XMLRPC library is require'd when the SDK plugin loads. This means the old XMLRPC library will be used at run-time instead of the newer SDK. At this point, I think the best solution is to disable the SDK plugin at feed activation. The other choice would be updating the SDK plugin, creating other issues. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFLPK6YGELZ2KALGQFD5PLSU6PY3ANCNFSM4TN4O2HA> .

-- C) 503-719-2169 Like Novak Solutions on Facebook <http://www.facebook.com/plugins/like.php?href=http://www.facebook.com/pages/Novak-Solutions-LLC/282048461853879> "Opportunity is missed by most people because it is dressed in overalls and looks like work." --Thomas Edison

[jchimene]

I'll give it a shot.