Remove markdown, refactor

Author: nthienan

pom.xml

@@ -48,7 +48,6 @@
       <groupId>commons-lang</groupId>
       <artifactId>commons-lang</artifactId>
       <version>2.6</version>
-      <scope>provided</scope>
     </dependency>
 
     <!-- https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient -->
@@ -97,7 +96,7 @@
         </configuration>
       </plugin>
       <plugin>
-        <!-- UTF-8 bundles are not supported by Java, so they must be converted during build -->
+        <!-- UTF-8 bundles are not supported by Java, so they must be converted durbuildReportuild -->
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>native2ascii-maven-plugin</artifactId>
         <version>1.0-beta-1</version>

…nthienan/phdiff/NotificationPostJob.java …n/phdiff/PhabricatorDifferentialBot.javasrc/main/java/io/nthienan/phdiff/NotificationPostJob.java renamed to src/main/java/io/nthienan/phdiff/PhabricatorDifferentialBot.java src/main/java/io/nthienan/phdiff/NotificationPostJob.java renamed to src/main/java/io/nthienan/phdiff/PhabricatorDifferentialBot.java

@@ -1,12 +1,12 @@
 package io.nthienan.phdiff;
 
-import io.nthienan.phdiff.comment.GlobalCommenter;
-import io.nthienan.phdiff.comment.CommentBuilder;
 import io.nthienan.phdiff.issue.IssueComparator;
+import io.nthienan.phdiff.report.GlobalReportBuilder;
 import org.sonar.api.batch.postjob.PostJob;
 import org.sonar.api.batch.postjob.PostJobContext;
 import org.sonar.api.batch.postjob.PostJobDescriptor;
 import org.sonar.api.batch.postjob.issue.PostJobIssue;
+import org.sonar.api.config.Settings;
 import org.sonar.api.utils.log.Logger;
 import org.sonar.api.utils.log.Loggers;
 
@@ -18,16 +18,18 @@
  *
  * @author nthienan
  */
-public class NotificationPostJob implements PostJob {
+public class PhabricatorDifferentialBot implements PostJob {
 
-    private static final Logger LOG = Loggers.get(NotificationPostJob.class);
+    private static final Logger LOG = Loggers.get(PhabricatorDifferentialBot.class);
 
     private static final Comparator<PostJobIssue> ISSUE_COMPARATOR = new IssueComparator();
 
-    private final CommentBuilder reportBuilder;
+    private final GlobalReportBuilder reportBuilder;
+    private Settings settings;
 
-    public NotificationPostJob(CommentBuilder reportBuilder) {
+    public PhabricatorDifferentialBot(GlobalReportBuilder reportBuilder, Settings settings) {
         this.reportBuilder = reportBuilder;
+        this.settings = settings;
     }
 
     @Override
@@ -39,17 +41,13 @@ public void describe(PostJobDescriptor descriptor) {
 
     @Override
     public void execute(PostJobContext context) {
-        GlobalCommenter commenter = new GlobalCommenter(this.reportBuilder);
         // issues are not accessible when the mode "issues" is not enabled
         if (context.analysisMode().isIssues()) {
             StreamSupport.stream(context.issues().spliterator(), false)
                 .filter(PostJobIssue::isNew)
                 .sorted(ISSUE_COMPARATOR)
-                .forEach(commenter::process);
-        }
-        if(commenter.hasNewIssue()) {
-            String markdown = commenter.formatForMarkdown();
-            LOG.error(String.format("Markdown: %s", markdown));
+                .forEach(reportBuilder::add);
         }
+        LOG.error(reportBuilder.buildReport());
     }
 }

src/main/java/io/nthienan/phdiff/PhabricatorDifferentialPlugin.java

@@ -1,7 +1,7 @@
 package io.nthienan.phdiff;
 
-import io.nthienan.phdiff.comment.MarkDownCommentBuilder;
-import io.nthienan.phdiff.comment.MarkDownUtils;
+import io.nthienan.phdiff.report.RemarkGlobalReportBuilder;
+import io.nthienan.phdiff.report.RemarkupUtils;
 import org.sonar.api.Plugin;
 import org.sonar.api.Properties;
 import org.sonar.api.Property;
@@ -50,10 +50,10 @@ public class PhabricatorDifferentialPlugin implements Plugin {
     @Override
     public void define(Context context) {
         context.addExtensions(
-            NotificationPostJob.class,
+            PhabricatorDifferentialBot.class,
             Configuration.class,
-            MarkDownCommentBuilder.class,
-            MarkDownUtils.class
+            RemarkGlobalReportBuilder.class,
+            RemarkupUtils.class
         );
     }
 }