diff --git a/core/pom.xml b/core/pom.xml
index 19bc3fc61..2cae5868f 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -120,10 +120,11 @@
3.2.3.RELEASE
provided
+
org.mockito
- mockito-all
- 1.9.0
+ mockito-core
+ 5.4.0
test
diff --git a/core/src/main/java/com/nuodb/migrator/jdbc/metadata/inspector/NuoDBColumnInspector.java b/core/src/main/java/com/nuodb/migrator/jdbc/metadata/inspector/NuoDBColumnInspector.java
index 5d954674c..e1bfce6dc 100644
--- a/core/src/main/java/com/nuodb/migrator/jdbc/metadata/inspector/NuoDBColumnInspector.java
+++ b/core/src/main/java/com/nuodb/migrator/jdbc/metadata/inspector/NuoDBColumnInspector.java
@@ -90,7 +90,7 @@ protected void processResultSet(InspectionContext inspectionContext, ResultSet c
DatabaseMetaData databaseMetaData = inspectionContext.getConnection().getMetaData();
Map fieldsType = new HashMap();
try (ResultSet columnsFromDatabaseMetaData = databaseMetaData.getColumns(null, schema, tableName, null)) {
- if (columnsFromDatabaseMetaData.next()) {
+ if (columnsFromDatabaseMetaData != null && columnsFromDatabaseMetaData.next()) {
do {
JdbcTypeDesc typeDescAlias = dialect.getJdbcTypeAlias(
columnsFromDatabaseMetaData.getInt("DATA_TYPE"),
diff --git a/core/src/test/java/com/nuodb/migrator/backup/BackupOpsValidateTableFilterTest.java b/core/src/test/java/com/nuodb/migrator/backup/BackupOpsValidateTableFilterTest.java
index 3b19e42fd..338327a6a 100644
--- a/core/src/test/java/com/nuodb/migrator/backup/BackupOpsValidateTableFilterTest.java
+++ b/core/src/test/java/com/nuodb/migrator/backup/BackupOpsValidateTableFilterTest.java
@@ -47,9 +47,12 @@
import static com.nuodb.migrator.jdbc.metadata.filter.MetaDataFilters.newAllOfFilters;
import static com.nuodb.migrator.jdbc.metadata.filter.MetaDataFilters.newEitherOfFilters;
import static com.nuodb.migrator.jdbc.metadata.Identifier.valueOf;
+import static org.junit.Assert.assertNotNull;
import static org.mockito.Mockito.*;
import static org.mockito.BDDMockito.given;
-import static org.mockito.Matchers.anyString;
+import static org.mockito.ArgumentMatchers.anyString;
+import org.mockito.ArgumentCaptor;
+
/**
* @author Mukund
@@ -76,7 +79,9 @@ public void testValidateTableNameFilter(ArrayList databaseTable, String
XmlBackupOps backupOps1 = spy(new XmlBackupOps());
backupOps1.verifyFilter(databaseTable, all);
- verify(backupOps1, times(1)).logWarnMessage(valueOf(anyString()));
+ ArgumentCaptor identifierCaptor = ArgumentCaptor.forClass(Identifier.class);
+ verify(backupOps1, times(1)).logWarnMessage(identifierCaptor.capture());
+ assertNotNull(identifierCaptor.getValue().value());
}
@DataProvider(name = "getData1")
@@ -97,6 +102,9 @@ public void testValidateTableRegexFilter1(ArrayList databaseTable, Strin
XmlBackupOps backupOps1 = spy(new XmlBackupOps());
backupOps1.verifyFilter(databaseTable, all);
- verify(backupOps1, times(1)).logWarnMessage(valueOf(anyString()));
+
+ ArgumentCaptor identifierCaptor = ArgumentCaptor.forClass(Identifier.class);
+ verify(backupOps1, times(1)).logWarnMessage(identifierCaptor.capture());
+ assertNotNull(identifierCaptor.getValue().value());
}
}
diff --git a/core/src/test/java/com/nuodb/migrator/cli/CliHandlerTest.java b/core/src/test/java/com/nuodb/migrator/cli/CliHandlerTest.java
index 9b8e1a2da..7a2a41279 100644
--- a/core/src/test/java/com/nuodb/migrator/cli/CliHandlerTest.java
+++ b/core/src/test/java/com/nuodb/migrator/cli/CliHandlerTest.java
@@ -35,7 +35,7 @@
import static java.io.File.createTempFile;
import static org.apache.commons.io.IOUtils.write;
-import static org.mockito.Matchers.any;
+import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
diff --git a/core/src/test/java/com/nuodb/migrator/cli/parse/option/OptionFactory.java b/core/src/test/java/com/nuodb/migrator/cli/parse/option/OptionFactory.java
index c29f72939..681a3c24a 100644
--- a/core/src/test/java/com/nuodb/migrator/cli/parse/option/OptionFactory.java
+++ b/core/src/test/java/com/nuodb/migrator/cli/parse/option/OptionFactory.java
@@ -35,7 +35,7 @@
import static com.google.common.collect.Lists.newArrayList;
import static org.apache.commons.lang3.StringUtils.startsWith;
-import static org.mockito.Matchers.anyString;
+import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.*;
/**
diff --git a/core/src/test/java/com/nuodb/migrator/cli/run/CliRunSupportTest.java b/core/src/test/java/com/nuodb/migrator/cli/run/CliRunSupportTest.java
index 76f12723a..6aedc874a 100644
--- a/core/src/test/java/com/nuodb/migrator/cli/run/CliRunSupportTest.java
+++ b/core/src/test/java/com/nuodb/migrator/cli/run/CliRunSupportTest.java
@@ -54,7 +54,7 @@
import static com.google.common.collect.Maps.newHashMap;
import static com.nuodb.migrator.jdbc.metadata.MetaDataUtils.createTable;
import static java.util.TimeZone.getTimeZone;
-import static org.mockito.Matchers.notNull;
+import static org.mockito.ArgumentMatchers.notNull;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.testng.Assert.*;
diff --git a/core/src/test/java/com/nuodb/migrator/dump/DumpJobTest.java b/core/src/test/java/com/nuodb/migrator/dump/DumpJobTest.java
index ebb8c379d..126191bfc 100644
--- a/core/src/test/java/com/nuodb/migrator/dump/DumpJobTest.java
+++ b/core/src/test/java/com/nuodb/migrator/dump/DumpJobTest.java
@@ -43,9 +43,7 @@
import com.nuodb.migrator.job.JobExecution;
import com.nuodb.migrator.job.JobExecutor;
import com.nuodb.migrator.spec.DumpJobSpec;
-import org.mockito.InjectMocks;
-import org.mockito.Mock;
-import org.mockito.Spy;
+import org.mockito.*;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
@@ -58,7 +56,7 @@
import static com.nuodb.migrator.jdbc.metadata.Identifier.EMPTY;
import static com.nuodb.migrator.job.JobExecutors.createJobExecutor;
import static org.mockito.BDDMockito.*;
-import static org.mockito.Matchers.any;
+import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.MockitoAnnotations.initMocks;
@@ -89,16 +87,14 @@ public class DumpJobTest {
@Spy
@InjectMocks
private DumpJob dumpJob = new DumpJob(new DumpJobSpec());
- @Spy
- @InjectMocks
- private BackupWriter backupWriter = new BackupWriter();
+
private JobExecutor jobExecutor;
private Map