Add database.sm.tolerations template to HotCopy SM #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontaras
requested review from
adriansuarez,
bkelly-ndb and
sivanov-nuodb
as code owners
| {{- if .Values.database.sm.tolerations }} | ||
| tolerations: | ||
| {{ toYaml .Values.database.sm.tolerations | trim | indent 8 }} | ||
| {{ include "database.sm.tolerations" . | trim | indent 8 }} |
There was a problem hiding this comment.
Nit: Are you going to update the test as well?
There was a problem hiding this comment.
What test needs updating? The TestDatabaseTolerations tests HotCopy SMs but did not catch this because it is a regression test and the charts in this repo continued to behave correctly. This issue will only come up if we want to add HotCopy SMs to the 3DS helm charts.
There was a problem hiding this comment.
Right. Thanks for the explanation!
adriansuarez
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #405 , I missed adding the "database.sm.tolerations" template to the hotcopy SM stateful set.