Handle cursed env flag positions

[mkatychev]

As @blindFS pointed out, env flag positions in the textmate grammar aren't being handled and this not rendered on GitHub:
nushell/tree-sitter-nu#225 (comment)

def bar --wrapped --env  [...args] {}

[fdncred]

ok. feel free to submit a PR for this grammar.

[blindFS]

I would say maybe sometimes more restrictions to the nu syntax isn't a bad thing.

[mkatychev]

I would say maybe sometimes more restrictions to the nu syntax isn't a bad thing.

I don't disagree but that sort of thing should happen at the linter/formatter/best-practices level.

So long as the core language parser explicitly supports the wrong way to do it, it should be supported in downstream grammar parsers.

[blindFS]

So long as the core language parser explicitly supports the wrong way to do it, it should be supported in downstream grammar parsers.

Fair enough, by "sometimes" I mean implicit ones, e.g. some malformed bareword interpolations

[RedCMD]

here's my VSCode extension to help with authoring TextMate grammars https://marketplace.visualstudio.com/items?itemName=RedCMD.tmlanguage-syntax-highlighter

[fdncred]

I played around a bit this morning and I'm thinking this would fix it and would also allow:

• def bar [...args] {}
• def bar --wrapped --env [...args] {}
• def bar --env [...args] {}
• def bar --wrapped [...args] {}
• def --wrapped --env bar [...args] {}
• def --env bar [...args] {}
• def --wrapped bar [...args] {}
• def --wrapped bar --env [...args] {}

    "function": {
      "begin": "((?:export\\s+)?def)(?:\\s+((?:--\\w+(?:\\s+--\\w+)*)))?\\s+([\\w\\-]+|\"[\\w\\- ]+\"|'[\\w\\- ]+'|`[\\w\\- ]+`)(?:\\s+((?:--\\w+(?:\\s+--\\w+)*)))?",
      "beginCaptures": {
        "1": { "name": "entity.name.function.nushell" },
        "2": { "name": "entity.name.function.nushell" },
        "3": { "name": "entity.name.type.nushell" },
        "4": { "name": "entity.name.function.nushell" }
      },
      "end": "(?<=\\})",
      "patterns": [
        { "include": "#function-parameters" },
        { "include": "#function-body" },
        { "include": "#function-inout" }
      ]
    },

#222