Fixed lint errors

Author: rofrano

dot-env-example

@@ -2,5 +2,4 @@ PORT=8080
 CLOUDANT_HOST=localhost
 CLOUDANT_PORT=5984
 CLOUDANT_USERNAME=admin
-CLOUDANT_PASSWORD=pass
-
+CLOUDANT_PASSWORD=pass

service/__init__.py

@@ -36,47 +36,52 @@
 
 app.url_map.strict_slashes = False
 
-app.config['SECRET_KEY'] = 'secret-for-dev'
-app.config['LOGGING_LEVEL'] = logging.INFO
-app.config['API_KEY'] = os.getenv('API_KEY')
-app.config['ERROR_404_HELP'] = False
+app.config["SECRET_KEY"] = "secret-for-dev"
+app.config["LOGGING_LEVEL"] = logging.INFO
+app.config["API_KEY"] = os.getenv("API_KEY")
+app.config["ERROR_404_HELP"] = False
 
 # Document the type of authorization required
-authorizations = {
-    'apikey': {
-        'type': 'apiKey',
-        'in': 'header',
-        'name': 'X-Api-Key'
-    }
-}
+authorizations = {"apikey": {"type": "apiKey", "in": "header", "name": "X-Api-Key"}}
 
 ######################################################################
 # Configure Swagger before initializing it
 ######################################################################
-api = Api(app,
-          version='1.0.0',
-          title='Pet Demo REST API Service',
-          description='This is a sample server Pet store server.',
-          default='pets',
-          default_label='Pet shop operations',
-          doc='/apidocs', # default also could use doc='/apidocs/'
-          authorizations=authorizations,
-          prefix='/api'
-         )
+api = Api(
+    app,
+    version="1.0.0",
+    title="Pet Demo REST API Service",
+    description="This is a sample server Pet store server.",
+    default="pets",
+    default_label="Pet shop operations",
+    doc="/apidocs",  # default also could use doc='/apidocs/'
+    authorizations=authorizations,
+    prefix="/api",
+)
+
 
 # Import the routes After the Flask app is created
-from service import routes, models
+# pylint: disable=wrong-import-position, wrong-import-order, cyclic-import
+from service import routes, models  # noqa: F401, E402
+from service.common import error_handlers
 
 # Set up logging for production
 log_handlers.init_logging(app, "gunicorn.error")
 
-app.logger.info(70 * '*')
-app.logger.info('  P E T   S E R V I C E   R U N N I N G  '.center(70, '*'))
-app.logger.info(70 * '*')
+app.logger.info(70 * "*")
+app.logger.info("  P E T   S E R V I C E   R U N N I N G  ".center(70, "*"))
+app.logger.info(70 * "*")
 
-app.logger.info('Service initialized!')
+app.logger.info("Service initialized!")
 
 # If an API Key was not provided, autogenerate one
-if not app.config['API_KEY']:
-    app.config['API_KEY'] = routes.generate_apikey()
-    app.logger.info('Missing API Key! Autogenerated: {}'.format(app.config['API_KEY']))
+if not app.config["API_KEY"]:
+    app.config["API_KEY"] = routes.generate_apikey()
+    app.logger.info("Missing API Key! Autogenerated: %s", app.config["API_KEY"])
+
+try:
+    routes.init_db()
+except Exception as error:  # pylint: disable=broad-except
+    app.logger.critical("%s: Cannot continue", error)
+    # gunicorn requires exit code 4 to stop spawning workers when they die
+    sys.exit(4)

service/common/error_handlers.py

@@ -24,27 +24,29 @@
 from service.models import DataValidationError, DatabaseConnectionError
 from . import status
 
+
 ######################################################################
 # Special Error Handlers
 ######################################################################
 @api.errorhandler(DataValidationError)
 def request_validation_error(error):
-    """ Handles Value Errors from bad data """
+    """Handles Value Errors from bad data"""
     message = str(error)
     app.logger.error(message)
     return {
-        'status_code': status.HTTP_400_BAD_REQUEST,
-        'error': 'Bad Request',
-        'message': message
+        "status_code": status.HTTP_400_BAD_REQUEST,
+        "error": "Bad Request",
+        "message": message,
     }, status.HTTP_400_BAD_REQUEST
 
+
 @api.errorhandler(DatabaseConnectionError)
 def database_connection_error(error):
-    """ Handles Database Errors from connection attempts """
+    """Handles Database Errors from connection attempts"""
     message = str(error)
     app.logger.critical(message)
     return {
-        'status_code': status.HTTP_503_SERVICE_UNAVAILABLE,
-        'error': 'Service Unavailable',
-        'message': message
-    }, status.HTTP_503_SERVICE_UNAVAILABLE
+        "status_code": status.HTTP_503_SERVICE_UNAVAILABLE,
+        "error": "Service Unavailable",
+        "message": message,
+    }, status.HTTP_503_SERVICE_UNAVAILABLE

service/common/log_handlers.py

@@ -30,7 +30,9 @@ def init_logging(app, logger_name: str):
     app.logger.handlers = gunicorn_logger.handlers
     app.logger.setLevel(gunicorn_logger.level)
     # Make all log formats consistent
-    formatter = logging.Formatter("[%(asctime)s] [%(levelname)s] [%(module)s] %(message)s", "%Y-%m-%d %H:%M:%S %z")
+    formatter = logging.Formatter(
+        "[%(asctime)s] [%(levelname)s] [%(module)s] %(message)s", "%Y-%m-%d %H:%M:%S %z"
+    )
     for handler in app.logger.handlers:
         handler.setFormatter(formatter)
     app.logger.info("Logging handler established")