From 2c926860a5b28bf40b1ad2d24ff0bf1b12185689 Mon Sep 17 00:00:00 2001 From: viktorking7 <140458814+viktorking7@users.noreply.github.com> Date: Tue, 23 Sep 2025 18:16:56 +0200 Subject: [PATCH 1/3] Update lookup_verifier.rs --- o1vm/src/pickles/lookup_verifier.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/o1vm/src/pickles/lookup_verifier.rs b/o1vm/src/pickles/lookup_verifier.rs index c14758b295..d0e27da0ca 100644 --- a/o1vm/src/pickles/lookup_verifier.rs +++ b/o1vm/src/pickles/lookup_verifier.rs @@ -22,7 +22,7 @@ pub fn lookup_verify< EFqSponge: Clone + FqSponge, EFrSponge: FrSponge, >( - // input dependant of main proto + // input dependent of main proto beta_challenge: G::ScalarField, gamma_challenge: G::ScalarField, constraint: ELookup, From cc577cd86a7729b6f1f0df0be38096178c91b428 Mon Sep 17 00:00:00 2001 From: viktorking7 <140458814+viktorking7@users.noreply.github.com> Date: Tue, 23 Sep 2025 18:17:42 +0200 Subject: [PATCH 2/3] Update lookup_prover.rs --- o1vm/src/pickles/lookup_prover.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/o1vm/src/pickles/lookup_prover.rs b/o1vm/src/pickles/lookup_prover.rs index f5b7133ac7..d50e5b6280 100644 --- a/o1vm/src/pickles/lookup_prover.rs +++ b/o1vm/src/pickles/lookup_prover.rs @@ -54,7 +54,7 @@ where }; // Compute the 1/beta+sum_i gamma^i value_i for each lookup term - // The inversions is commputed in batch in the end + // The inversions is computed in batch in the end let mut inverses: Vec> = wires .iter() .zip(arity) @@ -101,7 +101,7 @@ where .interpolate() }; let columns_poly = columns.my_map(interpolate_col); - // Commiting + // Committing // TODO avoid cloning let columns_com = columns_poly .clone() @@ -113,7 +113,7 @@ where let columns_eval_d8 = columns_poly .clone() .my_map(|poly| poly.evaluate_over_domain_by_ref(domain.d8)); - // abosrbing commit + // absorbing commit // TODO don't absorb the wires which already have been // TODO avoid cloning columns_com From 5b5f2e121a06b06383194976669a3d4ac4cc102f Mon Sep 17 00:00:00 2001 From: viktorking7 <140458814+viktorking7@users.noreply.github.com> Date: Tue, 23 Sep 2025 18:18:42 +0200 Subject: [PATCH 3/3] Update kimchi.md --- book/src/specs/kimchi.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/book/src/specs/kimchi.md b/book/src/specs/kimchi.md index 951f7ef20e..33349f760e 100644 --- a/book/src/specs/kimchi.md +++ b/book/src/specs/kimchi.md @@ -1203,7 +1203,7 @@ One could lay this out as a double-width gate for chained foreign additions and We reuse the foreign field addition gate for the final bound check since this is an addition with a specific parameter structure. Checking that the correct right input, overflow, and overflow are used shall be done by copy constraining these values with a public input value. One could have a specific gate -for just this check requiring less constrains, but the cost of adding one more selector gate outweights +for just this check requiring less constrains, but the cost of adding one more selector gate outweighs the savings of one row and a few constraints of difference. ##### Integration @@ -1696,7 +1696,7 @@ To create the index, follow these steps: with the table ID of the table. * Copy the entries from the table to new rows in the corresponding columns of the concatenated table. * Fill in any unused columns with 0 (to match the dummy value) -6. Pad the end of the concatened table with the dummy value. +6. Pad the end of the concatenated table with the dummy value. 7. Pad the end of the table id vector with 0s. 8. pre-compute polynomial and evaluation form for the look up tables 9. pre-compute polynomial and evaluation form for the table IDs, @@ -2119,7 +2119,7 @@ The following sections specify how a prover creates a proof, and how a verifier To create a proof, the prover expects: -* A prover index, containing a representation of the circuit (and optionaly pre-computed values to be used in the proof creation). +* A prover index, containing a representation of the circuit (and optionally pre-computed values to be used in the proof creation). * The (filled) registers table, representing parts of the execution trace of the circuit. ```admonish