generated code - use const constructors

Author: Ivan Dlugos

generator/lib/src/code_chunks.dart

@@ -194,9 +194,9 @@ class CodeChunks {
 
       String? fbReader;
       var readFieldOrNull = () =>
-          '$fbReader.vTableGetNullable(buffer, rootOffset, ${propertyFlatBuffersvTableOffset(p)})';
+          'const $fbReader.vTableGetNullable(buffer, rootOffset, ${propertyFlatBuffersvTableOffset(p)})';
       var readFieldNonNull = ([String? defaultValue]) =>
-          '$fbReader.vTableGet(buffer, rootOffset, ${propertyFlatBuffersvTableOffset(p)}, ${defaultValue ?? fieldDefaultValue(p)})';
+          'const $fbReader.vTableGet(buffer, rootOffset, ${propertyFlatBuffersvTableOffset(p)}, ${defaultValue ?? fieldDefaultValue(p)})';
       var readField =
           () => p.fieldIsNullable ? readFieldOrNull() : readFieldNonNull();
 

objectbox/analysis_options.yaml

@@ -19,6 +19,8 @@ linter:
     - prefer_relative_imports
     - type_annotate_public_apis
     - prefer_initializing_formals
+    - prefer_const_constructors
+    - prefer_const_constructors_in_immutables
     # - lines_longer_than_80_chars
 
 # exclude standalone packages:

objectbox/test/sync_test.dart

@@ -277,7 +277,7 @@ void main() {
 
         // Note: wait for the client to finish sending to the server.
         // There's currently no other way to recognize this.
-        sleep(Duration(milliseconds: 100));
+        sleep(const Duration(milliseconds: 100));
         client.close();
 
         final client2 = loggedInClient(env2.store);
@@ -401,7 +401,7 @@ class SyncServer {
           } on SocketException catch (e) {
             // only retry if "connection refused"
             if (e.osError!.errorCode != 111) rethrow;
-            await Future<void>.delayed(Duration(milliseconds: 1));
+            await Future<void>.delayed(const Duration(milliseconds: 1));
           }
         }
         httpClient.close(force: true);

objectbox/test/test_env.dart

@@ -35,7 +35,7 @@ bool waitUntil(bool Function() predicate, {Duration timeout = defaultTimeout}) {
   final until = DateTime.now().add(timeout);
 
   while (!(success = predicate()) && until.isAfter(DateTime.now())) {
-    sleep(Duration(milliseconds: 1));
+    sleep(const Duration(milliseconds: 1));
   }
   return success;
 }