generated C-API binding - fixes

Author: Ivan Dlugos

generator/integration-tests/basics/1.dart

@@ -4,7 +4,7 @@ import 'lib/objectbox.g.dart';
 import 'package:test/test.dart';
 import '../test_env.dart';
 import '../common.dart';
-import 'package:objectbox/src/bindings/constants.dart';
+import 'package:objectbox/src/bindings/bindings.dart';
 
 void main() {
   TestEnv<A> env;
@@ -32,7 +32,7 @@ void main() {
     expect(entity(model, 'A').flags, equals(0));
     expect(entity(jsonModel, 'A').flags, equals(0));
 
-    expect(entity(model, 'D').flags, equals(OBXEntityFlag.SYNC_ENABLED));
-    expect(entity(jsonModel, 'D').flags, equals(OBXEntityFlag.SYNC_ENABLED));
+    expect(entity(model, 'D').flags, equals(OBXEntityFlags.SYNC_ENABLED));
+    expect(entity(jsonModel, 'D').flags, equals(OBXEntityFlags.SYNC_ENABLED));
   });
 }

generator/lib/src/code_chunks.dart

@@ -1,6 +1,6 @@
 import "dart:convert";
 import "package:objectbox/src/modelinfo/index.dart";
-import "package:objectbox/src/bindings/constants.dart" show OBXPropertyType;
+import "package:objectbox/src/bindings/bindings.dart" show OBXPropertyType;
 import "package:source_gen/source_gen.dart" show InvalidGenerationSourceError;
 
 class CodeChunks {

generator/lib/src/entity_resolver.dart

@@ -4,7 +4,7 @@ import 'dart:convert';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:build/build.dart';
 import 'package:objectbox/objectbox.dart' as obx;
-import 'package:objectbox/src/bindings/constants.dart';
+import 'package:objectbox/src/bindings/bindings.dart';
 import 'package:objectbox/src/modelinfo/index.dart';
 import 'package:source_gen/source_gen.dart';
 
@@ -61,11 +61,11 @@ class EntityResolver extends Builder {
     }
 
     if (_syncChecker.hasAnnotationOfExact(element)) {
-      entity.flags |= OBXEntityFlag.SYNC_ENABLED;
+      entity.flags |= OBXEntityFlags.SYNC_ENABLED;
     }
 
     log.info('entity ${entity.name}(${entity.id}), sync=' +
-        (entity.hasFlag(OBXEntityFlag.SYNC_ENABLED) ? 'ON' : 'OFF'));
+        (entity.hasFlag(OBXEntityFlags.SYNC_ENABLED) ? 'ON' : 'OFF'));
 
     // getters, ... (anything else?)
     final readOnlyFields = <String, bool>{};
@@ -104,7 +104,7 @@ class EntityResolver extends Builder {
         hasIdProperty = true;
 
         fieldType = OBXPropertyType.Long;
-        flags |= OBXPropertyFlag.ID;
+        flags |= OBXPropertyFlags.ID;
 
         final _idAnnotation = _idChecker.firstAnnotationOfExact(f);
         propUid = _idAnnotation.getField('uid').toIntValue();

install.sh

@@ -2,8 +2,12 @@
 set -eu
 
 # https://github.com/objectbox/objectbox-c/releases
-# Warning: ensure C lib signature changes are reflected in lib/src/bindings/signatures.dart
-# Dart won't error if they do not match, it may lead to obscure memory bugs.
+# It's important that the generated dart bindings and the c-api library version match. Dart won't error on C function
+# signature mismatch, leading to obscure memory bugs.
+# After upgrading to a different C-API version:
+#   * update lib/src/bindings/objectbox.h
+#   * execute pub run ffigen
+#   * have a look at the changed files to see if some call sites need to be updated
 cLibVersion=0.10.0
 os=$(uname)
 

lib/src/bindings/helpers.dart

@@ -46,3 +46,7 @@ String cString(Pointer<Int8> charPtr) {
 
   return Utf8.fromUtf8(charPtr.cast<Utf8>());
 }
+
+// ffigen currently uses Pointer<Int32> for bool* so we need to clear the whole
+// allocated memory before C call, to make sure the result looks is as expected.
+Pointer<Int32> cBool() => allocate<Int32>()..value = 0;