Skip to content

Commit ebe8cc6

Browse files
author
Ivan Dlugos
committed
change default Query caseSensitive value to TRUE
1 parent 0544970 commit ebe8cc6

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

objectbox/lib/src/native/store.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class Store {
5757
int? maxDBSizeInKB,
5858
int? fileMode,
5959
int? maxReaders,
60-
bool queriesCaseSensitiveDefault = false})
60+
bool queriesCaseSensitiveDefault = true})
6161
: _weak = false,
6262
_queriesCaseSensitiveDefault = queriesCaseSensitiveDefault {
6363
var model = Model(_defs.model);
@@ -155,7 +155,7 @@ class Store {
155155
/// }
156156
/// ```
157157
Store.fromReference(this._defs, this._reference,
158-
{bool queriesCaseSensitiveDefault = false})
158+
{bool queriesCaseSensitiveDefault = true})
159159
// must not close the same native store twice so [_weak]=true
160160
: _weak = true,
161161
_queriesCaseSensitiveDefault = queriesCaseSensitiveDefault {

objectbox/test/query_property_test.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ void main() {
8585
queryFloat.close();
8686
});
8787

88-
final queryString = box.query(tString.contains('t')).build();
88+
final queryString =
89+
box.query(tString.contains('t', caseSensitive: false)).build();
8990
expect(queryString.count(), 8);
9091
queryString.close();
9192

@@ -235,7 +236,8 @@ void main() {
235236

236237
final queryIntegers = box.query(tLong.lessThan(100)).build();
237238
final queryFloats = box.query(tDouble.between(-1.0, 1.0)).build();
238-
final queryStrings = box.query(tString.endsWith('suffix')).build();
239+
final queryStrings =
240+
box.query(tString.endsWith('suffix', caseSensitive: false)).build();
239241

240242
final start = [1, 2, 4, 5];
241243
for (var i = 0; i < tIntegers.length; i++) {
@@ -427,7 +429,8 @@ void main() {
427429
}
428430

429431
// string
430-
final query = box.query(tString.contains('t')).build();
432+
final query =
433+
box.query(tString.contains('t', caseSensitive: false)).build();
431434
final queryString = query.property(tString) as StringPropertyQuery;
432435
expect(queryString.count(), 8);
433436
expect((queryString..distinct = true).count(), 5);

objectbox/test/query_test.dart

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@ void main() {
114114
[q1, q2, q3, q4].forEach((q) => q.close());
115115
};
116116
final env1 = TestEnv('query1', queryCaseSensitive: true);
117-
final env2 = TestEnv('query1', queryCaseSensitive: false);
117+
final env2 = TestEnv('query2', queryCaseSensitive: false);
118118

119119
// current default: case insensitive
120-
testCaseSensitivity(env.box, false);
120+
testCaseSensitivity(env.box, true);
121121
testCaseSensitivity(env1.box, true);
122122
testCaseSensitivity(env2.box, false);
123123

@@ -480,21 +480,21 @@ void main() {
480480
.or(text.equals('World'));
481481
final q = box.query(c).build();
482482
final expectedString = [
483-
'''((tString ==(i) "Goodbye"''',
483+
'''((tString == "Goodbye"''',
484484
''' AND tLong == 1337)''',
485485
''' OR tLong == 1337''',
486-
''' OR tString ==(i) "Cruel"''',
487-
''' OR tString ==(i) "World")'''
486+
''' OR tString == "Cruel"''',
487+
''' OR tString == "World")'''
488488
].join('\n');
489489
expect(q.describeParameters(), expectedString);
490490
q.close();
491491

492492
for (var j = 1; j < 20; j++) {
493493
var tc = text.equals('Goodbye');
494-
var expected = ['''tString ==(i) "Goodbye"'''];
494+
var expected = ['''tString == "Goodbye"'''];
495495
for (var i = 0; i < j; i++) {
496496
tc = tc.and(text.endsWith('ye'));
497-
expected.add(''' AND tString ends with(i) "ye"''');
497+
expected.add(''' AND tString ends with "ye"''');
498498
}
499499
final q = box.query(tc).build();
500500
expect(q.describeParameters(), '''(${expected.join("\n")})''');
@@ -503,10 +503,10 @@ void main() {
503503

504504
for (var j = 1; j < 20; j++) {
505505
var tc = text.equals('Goodbye');
506-
var expected = ['''tString ==(i) "Goodbye"'''];
506+
var expected = ['''tString == "Goodbye"'''];
507507
for (var i = 0; i < j; i++) {
508508
tc = tc.or(text.startsWith('Good'));
509-
expected.add(''' OR tString starts with(i) "Good"''');
509+
expected.add(''' OR tString starts with "Good"''');
510510
}
511511
final q = box.query(tc).build();
512512
expect(q.describeParameters(), '''(${expected.join("\n")})''');

0 commit comments

Comments
 (0)