default round text strokeJoin (#566)

Author: mbostock

src/marks/text.js

@@ -3,7 +3,9 @@ import {filter, nonempty} from "../defined.js";
 import {Mark, indexOf, identity, string, maybeNumber, maybeTuple, numberChannel} from "../mark.js";
 import {applyChannelStyles, applyDirectStyles, applyIndirectStyles, applyAttr, applyTransform, offset} from "../style.js";
 
-const defaults = {};
+const defaults = {
+  strokeLinejoin: "round"
+};
 
 export class Text extends Mark {
   constructor(data, options = {}) {

src/style.js

@@ -24,6 +24,7 @@ export function styles(
     fill: defaultFill = "currentColor",
     stroke: defaultStroke = "none",
     strokeWidth: defaultStrokeWidth,
+    strokeLinejoin: defaultStrokeLinejoin,
     strokeMiterlimit: defaultStrokeMiterlimit
   }
 ) {
@@ -55,6 +56,7 @@ export function styles(
   // defaults if the stroke is not (constant) none.
   if (cstroke !== "none") {
     if (strokeWidth === undefined) strokeWidth = defaultStrokeWidth;
+    if (strokeLinejoin === undefined) strokeLinejoin = defaultStrokeLinejoin;
     if (strokeMiterlimit === undefined) strokeMiterlimit = defaultStrokeMiterlimit;
   }
 

test/marks/text-test.js

@@ -49,3 +49,10 @@ it("text(data, {fill}) allows fill to be a variable color", () => {
   assert.strictEqual(fill.value, "x");
   assert.strictEqual(fill.scale, "color");
 });
+
+it("text(data, {stroke}) has a default strokeLinejoin of round", () => {
+  const text = Plot.text(undefined, {stroke: "red"});
+  assert.strictEqual(text.fill, "none");
+  assert.strictEqual(text.stroke, "red");
+  assert.strictEqual(text.strokeLinejoin, "round");
+});