From 053e2f1b4e8fbe8be288ea9213784c9f40a82ffc Mon Sep 17 00:00:00 2001 From: Hugo Heuzard Date: Sun, 14 Sep 2025 13:24:55 +0200 Subject: [PATCH 1/5] WIP --- .github/workflows/js_of_ocaml.yml | 10 +++++----- compiler/tests-ocaml/lib-list/test.ml | 4 ++-- compiler/tests-toplevel/test_toplevel.expected | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/js_of_ocaml.yml b/.github/workflows/js_of_ocaml.yml index 19c8c76af1..6a5d38104b 100644 --- a/.github/workflows/js_of_ocaml.yml +++ b/.github/workflows/js_of_ocaml.yml @@ -59,7 +59,7 @@ jobs: skip-doc: true - os: ubuntu-latest os-name: Ubuntu - ocaml-compiler: "5.3" + ocaml-compiler: "5.4.0~beta2" skip-effects: false skip-test: false skip-doc: false @@ -72,20 +72,20 @@ jobs: # Note this OCaml compiler is bytecode only - os: ubuntu-latest os-name: Ubuntu - ocaml-name: "5.3.0+32bit" - ocaml-compiler: "ocaml-variants.5.3.0+options,ocaml-option-32bit" + ocaml-name: "5.4.0~beta2+32bit" + ocaml-compiler: "ocaml-variants.5.4.0.~beta2+options,ocaml-option-32bit" skip-effects: true # disabled for the same reason than `skip-test` skip-test: true # the `time_now.0.17` package is pulled and doesn't work in 32 bits :( skip-doc: true - os: macos-latest os-name: MacOS - ocaml-compiler: "5.3" + ocaml-compiler: "5.4.0~beta2" skip-effects: true skip-test: false skip-doc: true - os: windows-latest os-name: Windows - ocaml-compiler: "5.3" + ocaml-compiler: "5.4.0~beta2" skip-effects: false skip-test: false skip-doc: true diff --git a/compiler/tests-ocaml/lib-list/test.ml b/compiler/tests-ocaml/lib-list/test.ml index 227c454775..6f56e35365 100644 --- a/compiler/tests-ocaml/lib-list/test.ml +++ b/compiler/tests-ocaml/lib-list/test.ml @@ -68,13 +68,13 @@ let () = assert (List.take 3 [1; 2; 3; 4; 5] = [1; 2; 3]); assert (List.take 3 [1; 2] = [1; 2]); assert (List.take 3 [] = []); - assert ((try List.take (-1) [1; 2] with Invalid_argument _ -> [999]) = [999]); + assert (List.take (-1) [1; 2] = []); assert (List.take 0 [1; 2] = []); assert (List.drop 6 hello_world = world); assert (List.drop 3 [1; 2; 3; 4; 5] = [4; 5]); assert (List.drop 3 [1; 2] = []); assert (List.drop 3 [] = []); - assert ((try List.drop (-1) [1; 2] with Invalid_argument _ -> [999]) = [999]); + assert (List.drop (-1) [1; 2] = [1; 2]); assert (List.drop 0 [1; 2] = [1; 2]); assert (List.take_while (fun x -> x < 3) [1; 2; 3; 4; 1; 2; 3; 4] = [1; 2]); diff --git a/compiler/tests-toplevel/test_toplevel.expected b/compiler/tests-toplevel/test_toplevel.expected index 81e85b3449..c6e778709b 100644 --- a/compiler/tests-toplevel/test_toplevel.expected +++ b/compiler/tests-toplevel/test_toplevel.expected @@ -2,6 +2,6 @@ hello - : int = 2 Line 4, characters 2-4: Error: Syntax error -Line 5, characters 0-16: -Error: Unbound module "Missing_module" +Line 5, characters 0-14: +Error: Unbound module Missing_module val y : float = 0.333333333333333315 From 0a49dedd8da1ab51328afe07447bc82487c801b9 Mon Sep 17 00:00:00 2001 From: Hugo Heuzard Date: Sun, 14 Sep 2025 13:28:08 +0200 Subject: [PATCH 2/5] WIP --- .github/workflows/js_of_ocaml.yml | 2 +- .github/workflows/wasm_of_ocaml.yml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/js_of_ocaml.yml b/.github/workflows/js_of_ocaml.yml index 6a5d38104b..f805e33fe2 100644 --- a/.github/workflows/js_of_ocaml.yml +++ b/.github/workflows/js_of_ocaml.yml @@ -73,7 +73,7 @@ jobs: - os: ubuntu-latest os-name: Ubuntu ocaml-name: "5.4.0~beta2+32bit" - ocaml-compiler: "ocaml-variants.5.4.0.~beta2+options,ocaml-option-32bit" + ocaml-compiler: "ocaml-variants.5.4.0~beta2+options,ocaml-option-32bit" skip-effects: true # disabled for the same reason than `skip-test` skip-test: true # the `time_now.0.17` package is pulled and doesn't work in 32 bits :( skip-doc: true diff --git a/.github/workflows/wasm_of_ocaml.yml b/.github/workflows/wasm_of_ocaml.yml index c964c54c30..c5aaca3b25 100644 --- a/.github/workflows/wasm_of_ocaml.yml +++ b/.github/workflows/wasm_of_ocaml.yml @@ -35,26 +35,26 @@ jobs: include: - os: macos-latest os-name: MacOS - ocaml-compiler: "5.3" + ocaml-compiler: "5.4.0~beta2" separate_compilation: true jane_street_tests: false all_jane_street_tests: false - os: windows-latest os-name: Windows - ocaml-compiler: "5.3" + ocaml-compiler: "5.4.0~beta2" separate_compilation: true # Jane Street tests disabled for now (basement only works on Linux) jane_street_tests: false all_jane_street_tests: false - os: ubuntu-latest os-name: Ubuntu - ocaml-compiler: "5.3" + ocaml-compiler: "5.4.0~beta2" separate_compilation: true jane_street_tests: true all_jane_street_tests: true - os: ubuntu-latest os-name: Ubuntu - ocaml-compiler: "5.3" + ocaml-compiler: "5.4.0~beta2" separate_compilation: false jane_street_tests: true all_jane_street_tests: false From fb31da2fb6b08263e3ee05c9c3c341ab2051f861 Mon Sep 17 00:00:00 2001 From: Hugo Heuzard Date: Sun, 14 Sep 2025 14:03:27 +0200 Subject: [PATCH 3/5] WIP --- .github/workflows/js_of_ocaml.yml | 15 ++++----------- .github/workflows/wasm_of_ocaml.yml | 8 ++++---- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/.github/workflows/js_of_ocaml.yml b/.github/workflows/js_of_ocaml.yml index f805e33fe2..755efb1980 100644 --- a/.github/workflows/js_of_ocaml.yml +++ b/.github/workflows/js_of_ocaml.yml @@ -59,7 +59,7 @@ jobs: skip-doc: true - os: ubuntu-latest os-name: Ubuntu - ocaml-compiler: "5.4.0~beta2" + ocaml-compiler: "ocaml-base-compiler.5.4.0~beta2" skip-effects: false skip-test: false skip-doc: false @@ -79,24 +79,17 @@ jobs: skip-doc: true - os: macos-latest os-name: MacOS - ocaml-compiler: "5.4.0~beta2" + ocaml-compiler: "ocaml-base-compiler.5.4.0~beta2" skip-effects: true skip-test: false skip-doc: true - os: windows-latest os-name: Windows - ocaml-compiler: "5.4.0~beta2" + ocaml-compiler: "ocaml-base-compiler.5.4.0~beta2" skip-effects: false skip-test: false skip-doc: true - - os: ubuntu-latest - os-name: Ubuntu - ocaml-name: "5.4-alpha1" - ocaml-compiler: "ocaml-compiler.5.4.0~alpha1" - skip-effects: true - skip-test: true - skip-doc: true - + runs-on: ${{ matrix.os }} name: diff --git a/.github/workflows/wasm_of_ocaml.yml b/.github/workflows/wasm_of_ocaml.yml index c5aaca3b25..0431367da7 100644 --- a/.github/workflows/wasm_of_ocaml.yml +++ b/.github/workflows/wasm_of_ocaml.yml @@ -35,26 +35,26 @@ jobs: include: - os: macos-latest os-name: MacOS - ocaml-compiler: "5.4.0~beta2" + ocaml-compiler: "ocaml-base-compiler.5.4.0~beta2" separate_compilation: true jane_street_tests: false all_jane_street_tests: false - os: windows-latest os-name: Windows - ocaml-compiler: "5.4.0~beta2" + ocaml-compiler: "ocaml-base-compiler.5.4.0~beta2" separate_compilation: true # Jane Street tests disabled for now (basement only works on Linux) jane_street_tests: false all_jane_street_tests: false - os: ubuntu-latest os-name: Ubuntu - ocaml-compiler: "5.4.0~beta2" + ocaml-compiler: "ocaml-base-compiler.5.4.0~beta2" separate_compilation: true jane_street_tests: true all_jane_street_tests: true - os: ubuntu-latest os-name: Ubuntu - ocaml-compiler: "5.4.0~beta2" + ocaml-compiler: "ocaml-base-compiler.5.4.0~beta2" separate_compilation: false jane_street_tests: true all_jane_street_tests: false From 2740812302903aca82ce245949e66c20ecc84bc5 Mon Sep 17 00:00:00 2001 From: Hugo Heuzard Date: Tue, 16 Sep 2025 10:13:03 +0200 Subject: [PATCH 4/5] WIP --- dune-project | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dune-project b/dune-project index 676fe82cb9..f9c0ca4ec2 100644 --- a/dune-project +++ b/dune-project @@ -20,7 +20,7 @@ (ocaml (and (>= 4.13) (< 5.5))) (num :with-test) (ppx_expect (and (>= v0.16.1) :with-test)) - (ppxlib (>= 0.35)) + (ppxlib (>= 0.37.0~5.4preview)) (re :with-test) (cmdliner (>= 1.1.0)) (sedlex (>= 3.3)) @@ -62,7 +62,7 @@ (depends (ocaml (>= 4.13)) (js_of_ocaml (= :version)) - (ppxlib (>= 0.35)) + (ppxlib (>= 0.37.0~5.4preview)) (num :with-test) (ppx_expect (and (>= v0.14.2) :with-test)) (re (and (>= 1.9.0) :with-test)) @@ -76,7 +76,7 @@ (depends (ocaml (>= 4.13)) (js_of_ocaml (= :version)) - (ppxlib (>= 0.35)) + (ppxlib (>= 0.37.0~5.4preview)) (num :with-test) (ppx_expect (and (>= v0.14.2) :with-test)) (re (and (>= 1.9.0) :with-test)) @@ -95,7 +95,7 @@ (graphics :with-test) (num :with-test) (ppx_expect (and (>= v0.14.2) :with-test)) - (ppxlib (>= 0.35)) + (ppxlib (>= 0.37.0~5.4preview)) (re (and (>= 1.9.0) :with-test)) )) @@ -126,7 +126,7 @@ (js_of_ocaml-compiler (= :version)) (num :with-test) (ppx_expect (and (>= v0.14.2) :with-test)) - (ppxlib (>= 0.35)) + (ppxlib (>= 0.37.0~5.4preview)) (re (and (>= 1.9.0) :with-test)) )) @@ -140,7 +140,7 @@ (js_of_ocaml (= :version)) (num :with-test) (ppx_expect (and (>= v0.14.2) :with-test)) - (ppxlib (>= 0.35)) + (ppxlib (>= 0.37.0~5.4preview)) (re :with-test) (cmdliner (>= 1.1.0)) (opam-format :with-test) From 98e28eeca2bf33b7583967f0e8700e7f09a94230 Mon Sep 17 00:00:00 2001 From: Hugo Heuzard Date: Tue, 16 Sep 2025 10:16:43 +0200 Subject: [PATCH 5/5] WIP --- .github/workflows/wasm_of_ocaml.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/wasm_of_ocaml.yml b/.github/workflows/wasm_of_ocaml.yml index 0431367da7..032b54414e 100644 --- a/.github/workflows/wasm_of_ocaml.yml +++ b/.github/workflows/wasm_of_ocaml.yml @@ -123,7 +123,7 @@ jobs: run: | opam repo add js janestreet/opam-repository opam install opam-format - opam pin add ppxlib -n 0.35.0 + opam pin add ppxlib -n 0.37.0~5.4preview opam exec -- dune exec --root wasm_of_ocaml tools/ci_setup.exe - name: Pin Jane Street packages