An error from read in FrameReceiverTCPRxThread can cause integer underflow in number of bytes received

[BenBradnick]

An error return value of read is not currently handled by FrameReceiverTCPRxThread::handle_receive_socket. A return value of -1 to indicate an error can currently result in the number of bytes received to be 2**64 -1 due to underflow:

  size_t bytes_received = 0;

  while (bytes_received < message_size) {
    int msg_len =
        read(recv_socket_, frame_buffer, message_size - bytes_received);
    bytes_received += msg_len;
    frame_buffer += msg_len;
  }

This then tells the decoder that there are 18446744073709551615 bytes to process.

[GDYendell]

Thanks @BenBradnick !

@jsouter could you take a look at this? It should just check the return is >= 0 to indicate success before adding it and probably should print an error otherwise.

[jsouter]

Good spot, I will take a look. @GDYendell could you assign this to me?

[jsouter]

PR #392