[FIX] l10n_es_edi_tbai_pos: fix tests

Author: sjai-odoo

addons/l10n_es_edi_tbai_pos/models/pos_order.py

@@ -63,22 +63,29 @@ def _compute_l10n_es_tbai_state(self):
     # OVERRIDES
     # -------------------------------------------------------------------------
 
-    def _process_saved_order(self, draft):
-        if not self.l10n_es_tbai_is_required:
-            return super()._process_saved_order(draft)
-
-        self.ensure_one()
-
-        if not self.to_invoice and self.amount_total > self.company_id.l10n_es_simplified_invoice_limit:
-            raise UserError(self.env._("Please create an invoice for an amount over %s.", self.company_id.l10n_es_simplified_invoice_limit))
-
-        if self.refunded_order_id:
-            if self.to_invoice and not self.refunded_order_id.account_move:
-                raise UserError(self.env._("You cannot invoice a refund whose linked order hasn't been invoiced."))
-            if not self.to_invoice and self.refunded_order_id.account_move:
-                raise UserError(self.env._("Please invoice the refund as the linked order has been invoiced."))
+    @api.model_create_multi
+    def create(self, vals_list):
+        pos_orders = super().create(vals_list)
+        if self.l10n_es_tbai_is_required:
+            pos_orders._check_order()
+        return pos_orders
+
+    def write(self, vals):
+        order = super().write(vals)
+        for order in self:
+            if order.l10n_es_tbai_is_required:
+                self._check_order()
+        return order
 
-        return super()._process_saved_order(draft)
+    def _check_order(self):
+        for order in self:
+            if not order.to_invoice and order.amount_total > order.company_id.l10n_es_simplified_invoice_limit:
+                raise UserError(self.env._("Please create an invoice for an amount over %s.", self.company_id.l10n_es_simplified_invoice_limit))
+            if order.refunded_order_id:
+                if order.to_invoice and not order.refunded_order_id.account_move:
+                    raise UserError(self.env._("You cannot invoice a refund whose linked order hasn't been invoiced."))
+                if not order.to_invoice and order.refunded_order_id.account_move:
+                    raise UserError(self.env._("Please invoice the refund as the linked order has been invoiced."))
 
     def action_pos_order_paid(self):
         res = super().action_pos_order_paid()

addons/l10n_es_edi_tbai_pos/tests/test_tbai_pos.py

@@ -68,9 +68,9 @@ def test_tbai_refund_pos_order(self):
         pos_refund = self.env['pos.order'].browse(refund_action['res_id'])
 
         # An error is raised if the refund is invoiced
-        pos_refund.to_invoice = True
         with self.assertRaises(UserError):
-            self.pay_pos_order(pos_refund)
+            pos_refund.to_invoice = True
+        self.pay_pos_order(pos_refund)
 
         # Now works with the refund not invoiced
         pos_refund.to_invoice = False

addons/l10n_es_pos/static/src/app/screens/payment_screen/payment_screen.js

@@ -51,14 +51,15 @@ patch(PaymentScreen.prototype, {
         }
         return false;
     },
-    // shouldDownloadInvoice() {
-    //     return this.pos.config.is_spanish
-    //         ? !this.currentOrder.is_l10n_es_simplified_invoice
-    //         : super.shouldDownloadInvoice();
-    // },
+    shouldDownloadInvoice() {
+        return this.pos.config.is_spanish
+            ? !this.currentOrder.is_l10n_es_simplified_invoice
+            : super.shouldDownloadInvoice();
+    },
     async _postPushOrderResolve(order, order_server_ids) {
+        await this.pos.data.read("pos.order", [order.id]);
         if (this.pos.config.is_spanish) {
-            order.invoice_name = order.account_move?.name;;
+            order.invoice_name = order.account_move?.name;
         }
         return super._postPushOrderResolve(...arguments);
     },

addons/l10n_es_pos/tests/test_frontend.py

@@ -34,7 +34,7 @@ def get_number_of_regular_invoices():
         self.main_pos_config.l10n_es_simplified_invoice_journal_id = simp
         # this `limit` value is linked to the `SIMPLIFIED_INVOICE_LIMIT` const in the tour
         self._get_main_company().l10n_es_simplified_invoice_limit = 1000
-        self.main_pos_config.with_user(self.pos_admin).open_ui()
+        self.main_pos_config.with_user(self.pos_user).open_ui()
         self.start_pos_tour("spanish_pos_tour", login="accountman")
         num_of_simp_invoices = self.env['account.move'].search_count([('journal_id', '=', simp.id), ('l10n_es_is_simplified', '=', True)])
         num_of_regular_invoices = get_number_of_regular_invoices() - initial_number_of_regular_invoices

addons/l10n_test_pos_qr_payment/tests/test_pos_qr_payment.py

@@ -228,4 +228,4 @@ def test_02_pos_order_with_pix_qr_payment(self):
 
         self.main_pos_config.with_user(self.pos_user).open_ui()
 
-        self.start_tour("/pos/ui/%d" % self.main_pos_config.id, 'PaymentScreenWithQRPayment', login="pos_user")
+        self.start_tour("/pos/ui/%d" % self.main_pos_config.id, 'PaymentScreenWithQRPayment', login="pos_user")